Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2473

Remove DAS v2 code

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          0.5
        • Epic Link:
        • Sprint:
          Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 3 Aug - 14 Aug

          Description

          We no longer support DAS v2. Let's remove the code from the project.

          Note: This will affect many places in the code, notably:

          • Places where default data sources are configured - see IGB Preferences JSON file
          • DAS v2 module itself: "Core - DAS 2 (data source) module"
          • POM files that declare dependencies on the DAS2 module within IGB

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. HELP-370 UCSC

              • Blocker - Blocks development and/or testing work, production could not run.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. IGBF-2474 Remove DAS v1 support (UCSC DAS v1 service not responding)

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

                The code changes are present here:
                https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2473#diff
                Moving to First Level Review. Kindly review.

                For testing:
                Go to the "Downloads" section of my fork and download IGBF-2473 branch installer.
                Check if the IGB is functioning properly after removing the DAS v2 support from the codebase.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited The code changes are present here: https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2473#diff Moving to First Level Review. Kindly review. For testing: Go to the "Downloads" section of my fork and download IGBF-2473 branch installer. Check if the IGB is functioning properly after removing the DAS v2 support from the codebase.
                Hide
                Permalink
                prutha Prutha Kulkarni (Inactive) added a comment -

                Shamika Gajanan Kulkarni, i have followed the steps that are mentioned above to test if the IGB is functioning properly even after the removal of DASv2 dependency. Everything is working as expected and removing the DASv2 support hasn't affected IGB in any way.

                You can submit a PR for the same.

                Show
                prutha Prutha Kulkarni (Inactive) added a comment - Shamika Gajanan Kulkarni , i have followed the steps that are mentioned above to test if the IGB is functioning properly even after the removal of DASv2 dependency. Everything is working as expected and removing the DASv2 support hasn't affected IGB in any way. You can submit a PR for the same.
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

                PR submitted. Kindly review.
                https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/814/igbf-2473-remove-das-v2-code/diff

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - PR submitted. Kindly review. https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/814/igbf-2473-remove-das-v2-code/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged. Please test using master branch installer from team repository.

                Show
                ann.loraine Ann Loraine added a comment - Merged. Please test using master branch installer from team repository.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Request for Shamika Gajanan Kulkarni:

                Could you provide guidance on how to test - what things to check for in the application?

                Show
                ann.loraine Ann Loraine added a comment - Request for Shamika Gajanan Kulkarni : Could you provide guidance on how to test - what things to check for in the application?
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

                For testing:
                Download the master branch installer and install IGB. Check if IGB functions properly after removing DAS V2 support from the codebase. Genomes should load properly. Check if the name and url for DAS v2 has been removed from 'Data Sources' in IGB Preferences.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - For testing: Download the master branch installer and install IGB. Check if IGB functions properly after removing DAS V2 support from the codebase. Genomes should load properly. Check if the name and url for DAS v2 has been removed from 'Data Sources' in IGB Preferences.
                Hide
                Permalink
                prutha Prutha Kulkarni (Inactive) added a comment -

                I have downloaded the master branch installer and opened the "IGB preferences" to check if it still has DAS V2. Since the DAS v2 support is now removed from IGB, the DAS v2 wasn't there. Rest of the IGB functionality is working fine even after the removal of DAS v2 support.
                Shamika Gajanan Kulkarni moving the ticket to done.

                Show
                prutha Prutha Kulkarni (Inactive) added a comment - I have downloaded the master branch installer and opened the "IGB preferences" to check if it still has DAS V2. Since the DAS v2 support is now removed from IGB, the DAS v2 wasn't there. Rest of the IGB functionality is working fine even after the removal of DAS v2 support. Shamika Gajanan Kulkarni moving the ticket to done.

                  People

                  • Assignee:
                    shamika Shamika Gajanan Kulkarni (Inactive)
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: