Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2476

Fix newline character breaking metadata comments

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Situation: Users can add metadata to files and folders in BioViz Connect. The Comments section of the metadata allows for text to be entered.

      Problem: When a user enters a newline character in the Comments section of the metadata and clicks save the "saved" toast is appearing. However, after closing and re-opening the metadata panel the text has not been saved. This appears to completely break the Comments section as any new text added to the Comments section cannot be saved.

      To reproduce:
      Open BioViz Connect: bioviz.org/connect.html
      Login and select a file.
      Right-click and select metadata.
      In the metadata right-panel enter the following including the blank line:

      This is my

      example.

      Click Save.
      Close the right panel.
      Re-open the metadata right-panel.
      There should be no text in the Comments section and attempting to add additional text and save should fail.

      Task: Implement a fix so that new line characters no longer break the Comments metadata section.

      Note: Please test special characters, tabs, and any other whitespace characters you can think of.

        Attachments

          Activity

          Hide
          nfreese Nowlan Freese added a comment -

          Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/173/igbf-2476

          Chaitanya Kintali can you pull master onto your EC2 and let me know so I can test?

          Show
          nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/173/igbf-2476 Chaitanya Kintali can you pull master onto your EC2 and let me know so I can test?
          Hide
          chaitanya Chaitanya Kintali (Inactive) added a comment -

          Code Change Link:

          https://bitbucket.org/nfreese/django-cyversedev/pull-requests/173/igbf-2476/diff

          Nowlan Freese
          Could you please test the following code changes.
          Moving to Needs testing.

          Show
          chaitanya Chaitanya Kintali (Inactive) added a comment - Code Change Link: https://bitbucket.org/nfreese/django-cyversedev/pull-requests/173/igbf-2476/diff Nowlan Freese Could you please test the following code changes. Moving to Needs testing.
          Hide
          chaitanya Chaitanya Kintali (Inactive) added a comment -

          Done.

          Chaitanya.bioviz.org now has the latest master branch.

          Show
          chaitanya Chaitanya Kintali (Inactive) added a comment - Done. Chaitanya.bioviz.org now has the latest master branch.
          Hide
          nfreese Nowlan Freese added a comment -

          Working correctly.

          Closing issue.

          Show
          nfreese Nowlan Freese added a comment - Working correctly. Closing issue.

            People

            • Assignee:
              chaitanya Chaitanya Kintali (Inactive)
              Reporter:
              nfreese Nowlan Freese
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: