Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Summer 4: 14 Jul - 28 Jul
Description
Situation: Users can add metadata to files and folders in BioViz Connect. The Comments section of the metadata allows for text to be entered.
Problem: When a user enters a newline character in the Comments section of the metadata and clicks save the "saved" toast is appearing. However, after closing and re-opening the metadata panel the text has not been saved. This appears to completely break the Comments section as any new text added to the Comments section cannot be saved.
To reproduce:
Open BioViz Connect: bioviz.org/connect.html
Login and select a file.
Right-click and select metadata.
In the metadata right-panel enter the following including the blank line:
This is my
example.
Click Save.
Close the right panel.
Re-open the metadata right-panel.
There should be no text in the Comments section and attempting to add additional text and save should fail.
Task: Implement a fix so that new line characters no longer break the Comments metadata section.
Note: Please test special characters, tabs, and any other whitespace characters you can think of.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2376 [ 18533 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Code Change Link:
https://bitbucket.org/nfreese/django-cyversedev/pull-requests/173/igbf-2476/diff
Nowlan Freese
Could you please test the following code changes.
Moving to Needs testing.
Done.
Chaitanya.bioviz.org now has the latest master branch.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Working correctly.
Closing issue.
| Assignee | Nowlan Freese [ nfreese ] | Chaitanya Kintali [ chaitanya ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/173/igbf-2476
Chaitanya Kintali can you pull master onto your EC2 and let me know so I can test?