Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2477

Show feedback when clicking genome on Genome Dashboard

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Situation: On the genome dashboard, when a user clicks on the image of an organism or on the specific genome version, the genome is loaded in IGB (assuming IGB is running).

          Problem: When the user clicks on the genome, there is no visual feedback that their click was registered or that the genome is loading. This may be confusing to the user.

          Task: Implement some kind of visual feedback that the user's click was registered. This could be implemented in several ways:
          1) Make the organism image and specific genome versions appear as buttons when clicked.
          2) A non-intrusive notification (such as a toast) appears informing the user that the genome is being loaded in IGB and then disappears after 5 seconds.
          3) Immediately bring IGB to the front. http://localhost:7085/bringIGBToFront

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              pbadzuh Philip Badzuh (Inactive) added a comment - - edited

              I decided to implement option three from the description. Please review my branch below:
              https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2477#diff

              • I have added a waiting period between the two IGB API requests, since without this, the second request seems to override and cancel the first. This may be due to the fact that requests are registered on different threads, resulting in conflicts of some sort.

              (test)

              Show
              pbadzuh Philip Badzuh (Inactive) added a comment - - edited I decided to implement option three from the description. Please review my branch below: https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2477#diff I have added a waiting period between the two IGB API requests, since without this, the second request seems to override and cancel the first. This may be due to the fact that requests are registered on different threads, resulting in conflicts of some sort. (test)
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Code changes look good. I like that you refactored a file name to reflect its enhanced function:

              • public/javascripts/ IgbStatus.js > IgbEndpoints.js

              Please submit PR.

              Also, a request:

              Please configure fork to link back to Jira ticket. For details, please see:

              Show
              ann.loraine Ann Loraine added a comment - Code changes look good. I like that you refactored a file name to reflect its enhanced function: public/javascripts/ IgbStatus.js > IgbEndpoints.js Please submit PR. Also, a request: Please configure fork to link back to Jira ticket. For details, please see: "Add Jira link" in: https://canvas.instructure.com/courses/1164217/pages/set-up-your-fork-fork-igb-add-jira-link-add-ssh-key?module_item_id=31871518
              Hide
              Permalink
              pbadzuh Philip Badzuh (Inactive) added a comment - - edited

              Great! Please see the PR below:
              https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/26/igbf-2477-bring-igb-to-front-when-opening/diff

              Regarding the linking my fork to jira, I just double checked my settings and the link exists, so my commits should be linking to jira. Please let me know if this isn't the case.

              Show
              pbadzuh Philip Badzuh (Inactive) added a comment - - edited Great! Please see the PR below: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/26/igbf-2477-bring-igb-to-front-when-opening/diff Regarding the linking my fork to jira, I just double checked my settings and the link exists, so my commits should be linking to jira. Please let me know if this isn't the case.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged. Deployed to https://test.bioviz.org for testing.

              Show
              ann.loraine Ann Loraine added a comment - Merged. Deployed to https://test.bioviz.org for testing.
              Hide
              Permalink
              gchamma Jay Chamma (Inactive) added a comment -

              [~aloraine] test.bioviz.org cannot be reached

              Show
              gchamma Jay Chamma (Inactive) added a comment - [~aloraine] test.bioviz.org cannot be reached
              Hide
              Permalink
              prutha Prutha Kulkarni (Inactive) added a comment -

              As mentioned by Philip Badzuh, the option 3 has been implemented for showing the feedback.

              Steps followed:
              1) Go to https://test.bioviz.org.
              2) Click on IGB Genomes in order to load Genome Dashboard.
              3) Click on a specific genome.
              4) Then click on the View in IGB option which brings the IGB in front.

              Submitting the ticket to done.

              Show
              prutha Prutha Kulkarni (Inactive) added a comment - As mentioned by Philip Badzuh , the option 3 has been implemented for showing the feedback. Steps followed: 1) Go to https://test.bioviz.org . 2) Click on IGB Genomes in order to load Genome Dashboard. 3) Click on a specific genome. 4) Then click on the View in IGB option which brings the IGB in front. Submitting the ticket to done.

                People

                • Assignee:
                  pbadzuh Philip Badzuh (Inactive)
                  Reporter:
                  nfreese Nowlan Freese
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: