Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:0.25
-
Epic Link:
-
Sprint:Summer 4: 14 Jul - 28 Jul
Description
Please see linked issue: https://jira.transvar.org/browse/IGBF-1986
In the above ticket, we removed some old code from IGB that is no longer supported or being used.
We deleted some files and also commented out code that referred to the deleted files and their dependencies.
For this task, review the commits in the above ticket and delete the code that was commented out.
Attachments
Issue Links
- relates to
-
IGBF-1986 Clean up and streamline dependencies, deploy to maven central
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
Please see linked issue: https://jira.transvar.org/browse/IGBF-198
In the above ticket, we removed some old code from IGB that is no longer supported or being used. We deleted some files and also commented out code that referred to the deleted files and their dependencies. For this task, review the commits in the above ticket and delete the code that was commented out. |
Please see linked issue: https://jira.transvar.org/browse/IGBF-1986
In the above ticket, we removed some old code from IGB that is no longer supported or being used. We deleted some files and also commented out code that referred to the deleted files and their dependencies. For this task, review the commits in the above ticket and delete the code that was commented out. |
| Epic Link | IGBF-1531 [ 17617 ] |
| Sprint | Summer 4: 14 Jul - 28 Jul [ 99 ] | |
| Labels | Beginner |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Jay Chamma - could you review the above branch just to double-check that the commented code from your earlier commit is now removed?
If nothing else needs to be done to remove the commented code, then please move forward to "Ready for Pull Request" and re-assign to Prutha Kulkarni.
| Assignee | Prutha Kulkarni [ prutha ] |
| Assignee | Jay Chamma [ gchamma ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Post review:
Code commented from my previous commit has been successfully removed.
Steps taken to verify this:
- Cloned Prutha Kulkarni's repository on my computer.
- Checkout out branch
IGBF-2479. - Verified the deletion of the comments from my earlier commit.
Moving this ticket to "Ready for Pull Request" and re-assigning it to Prutha Kulkarni.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Jay Chamma [ gchamma ] | Prutha Kulkarni [ prutha ] |
Dr. [~aloraine], I have submitted the PR.
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/812/igbf-2479-delete-commented-code-from-igbf/diff
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested this ticket. IGB works as expected. The deleted code is same as the one commented by Jay in IGBF-1986. Moving to closed.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Prutha Kulkarni [ prutha ] |
The code changes are present at:
https://bitbucket.org/pkulka10/igb_prutha/commits/cf69fc537efed2e3f0fd6e4a5a2d670e20a04879