Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2479

Delete commented code from IGBF-1986

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:

          Description

          Please see linked issue: https://jira.transvar.org/browse/IGBF-1986

          In the above ticket, we removed some old code from IGB that is no longer supported or being used.

          We deleted some files and also commented out code that referred to the deleted files and their dependencies.

          For this task, review the commits in the above ticket and delete the code that was commented out.

            Attachments

              Issue Links

              relates to

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-1986 Clean up and streamline dependencies, deploy to maven central

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                prutha Prutha Kulkarni (Inactive) added a comment -

                The code changes are present at:
                https://bitbucket.org/pkulka10/igb_prutha/commits/cf69fc537efed2e3f0fd6e4a5a2d670e20a04879

                Show
                prutha Prutha Kulkarni (Inactive) added a comment - The code changes are present at: https://bitbucket.org/pkulka10/igb_prutha/commits/cf69fc537efed2e3f0fd6e4a5a2d670e20a04879
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                Jay Chamma - could you review the above branch just to double-check that the commented code from your earlier commit is now removed?

                If nothing else needs to be done to remove the commented code, then please move forward to "Ready for Pull Request" and re-assign to Prutha Kulkarni.

                Show
                ann.loraine Ann Loraine added a comment - - edited Jay Chamma - could you review the above branch just to double-check that the commented code from your earlier commit is now removed? If nothing else needs to be done to remove the commented code, then please move forward to "Ready for Pull Request" and re-assign to Prutha Kulkarni .
                Hide
                Permalink
                gchamma Jay Chamma (Inactive) added a comment -

                Post review:
                Code commented from my previous commit has been successfully removed.

                Steps taken to verify this:

                1. Cloned Prutha Kulkarni's repository on my computer.
                2. Checkout out branch IGBF-2479.
                3. Verified the deletion of the comments from my earlier commit.

                Moving this ticket to "Ready for Pull Request" and re-assigning it to Prutha Kulkarni.

                Show
                gchamma Jay Chamma (Inactive) added a comment - Post review: Code commented from my previous commit has been successfully removed. Steps taken to verify this: Cloned Prutha Kulkarni 's repository on my computer. Checkout out branch IGBF-2479 . Verified the deletion of the comments from my earlier commit. Moving this ticket to "Ready for Pull Request" and re-assigning it to Prutha Kulkarni .
                Hide
                Permalink
                prutha Prutha Kulkarni (Inactive) added a comment -

                Dr. [~aloraine], I have submitted the PR.
                https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/812/igbf-2479-delete-commented-code-from-igbf/diff

                Show
                prutha Prutha Kulkarni (Inactive) added a comment - Dr. [~aloraine] , I have submitted the PR. https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/812/igbf-2479-delete-commented-code-from-igbf/diff
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

                Tested this ticket. IGB works as expected. The deleted code is same as the one commented by Jay in IGBF-1986. Moving to closed.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Tested this ticket. IGB works as expected. The deleted code is same as the one commented by Jay in IGBF-1986 . Moving to closed.

                  People

                  • Assignee:
                    prutha Prutha Kulkarni (Inactive)
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: