Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2509

Investigate: choosing "None" as the "Color By" value does nothing

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Right clicking a track label and choosing "Color by.." option pops up a window with the value "None" being chosen by default for the "Color by" value.
      The user can change this value using a drop-down menu to many other options. The issue is that choosing "None" does not do anything once a user changes the value to something else.

      For example, if a user changes the "Color by.." value from "None" to "Property" then clicking "Okay", color changes would take effect for that selected track, however if the user goes back to the "Color by.." window and selects "None", an error would pop up in console, and the drop-down menu does not close after "None" has been chosen. The user can manually click off the drop-down menu after choosing "None", but even after doing so and clicking "Okay", the colors would not revert back to the original color.

      Going back to "Color by.." afterwards, the value chosen would be "Property" as if it was not changed back.

      Please see the attached text file to view the error message.

        Attachments

          Activity

          gchamma Jay Chamma (Inactive) created issue -
          gchamma Jay Chamma (Inactive) made changes -
          Field Original Value New Value
          Epic Link IGBF-1765 [ 17855 ]
          gchamma Jay Chamma (Inactive) made changes -
          Summary Invistigate: choosing "None" as the "Color By" value does nothing Investigate: choosing "None" as the "Color By" value does nothing
          gchamma Jay Chamma (Inactive) made changes -
          Description Right clicking a track label and choosing "Color by.." option pops up a window with the value "None" being chosen by default for the "Color by" value.
          The user can change this value using a drop-down menu to many other options. The issue is that choosing "None" does not do anything once a user changes the value to something else.

          For example, if a user changes the "Color by.." value from "None" to "Property" then clicking "Okay", color changes would take effect for that selected track, however if the user goes back to the "Color by.." window and selects "None", an error would pop up in console, and the drop-down menu does not close after "None" has been chosen. The user can manually click off the drop-down menu after choosing "None", but even after doing so and clicking "Okay", the colors would not revert back to the original color.

          Going back to "Color by.." afterwards, the value chosen would be "Property" as if it was not changed back.

          Please see the attached text file to view the error message.
          Right clicking a track label and choosing "Color by.." option pops up a window with the value "None" being chosen by default for the "Color by" value.
          The user can change this value using a drop-down menu to many other options. The issue is that choosing "None" does not do anything once a user changes the value to something else.

          For example, if a user changes the "Color by.." value from "None" to "Property" then clicking "Okay", color changes would take effect for that selected track, however if the user goes back to the "Color by.." window and selects "None", an error would pop up in console, and the drop-down menu does not close after "None" has been chosen. The user can manually click off the drop-down menu after choosing "None", but even after doing so and clicking "Okay", the colors would not revert back to the original color.

          Going back to "Color by.." afterwards, the value chosen would be "Property" as if it was not changed back.

          !https://i.imgur.com/5kUFQJN.png!

          Please see the attached text file to view the error message.
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Ann Loraine [ aloraine ] Noor Zahara [ noor91zahara ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Sprint Summer 7: 31 Aug - 11 Sep [ 102 ] Summer 6: 17 Aug - 28 Aug [ 101 ]
          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Code diff - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2509#diff
          noor91zahara Noor Zahara (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          Hide
          ssegu Sai Supreeth Segu (Inactive) added a comment -

          I have reviewed the ticket. The issue is fixed now. If I select a value from the drop-down this is reflecting in the selected track and also if I select None again it is going back to the original color. Everything looks fine. Please go ahead and submit a pull request.

          cc: Noor Zahara

          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - I have reviewed the ticket. The issue is fixed now. If I select a value from the drop-down this is reflecting in the selected track and also if I select None again it is going back to the original color. Everything looks fine. Please go ahead and submit a pull request. cc: Noor Zahara
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          ssegu Sai Supreeth Segu (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          Show
          noor91zahara Noor Zahara (Inactive) added a comment - PR Created - https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/822/igbf-2509-fix-null-pointer-exception-while/diff
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          PR merged and master branch installers are built and ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - PR merged and master branch installers are built and ready for testing.
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          ann.loraine Ann Loraine made changes -
          Sprint Summer 6: 17 Aug - 28 Aug [ 101 ] Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 101, 102 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]
          Hide
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

          Tested this ticket. Steps followed to test:
          1) Loaded a track data for A_thaliana_Jun_2009
          2) Right clicked on track label and selected the option "Color by"
          3) Chose different options from drop-down menu like "Property", "Length" and observed the color changes of the track.
          4) Chose the "None" option from drop-down menu for "Color by" to observe that the color of the track changes back to default color.
          Moving to closed.

          Show
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Tested this ticket. Steps followed to test: 1) Loaded a track data for A_thaliana_Jun_2009 2) Right clicked on track label and selected the option "Color by" 3) Chose different options from drop-down menu like "Property", "Length" and observed the color changes of the track. 4) Chose the "None" option from drop-down menu for "Color by" to observe that the color of the track changes back to default color. Moving to closed.
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
          shamika Shamika Gajanan Kulkarni (Inactive) made changes -
          Assignee Shamika Gajanan Kulkarni [ shamika ]

            People

            • Assignee:
              Unassigned
              Reporter:
              gchamma Jay Chamma (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: