Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2510

Investigate: Vertically zoomed-in track after hiding then enabling it

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Clicking the "eye" symbol for a track in the Data Management Table hides it, and clicking it again re-enables the track.
      The problem is that when the user clicks the "eye" symbol to re-display the track after hiding it, the track re-appears with it fully or partially vertically zoomed-in.

      Please see the attached screenshots for clarification.

        Attachments

          Activity

          Hide
          noor91zahara Noor Zahara added a comment - - edited

          This issue is occurring due to stretchToFit(...) {} being called twice within repackTheTiers(). Once with stretch_vertically param being false which modifies the Y axis and again with stretch_vertically being true when (getZoom(Y) < getMinZoom(Y)) || (getZoom(Y) > getMaxZoom(Y))) is satisfied.

          Solution - Remove the second call to stretchToFit within repackTheTiers(). This solves the issue

          Code Diff - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2510#diff

          Show
          noor91zahara Noor Zahara added a comment - - edited This issue is occurring due to stretchToFit(...) {} being called twice within repackTheTiers(). Once with stretch_vertically param being false which modifies the Y axis and again with stretch_vertically being true when (getZoom(Y) < getMinZoom(Y)) || (getZoom(Y) > getMaxZoom(Y))) is satisfied. Solution - Remove the second call to stretchToFit within repackTheTiers(). This solves the issue Code Diff - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2510#diff
          Hide
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

          I reviewed the ticket. The changes are reflecting properly. Noor Zahara Kindly submit a PR for the same.

          Show
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited I reviewed the ticket. The changes are reflecting properly. Noor Zahara Kindly submit a PR for the same.
          Show
          noor91zahara Noor Zahara added a comment - PR Submitted - https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/824/igbf-2510-fix-vertically-zoomed-in-track/diff
          Hide
          aloraine Ann Loraine added a comment -

          Merged and built master branch installers. Ready for testing.

          Note to testers:

          • Observe any changes or differences between how vertical and horizontal zoom settings change when users alter the UI.
          • Make changes to the UI that alter the zoom level - observe any differences between the new IGB with these changes and 9.1.4 (our reference)

          Investigate:

          • What happens when you load a new track of data
          • What happens when you change the window size of IGB

          plus anything else you can think of.

          The goal here is to notice any unexpected behaviors regarding zooming. The change made by Noor removes what appears to have been a hack of some type. Try to find out what problem the hack was trying to solve.

          Show
          aloraine Ann Loraine added a comment - Merged and built master branch installers. Ready for testing. Note to testers: Observe any changes or differences between how vertical and horizontal zoom settings change when users alter the UI. Make changes to the UI that alter the zoom level - observe any differences between the new IGB with these changes and 9.1.4 (our reference) Investigate: What happens when you load a new track of data What happens when you change the window size of IGB plus anything else you can think of. The goal here is to notice any unexpected behaviors regarding zooming. The change made by Noor removes what appears to have been a hack of some type. Try to find out what problem the hack was trying to solve.
          Hide
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

          Tested the ticket. The changes are visible properly.
          Tried the following:
          1) Clicking on eye button hides the track and re-clicking on it displays the track at a zoom level which was present before hiding it.
          2) Loaded multiple tracks and observed the same as above.
          3) Changed the horizontal and vertical zoom settings for single as well as multiple tracks and made same observations.
          4) Changed window size of IGB.
          In each case, the functionality is working fine in IGB installed using master branch installers.
          Moving to closed.

          Show
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Tested the ticket. The changes are visible properly. Tried the following: 1) Clicking on eye button hides the track and re-clicking on it displays the track at a zoom level which was present before hiding it. 2) Loaded multiple tracks and observed the same as above. 3) Changed the horizontal and vertical zoom settings for single as well as multiple tracks and made same observations. 4) Changed window size of IGB. In each case, the functionality is working fine in IGB installed using master branch installers. Moving to closed.

            People

            • Assignee:
              noor91zahara Noor Zahara
              Reporter:
              gchamma Jay Chamma
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: