Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct
Description
In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used.
The label for the action already assigned to the keystroke is displayed (highlighted in yellow in image)
The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action.
This bug happens for the following actions:
- Home
- Load session
- Import Genome [Open Genome from File]
- Save Image
- Thresholding
- View Genomic Sequence
- View Read Sequence
- Configure Web Links
For example:
If a user assigns "CTRL+J" for the action "Load session", then re-assigns "CTRL+J" to any different action, the popup window with the "???" would appear.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Description |
In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used. The label for the action already assigned to the keystroke is displayed (highlighted in yellow in editing) !https://i.imgur.com/rOgr2G5.png! The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action. !https://i.imgur.com/uWCH071.png! This bug happens for the following actions: Home Load session Import Genome Save Image Thresholding View Genomic Sequence View Read Sequence |
In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used. The label for the action already assigned to the keystroke is displayed (highlighted in yellow in image) !https://i.imgur.com/rOgr2G5.png! The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action. !https://i.imgur.com/uWCH071.png! This bug happens for the following actions: Home Load session Import Genome Save Image Thresholding View Genomic Sequence View Read Sequence For example: If a user assigns "CTRL+J" for the action "Load session", then re-assigns "CTRL+J" to any different action, the popup window with the "???" would appear. |
| Description |
In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used. The label for the action already assigned to the keystroke is displayed (highlighted in yellow in image) !https://i.imgur.com/rOgr2G5.png! The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action. !https://i.imgur.com/uWCH071.png! This bug happens for the following actions: Home Load session Import Genome Save Image Thresholding View Genomic Sequence View Read Sequence For example: If a user assigns "CTRL+J" for the action "Load session", then re-assigns "CTRL+J" to any different action, the popup window with the "???" would appear. |
In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used. The label for the action already assigned to the keystroke is displayed (highlighted in yellow in image) !https://i.imgur.com/rOgr2G5.png! The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action. !https://i.imgur.com/uWCH071.png! This bug happens for the following actions: * Home * Load session * Import Genome * Save Image * Thresholding * View Genomic Sequence * View Read Sequence * Configure Web Links For example: If a user assigns "CTRL+J" for the action "Load session", then re-assigns "CTRL+J" to any different action, the popup window with the "???" would appear. |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Please explain for testers:
- How to locate the Preferences toolbar menu in the IGB UI.
| Description |
In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used. The label for the action already assigned to the keystroke is displayed (highlighted in yellow in image) !https://i.imgur.com/rOgr2G5.png! The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action. !https://i.imgur.com/uWCH071.png! This bug happens for the following actions: * Home * Load session * Import Genome * Save Image * Thresholding * View Genomic Sequence * View Read Sequence * Configure Web Links For example: If a user assigns "CTRL+J" for the action "Load session", then re-assigns "CTRL+J" to any different action, the popup window with the "???" would appear. |
In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used. The label for the action already assigned to the keystroke is displayed (highlighted in yellow in image) !https://i.imgur.com/rOgr2G5.png! The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action. !https://i.imgur.com/uWCH071.png! This bug happens for the following actions: * Home * Load session * Import Genome [Open Genome from File] * Save Image * Thresholding * View Genomic Sequence * View Read Sequence * Configure Web Links For example: If a user assigns "CTRL+J" for the action "Load session", then re-assigns "CTRL+J" to any different action, the popup window with the "???" would appear. |
| Sprint | Summer 7: 31 Aug - 11 Sep [ 102 ] | Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 102, 103 ] |
| Rank | Ranked higher |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
The code changes are present here:
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2511#diff
To test:
1) Open IGB
2) Open Preferences Panel from File menu -> Preferences, or from the Shortcuts
3) Select Toolbar section in the popup window
4) You will see some existing keyboard shortcuts. Choose an action option and click on the respective KeyStroke cell. Press the keys you want to put as shortcut for this option. If the shortcuts already exist for other action, an error message should popup displaying the action for which the keystroke exists. Try for the actions mentioned in the description of the ticket. The proper name of the action should be displayed in the error popup instead of '???'.
Kindly test using my branch installer
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Summary | Investigate: Label for an action is missing when re-binding a keystroke | Investigate and Fix: Label for an action is missing when re-binding a keystroke |
Remove the comment from the code - //logger.info("added action: "+genericAction.getDisplay());
Remove an extra line#113 in GenericActionHolder.java
It works fine but one concern I observed is that in MAC when I choose command + key, IGB crashes and closes.
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Is the IGB crashing in MAC after pressing command + key occurring after my changes?
Noor Zahara
Looks like it is an existing issue. We can create a separate ticket to investigate that.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Noor Zahara I have made the changes as suggested by you. Kindly review.
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2511#diff
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Noor Zahara [ noor91zahara ] |
Works fine.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Sprint | Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 102, 103 ] | Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct [ 102, 103, 104 ] |
| Rank | Ranked higher |
Noor Zahara - would you be able to submit the PR for Shamika since she has left for her new job?
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged and master branch installers built. Ready for testing.
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Working as expected.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Noor Zahara [ noor91zahara ] | Shamika Gajanan Kulkarni [ shamika ] |
I was working on this ticket today. I figured there is a discrepancy in the above actions being added to GenericActions Hashmap. Since there is no mapping present for the above actions, the value of genericAction in KeyStrokeEditPanel.java file is null and hence, the value assigned to actionDisplayName is "???" which appears in the dialog box.
I tried to fix this by adding the action to GenericActions hashmap, but the actions which have a default keyStroke value are appearing twice in the Preferences toolbar menu. Will look into this and fix it.