Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2511

Investigate and Fix: Label for an action is missing when re-binding a keystroke

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct

      Description

      In the Toolbar section of the Preferences panel, users can assign and re-assign keystrokes for different actions.
      If a user enters a keystroke to use for an action that is already being used for another action, the following popup window would appear letting the user know that the keystroke they're about to use for an action is already being used.
      The label for the action already assigned to the keystroke is displayed (highlighted in yellow in image)

      The issue is that for some actions, if there is a keystroke assigned to them and then the user tries to re-assign the same keystroke for a different action, the same popup window would appear, but the label for the current assigned action just says "???" instead of the name of the action.

      This bug happens for the following actions:

      • Home
      • Load session
      • Import Genome [Open Genome from File]
      • Save Image
      • Thresholding
      • View Genomic Sequence
      • View Read Sequence
      • Configure Web Links

      For example:
      If a user assigns "CTRL+J" for the action "Load session", then re-assigns "CTRL+J" to any different action, the popup window with the "???" would appear.

        Attachments

          Activity

          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          Works fine.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Works fine.
          Hide
          ann.loraine Ann Loraine added a comment -

          Noor Zahara - would you be able to submit the PR for Shamika since she has left for her new job?

          Show
          ann.loraine Ann Loraine added a comment - Noor Zahara - would you be able to submit the PR for Shamika since she has left for her new job?
          Show
          noor91zahara Noor Zahara (Inactive) added a comment - PR submitted - https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/831/igbf-2511-fix-for-an-action-when-re/diff
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged and master branch installers built. Ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - Merged and master branch installers built. Ready for testing.
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          Working as expected.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Working as expected.

            People

            • Assignee:
              shamika Shamika Gajanan Kulkarni (Inactive)
              Reporter:
              gchamma Jay Chamma (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: