Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2517

Create subdirectory folder in each app's template folder with the name of the app.

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      2.5
    • Sprint:
      Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23

      Description

      Django looks for the template as the apps are installed. So if we have same name template in multiple applications then django will not be able to identify the correct template for that particular application. Therefore moving the templates into a subdirectory named for the application itself would be the easiest way to tell Django which template is the right one.

      For more details please refer Template namespacing from the following link: https://docs.djangoproject.com/en/2.1/intro/tutorial03/

      Folder structure example:

      -submit_app
      ---templates
      --------submit_app
      ------------confirm.html
      ------------error.html
      ------------submit_done.html

        Attachments

          Issue Links

            Activity

            Hide
            aloraine Ann Loraine added a comment - - edited

            Quick request for Chirag Chandrahas Shetty: Please add story points (estimate the time/effort required to implement and test the improvement.)

            (Feel free to un-assign this when done.)

            Show
            aloraine Ann Loraine added a comment - - edited Quick request for Chirag Chandrahas Shetty : Please add story points (estimate the time/effort required to implement and test the improvement.) (Feel free to un-assign this when done.)
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            diff: https://bitbucket.org/chirag06/appstore/commits/1bafde5ae28edf180f29523d2081ca374059176c?at=IGBF-2517

            link for testing: http://devappstore1.bioviz.org/

            admin credentials- username: admin
            password: qwerty@123

            Testing steps:

            Can you log in?
            Can you log in as an "admin" user? Visit https://devappstore1.bioviz.org/admin/ to log in.
            Can you submit an App?
            Do both the admin and the submitter get an email when an App is submitted?
            Can you approve an App (as an admin user)? (Log in as an admin user and click account name on the top right.)
            Can you log in as submitting user and edit the Web page for an App after it's been approved?
            Can you install an App in IGB?
            Try to submit a same application twice and check if app store shows an error message.
            Are any error messages printed to the apache log files? (See: /var/logs/apache2)
            Are any error messages printed to the Django log files? (See: appstore/debug.log)

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - diff: https://bitbucket.org/chirag06/appstore/commits/1bafde5ae28edf180f29523d2081ca374059176c?at=IGBF-2517 link for testing: http://devappstore1.bioviz.org/ admin credentials- username: admin password: qwerty@123 Testing steps: Can you log in? Can you log in as an "admin" user? Visit https://devappstore1.bioviz.org/admin/ to log in. Can you submit an App? Do both the admin and the submitter get an email when an App is submitted? Can you approve an App (as an admin user)? (Log in as an admin user and click account name on the top right.) Can you log in as submitting user and edit the Web page for an App after it's been approved? Can you install an App in IGB? Try to submit a same application twice and check if app store shows an error message. Are any error messages printed to the apache log files? (See: /var/logs/apache2) Are any error messages printed to the Django log files? (See: appstore/debug.log)
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment - - edited

            Chirag Chandrahas Shetty : There are references to the wall of apps in your code. We need to remove that as well. Please refer : IGBF-2519

            Question: Did you pull the latest changes? (Merge the lastest master(lorainelab) with your branch ?)

            cc. Dr. Ann Loraine

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - - edited Chirag Chandrahas Shetty : There are references to the wall of apps in your code. We need to remove that as well. Please refer : IGBF-2519 Question: Did you pull the latest changes? (Merge the lastest master(lorainelab) with your branch ?) cc. Dr. Ann Loraine
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            Sameer Shanbhag : I have not pulled the latest changes. I see there will be a conflict if I pull the changes now. Please go ahead and submit a pull request for your ticket and I will resolve all the merge conflicts caused by both the tickets from my side before submitting a pull request for this ticket.
            cc. Ann Loraine

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Sameer Shanbhag : I have not pulled the latest changes. I see there will be a conflict if I pull the changes now. Please go ahead and submit a pull request for your ticket and I will resolve all the merge conflicts caused by both the tickets from my side before submitting a pull request for this ticket. cc. Ann Loraine
            Hide
            noor91zahara Noor Zahara added a comment -

            Everything seems to be working fine. But I wasn't able to check the apache log files/ django log files. Would need access to the server.

            Show
            noor91zahara Noor Zahara added a comment - Everything seems to be working fine. But I wasn't able to check the apache log files/ django log files. Would need access to the server.
            Hide
            aloraine Ann Loraine added a comment -

            Sorry for the inconvenience Noor Zahara.
            Please see your email for info on how to log onto the server.

            Show
            aloraine Ann Loraine added a comment - Sorry for the inconvenience Noor Zahara . Please see your email for info on how to log onto the server.
            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Pull Request: https://bitbucket.org/lorainelab/appstore/pull-requests/218/igbf-2517-move-template-files-into-a
            Hide
            aloraine Ann Loraine added a comment -

            Merged,

            Show
            aloraine Ann Loraine added a comment - Merged,

              People

              • Assignee:
                chirag24 Chirag Chandrahas Shetty
                Reporter:
                chirag24 Chirag Chandrahas Shetty
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: