Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:2.5
-
Epic Link:
-
Sprint:Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23
Description
Django looks for the template as the apps are installed. So if we have same name template in multiple applications then django will not be able to identify the correct template for that particular application. Therefore moving the templates into a subdirectory named for the application itself would be the easiest way to tell Django which template is the right one.
For more details please refer Template namespacing from the following link: https://docs.djangoproject.com/en/2.1/intro/tutorial03/
Folder structure example:
-submit_app
---templates
--------submit_app
------------confirm.html
------------error.html
------------submit_done.html
Attachments
Issue Links
- relates to
-
IGBF-2491 Fix "Something is wrong" page in App Store
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Sprint | Summer 6: 17 Aug - 28 Aug [ 101 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Description |
Django looks for the template as the apps are installed. So if we have same name template in multiple applications then django will not be able to identify the correct template for that particular application. Therefore moving the templates into a subdirectory named for the application itself would be the easiest way to tell Django which template is the right one.
For more details please refer Template namespacing from the following link: https://docs.djangoproject.com/en/2.1/intro/tutorial03/ Example: -submit_app -templates -submit_app -confirm.html -error.html -submit_done.html |
Django looks for the template as the apps are installed. So if we have same name template in multiple applications then django will not be able to identify the correct template for that particular application. Therefore moving the templates into a subdirectory named for the application itself would be the easiest way to tell Django which template is the right one.
For more details please refer Template namespacing from the following link: https://docs.djangoproject.com/en/2.1/intro/tutorial03/ Folder structure example: -submit_app ---templates --------submit_app ------------confirm.html ------------error.html ------------submit_done.html |
| Story Points | 2.5 |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Sprint | Summer 6: 17 Aug - 28 Aug [ 101 ] | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 101, 102 ] |
| Rank | Ranked higher |
link for testing: http://devappstore1.bioviz.org/
admin credentials- username: admin
password: qwerty@123
Testing steps:
Can you log in?
Can you log in as an "admin" user? Visit https://devappstore1.bioviz.org/admin/ to log in.
Can you submit an App?
Do both the admin and the submitter get an email when an App is submitted?
Can you approve an App (as an admin user)? (Log in as an admin user and click account name on the top right.)
Can you log in as submitting user and edit the Web page for an App after it's been approved?
Can you install an App in IGB?
Try to submit a same application twice and check if app store shows an error message.
Are any error messages printed to the apache log files? (See: /var/logs/apache2)
Are any error messages printed to the Django log files? (See: appstore/debug.log)
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Chirag Chandrahas Shetty : There are references to the wall of apps in your code. We need to remove that as well. Please refer : IGBF-2519
Question: Did you pull the latest changes? (Merge the lastest master(lorainelab) with your branch ?)
cc. Dr. [~aloraine]
Sameer Shanbhag : I have not pulled the latest changes. I see there will be a conflict if I pull the changes now. Please go ahead and submit a pull request for your ticket and I will resolve all the merge conflicts caused by both the tickets from my side before submitting a pull request for this ticket.
cc. [~aloraine]
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Everything seems to be working fine. But I wasn't able to check the apache log files/ django log files. Would need access to the server.
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Sorry for the inconvenience Noor Zahara.
Please see your email for info on how to log onto the server.
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Merged,
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep [ 101, 102 ] | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 101, 102, 103 ] |
| Rank | Ranked higher |
| Sprint | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep [ 101, 102, 103 ] | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct [ 101, 102, 103, 104 ] |
| Rank | Ranked higher |
| Sprint | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct [ 101, 102, 103, 104 ] | Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23 [ 101, 102, 103, 104, 106 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Chirag Chandrahas Shetty [ chirag24 ] |
Quick request for Chirag Chandrahas Shetty: Please add story points (estimate the time/effort required to implement and test the improvement.)
(Feel free to un-assign this when done.)