Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2655

Implement central Navigation Bar for Appstore from Bioviz

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23

      Description

      Find a way to get the latest navigation bar from the given release/feature branch of BioViz

        Attachments

          Issue Links

            Activity

            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            Hi Professor Ann Loraine,

            As discussed I have submitted the following pull request for App store:

            Pull Request for Bioviz:

            Please let me know if this looks good to you.

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - Hi Professor Ann Loraine , As discussed I have submitted the following pull request for App store: https://bitbucket.org/lorainelab/appstore/pull-requests/225/igbf-2655-implementing-centralized-navbar Pull Request for Bioviz: https://bitbucket.org/lorainelab/bioviz/pull-requests/50/igbf-2655 Please let me know if this looks good to you.
            Hide
            aloraine Ann Loraine added a comment - - edited

            App Store PR is merged. Requested (via comment) on the bioviz PR to avoid hard-coding the full URL in the menu, e.g., please continue to use "index.html" instead of "https://www.bioviz.org/index.html"

            Maybe what can happen is that when the menu-related files are retrieved from the bioviz repository during App Store start-up, some code can replace the non-absolute URLs with absolute ones. This also means that the App Store configuration will need to know not just the repository and branch of the BioViz site, it will also need to know the BioViz site's URL, e.g., "bioviz.org" or "test.bioviz.org" or whatever it is. I do not think this is a problem ... it's just a matter of adding an additional configuration.

            Last but not least, App Store will need get updated to use a new menu HTML file when the HTML file gets updated in the bioviz git repository. This menu file does change relatively frequently as we add new content.

            Show
            aloraine Ann Loraine added a comment - - edited App Store PR is merged. Requested (via comment) on the bioviz PR to avoid hard-coding the full URL in the menu, e.g., please continue to use "index.html" instead of "https://www.bioviz.org/index.html" Maybe what can happen is that when the menu-related files are retrieved from the bioviz repository during App Store start-up, some code can replace the non-absolute URLs with absolute ones. This also means that the App Store configuration will need to know not just the repository and branch of the BioViz site, it will also need to know the BioViz site's URL, e.g., "bioviz.org" or "test.bioviz.org" or whatever it is. I do not think this is a problem ... it's just a matter of adding an additional configuration. Last but not least, App Store will need get updated to use a new menu HTML file when the HTML file gets updated in the bioviz git repository. This menu file does change relatively frequently as we add new content.
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment -

            Hi Professor Ann Loraine

            I have added support to change the link to bioviz website on the Appstore part of the program, i have raised a pull request:

            Reverted all the changes to the menu.html on bioviz part of code:

            As far as the last question is concerned:

            • If we update the bioviz master branch and want it to be updated on the appstore we might just need to restart the appstore
            • if we have some other branch configured on appstore then we might need to change that in settings.ini file and then restart the appstore
            • No redeployment needed for the changes to take affect
            Show
            sameer Sameer Shanbhag (Inactive) added a comment - Hi Professor Ann Loraine I have added support to change the link to bioviz website on the Appstore part of the program, i have raised a pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/226/igbf-2655-adding-a-support-for-us-to-alter Reverted all the changes to the menu.html on bioviz part of code: https://bitbucket.org/lorainelab/bioviz/pull-requests/51/igbf-2655 As far as the last question is concerned: If we update the bioviz master branch and want it to be updated on the appstore we might just need to restart the appstore if we have some other branch configured on appstore then we might need to change that in settings.ini file and then restart the appstore No redeployment needed for the changes to take affect
            Hide
            aloraine Ann Loraine added a comment -

            Ok - this fine.

            Show
            aloraine Ann Loraine added a comment - Ok - this fine.
            Hide
            chirag24 Chirag Chandrahas Shetty added a comment -

            Looks good. Closing the ticket.

            Show
            chirag24 Chirag Chandrahas Shetty added a comment - Looks good. Closing the ticket.

              People

              • Assignee:
                sameer Sameer Shanbhag (Inactive)
                Reporter:
                sameer Sameer Shanbhag (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: