Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2655

Implement central Navigation Bar for Appstore from Bioviz

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          2
        • Epic Link:
        • Sprint:
          Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23

          Description

          Find a way to get the latest navigation bar from the given release/feature branch of BioViz

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-2670 Configure top menu bar app store link

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-3167 Update appstore prod ec2 to use new menu.html and menu.css files

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                sameer Sameer Shanbhag (Inactive) created issue -
                sameer Sameer Shanbhag (Inactive) made changes -
                Field Original Value New Value
                Epic Link IGBF-2563 [ 18746 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status To-Do [ 10305 ] In Progress [ 3 ]
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Hi Professor [~aloraine],

                As discussed I have submitted the following pull request for App store:

                Pull Request for Bioviz:

                Please let me know if this looks good to you.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Hi Professor [~aloraine] , As discussed I have submitted the following pull request for App store: https://bitbucket.org/lorainelab/appstore/pull-requests/225/igbf-2655-implementing-centralized-navbar Pull Request for Bioviz: https://bitbucket.org/lorainelab/bioviz/pull-requests/50/igbf-2655 Please let me know if this looks good to you.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                App Store PR is merged. Requested (via comment) on the bioviz PR to avoid hard-coding the full URL in the menu, e.g., please continue to use "index.html" instead of "https://www.bioviz.org/index.html"

                Maybe what can happen is that when the menu-related files are retrieved from the bioviz repository during App Store start-up, some code can replace the non-absolute URLs with absolute ones. This also means that the App Store configuration will need to know not just the repository and branch of the BioViz site, it will also need to know the BioViz site's URL, e.g., "bioviz.org" or "test.bioviz.org" or whatever it is. I do not think this is a problem ... it's just a matter of adding an additional configuration.

                Last but not least, App Store will need get updated to use a new menu HTML file when the HTML file gets updated in the bioviz git repository. This menu file does change relatively frequently as we add new content.

                Show
                ann.loraine Ann Loraine added a comment - - edited App Store PR is merged. Requested (via comment) on the bioviz PR to avoid hard-coding the full URL in the menu, e.g., please continue to use "index.html" instead of "https://www.bioviz.org/index.html" Maybe what can happen is that when the menu-related files are retrieved from the bioviz repository during App Store start-up, some code can replace the non-absolute URLs with absolute ones. This also means that the App Store configuration will need to know not just the repository and branch of the BioViz site, it will also need to know the BioViz site's URL, e.g., "bioviz.org" or "test.bioviz.org" or whatever it is. I do not think this is a problem ... it's just a matter of adding an additional configuration. Last but not least, App Store will need get updated to use a new menu HTML file when the HTML file gets updated in the bioviz git repository. This menu file does change relatively frequently as we add new content.
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Hi Professor [~aloraine]

                I have added support to change the link to bioviz website on the Appstore part of the program, i have raised a pull request:

                Reverted all the changes to the menu.html on bioviz part of code:

                As far as the last question is concerned:

                • If we update the bioviz master branch and want it to be updated on the appstore we might just need to restart the appstore
                • if we have some other branch configured on appstore then we might need to change that in settings.ini file and then restart the appstore
                • No redeployment needed for the changes to take affect
                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Hi Professor [~aloraine] I have added support to change the link to bioviz website on the Appstore part of the program, i have raised a pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/226/igbf-2655-adding-a-support-for-us-to-alter Reverted all the changes to the menu.html on bioviz part of code: https://bitbucket.org/lorainelab/bioviz/pull-requests/51/igbf-2655 As far as the last question is concerned: If we update the bioviz master branch and want it to be updated on the appstore we might just need to restart the appstore if we have some other branch configured on appstore then we might need to change that in settings.ini file and then restart the appstore No redeployment needed for the changes to take affect
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Ok - this fine.

                Show
                ann.loraine Ann Loraine added a comment - Ok - this fine.
                sameer Sameer Shanbhag (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
                sameer Sameer Shanbhag (Inactive) made changes -
                Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
                ann.loraine Ann Loraine made changes -
                Sprint Fall 5 Nov 9 - Nov 20 [ 108 ] Fall 5 Nov 9 - Nov 20, Fall 6 Nov 23 - Dec 4 [ 108, 109 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                sameer Sameer Shanbhag (Inactive) made changes -
                Assignee Sameer Shanbhag [ sameer ]
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-2670 [ IGBF-2670 ]
                ann.loraine Ann Loraine made changes -
                Sprint Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11 [ 108, 109 ] Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23 [ 108, 109, 110 ]
                ann.loraine Ann Loraine made changes -
                Rank Ranked higher
                chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
                Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
                chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
                Assignee Chirag Chandrahas Shetty [ chirag24 ]
                Hide
                Permalink
                chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

                Looks good. Closing the ticket.

                Show
                chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Looks good. Closing the ticket.
                chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
                Resolution Done [ 10000 ]
                Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
                chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
                Assignee Chirag Chandrahas Shetty [ chirag24 ]
                chirag24 Chirag Chandrahas Shetty (Inactive) made changes -
                Assignee Sameer Shanbhag [ sameer ]
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-3167 [ IGBF-3167 ]

                  People

                  • Assignee:
                    sameer Sameer Shanbhag (Inactive)
                    Reporter:
                    sameer Sameer Shanbhag (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: