Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2676

Preserve case in curated categories

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Capitalization of curated categories defined in curated_categories/apps.py is not being shown properly on the home page.

      For example, "RNA-Seq" is listed as "Rna-seq".

      The curated categories should be reported as defined in curated_categories/apps.py.

        Attachments

          Issue Links

            Activity

            Hide
            ssegu Sai Supreeth Segu added a comment -

            Dr. Ann Loraine and Sameer Shanbhag, I have made changes and it's working as expected.
            Please review my changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2676#diff

            Show
            ssegu Sai Supreeth Segu added a comment - Dr. Ann Loraine and Sameer Shanbhag , I have made changes and it's working as expected. Please review my changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2676#diff
            Hide
            aloraine Ann Loraine added a comment -

            Question:

            I noticed that in the code, locations where space characters should be instead have underscores. Sameer Shanbhag - was this required? (I'm assuming yes.)

            Regardless, we should not be showing underscores. I just wanted to check: will this change cause underscores to appear within a curated category?

            Show
            aloraine Ann Loraine added a comment - Question: I noticed that in the code, locations where space characters should be instead have underscores. Sameer Shanbhag - was this required? (I'm assuming yes.) Regardless, we should not be showing underscores. I just wanted to check: will this change cause underscores to appear within a curated category?
            Hide
            sameer Sameer Shanbhag (Inactive) added a comment - - edited

            Hi Professor Ann Loraine

            I just noticed that we are showing _ in the edit page while tagging a App with a particular category. That is a small detail which was missed (can be changed to not show _ on the front end), in the backend, yes we need _ character for spaces because it breaks some hyperlinks for space.

            Can we create a ticket to check what breaks when we do spaces instead of _. I remember adding that as there was something that broke because of the space.

            Sai Supreeth Segu : This ticket needs more work as with your change the subcategories will start having _ in them, titlemodified is a template filter which removes _ from the string.

            Show
            sameer Sameer Shanbhag (Inactive) added a comment - - edited Hi Professor Ann Loraine I just noticed that we are showing _ in the edit page while tagging a App with a particular category. That is a small detail which was missed (can be changed to not show _ on the front end), in the backend, yes we need _ character for spaces because it breaks some hyperlinks for space. Can we create a ticket to check what breaks when we do spaces instead of _. I remember adding that as there was something that broke because of the space. Sai Supreeth Segu : This ticket needs more work as with your change the subcategories will start having _ in them, titlemodified is a template filter which removes _ from the string.
            Hide
            aloraine Ann Loraine added a comment -

            Please submit a PR.

            Show
            aloraine Ann Loraine added a comment - Please submit a PR.
            Show
            ssegu Sai Supreeth Segu added a comment - Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/233/igbf-2676-preserve-case-in-curated
            Hide
            aloraine Ann Loraine added a comment -

            Merged but not yet deployed to testing site.

            Show
            aloraine Ann Loraine added a comment - Merged but not yet deployed to testing site.
            Hide
            aloraine Ann Loraine added a comment -

            Merged and deployed to testing site.

            Show
            aloraine Ann Loraine added a comment - Merged and deployed to testing site.
            Hide
            aloraine Ann Loraine added a comment -

            Curated categories are being shown properly in the interface. Moving to Closed.

            Show
            aloraine Ann Loraine added a comment - Curated categories are being shown properly in the interface. Moving to Closed.

              People

              • Assignee:
                ssegu Sai Supreeth Segu
                Reporter:
                aloraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: