Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2676

Preserve case in curated categories

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:

          Description

          Capitalization of curated categories defined in curated_categories/apps.py is not being shown properly on the home page.

          For example, "RNA-Seq" is listed as "Rna-seq".

          The curated categories should be reported as defined in curated_categories/apps.py.

            Attachments

              Issue Links

              relates to

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-2687 Remove underscores from categories and test

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                ann.loraine Ann Loraine created issue -
                ann.loraine Ann Loraine made changes -
                Field Original Value New Value
                Epic Link IGBF-2563 [ 18746 ]
                ann.loraine Ann Loraine made changes -
                Labels Beginner
                ann.loraine Ann Loraine made changes -
                Story Points 0.25 0.5
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status To-Do [ 10305 ] In Progress [ 3 ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Assignee Sai Supreeth Segu [ ssegu ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status In Progress [ 3 ] To-Do [ 10305 ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status To-Do [ 10305 ] In Progress [ 3 ]
                Hide
                Permalink
                ssegu Sai Supreeth Segu (Inactive) added a comment -

                Dr. [~aloraine] and Sameer Shanbhag, I have made changes and it's working as expected.
                Please review my changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2676#diff

                Show
                ssegu Sai Supreeth Segu (Inactive) added a comment - Dr. [~aloraine] and Sameer Shanbhag , I have made changes and it's working as expected. Please review my changes: https://bitbucket.org/supreeth27/appstore/branch/IGBF-2676#diff
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Assignee Sai Supreeth Segu [ ssegu ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Question:

                I noticed that in the code, locations where space characters should be instead have underscores. Sameer Shanbhag - was this required? (I'm assuming yes.)

                Regardless, we should not be showing underscores. I just wanted to check: will this change cause underscores to appear within a curated category?

                Show
                ann.loraine Ann Loraine added a comment - Question: I noticed that in the code, locations where space characters should be instead have underscores. Sameer Shanbhag - was this required? (I'm assuming yes.) Regardless, we should not be showing underscores. I just wanted to check: will this change cause underscores to appear within a curated category?
                ann.loraine Ann Loraine made changes -
                Assignee Sai Supreeth Segu [ ssegu ]
                ann.loraine Ann Loraine made changes -
                Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
                ann.loraine Ann Loraine made changes -
                Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment - - edited

                Hi Professor [~aloraine]

                I just noticed that we are showing _ in the edit page while tagging a App with a particular category. That is a small detail which was missed (can be changed to not show _ on the front end), in the backend, yes we need _ character for spaces because it breaks some hyperlinks for space.

                Can we create a ticket to check what breaks when we do spaces instead of _. I remember adding that as there was something that broke because of the space.

                Sai Supreeth Segu : This ticket needs more work as with your change the subcategories will start having _ in them, titlemodified is a template filter which removes _ from the string.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - - edited Hi Professor [~aloraine] I just noticed that we are showing _ in the edit page while tagging a App with a particular category. That is a small detail which was missed (can be changed to not show _ on the front end), in the backend, yes we need _ character for spaces because it breaks some hyperlinks for space. Can we create a ticket to check what breaks when we do spaces instead of _. I remember adding that as there was something that broke because of the space. Sai Supreeth Segu : This ticket needs more work as with your change the subcategories will start having _ in them, titlemodified is a template filter which removes _ from the string.
                ann.loraine Ann Loraine made changes -
                Link This issue relates to IGBF-2687 [ IGBF-2687 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Please submit a PR.

                Show
                ann.loraine Ann Loraine added a comment - Please submit a PR.
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status To-Do [ 10305 ] In Progress [ 3 ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
                Hide
                Permalink
                ssegu Sai Supreeth Segu (Inactive) added a comment -

                Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/233/igbf-2676-preserve-case-in-curated

                Show
                ssegu Sai Supreeth Segu (Inactive) added a comment - Please review my pull request: https://bitbucket.org/lorainelab/appstore/pull-requests/233/igbf-2676-preserve-case-in-curated
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                ssegu Sai Supreeth Segu (Inactive) made changes -
                Assignee Sai Supreeth Segu [ ssegu ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged but not yet deployed to testing site.

                Show
                ann.loraine Ann Loraine added a comment - Merged but not yet deployed to testing site.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged and deployed to testing site.

                Show
                ann.loraine Ann Loraine added a comment - Merged and deployed to testing site.
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
                ann.loraine Ann Loraine made changes -
                Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Curated categories are being shown properly in the interface. Moving to Closed.

                Show
                ann.loraine Ann Loraine added a comment - Curated categories are being shown properly in the interface. Moving to Closed.
                ann.loraine Ann Loraine made changes -
                Assignee Sai Supreeth Segu [ ssegu ]
                ann.loraine Ann Loraine made changes -
                Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
                ann.loraine Ann Loraine made changes -
                Resolution Done [ 10000 ]
                Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

                  People

                  • Assignee:
                    ssegu Sai Supreeth Segu (Inactive)
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: