Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      View in IGB does not work for Community files

        Attachments

          Activity

          Show
          nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/223/igbf-2707-fix-view-in-igb-for-all-sections
          Show
          nfreese Nowlan Freese added a comment - - edited Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/224/igbf-2707-fix-permission-check-issue
          Show
          nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/225/igbf-2707-remove-view-in-igb-color-changes
          Hide
          karthik Karthik Raveendran added a comment -

          Three issues were fixed in this ticket:
          Fix Permission check issue: Cyverse file/folder ownership/permissions error messages for different sections needed to be handled accordingly and the logic for that was changed.
          https://bitbucket.org/nfreese/django-cyversedev/commits/fc2494ac4dc07aa30a1d44028490d762c5a02baa

          Fix View in IGB for all Sections: Logic for checking ownership/permissions and handling messages had issues in the front-end once the page was reloaded. The Logic was changed and the code was optimized.
          https://bitbucket.org/nfreese/django-cyversedev/commits/c76f038bffe29d5705df0edc9d08de77936f81e1

          Remove View in IGB color changes: button color changed according to the ownership and permission which could be confusing to the user and was removed
          https://bitbucket.org/nfreese/django-cyversedev/commits/d84d0204e31d23f7c605c61795ece5bf73842ea7

          Show
          karthik Karthik Raveendran added a comment - Three issues were fixed in this ticket: Fix Permission check issue: Cyverse file/folder ownership/permissions error messages for different sections needed to be handled accordingly and the logic for that was changed. https://bitbucket.org/nfreese/django-cyversedev/commits/fc2494ac4dc07aa30a1d44028490d762c5a02baa Fix View in IGB for all Sections: Logic for checking ownership/permissions and handling messages had issues in the front-end once the page was reloaded. The Logic was changed and the code was optimized. https://bitbucket.org/nfreese/django-cyversedev/commits/c76f038bffe29d5705df0edc9d08de77936f81e1 Remove View in IGB color changes: button color changed according to the ownership and permission which could be confusing to the user and was removed https://bitbucket.org/nfreese/django-cyversedev/commits/d84d0204e31d23f7c605c61795ece5bf73842ea7
          Hide
          nfreese Nowlan Freese added a comment -

          Public Community files View in IGB is working (primary issue). There are some console.log that have been commented out in cyverse.js. Karthik Raveendran should these be removed?

          Tested Owned/Shared/Community files all worked when View in IGB.

          View in IGB color change when switching a file public/private is still occurring. However, as this was a minor issue not directly related to this ticket, I see no reason not to close the ticket.

          As the primary ticket issue (Community View in IGB error) has been fixed, closing issue.

          Show
          nfreese Nowlan Freese added a comment - Public Community files View in IGB is working (primary issue). There are some console.log that have been commented out in cyverse.js. Karthik Raveendran should these be removed? Tested Owned/Shared/Community files all worked when View in IGB. View in IGB color change when switching a file public/private is still occurring. However, as this was a minor issue not directly related to this ticket, I see no reason not to close the ticket. As the primary ticket issue (Community View in IGB error) has been fixed, closing issue.

            People

            • Assignee:
              karthik Karthik Raveendran
              Reporter:
              karthik Karthik Raveendran
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: