Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2707

Fix Community View in IGB error

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          View in IGB does not work for Community files

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              karthik Karthik Raveendran created issue -
              karthik Karthik Raveendran made changes -
              Field Original Value New Value
              Epic Link IGBF-2376 [ 18533 ]
              karthik Karthik Raveendran made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/223/igbf-2707-fix-view-in-igb-for-all-sections

              Show
              nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/223/igbf-2707-fix-view-in-igb-for-all-sections
              Hide
              Permalink
              nfreese Nowlan Freese added a comment - - edited

              Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/224/igbf-2707-fix-permission-check-issue

              Show
              nfreese Nowlan Freese added a comment - - edited Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/224/igbf-2707-fix-permission-check-issue
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/225/igbf-2707-remove-view-in-igb-color-changes

              Show
              nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/225/igbf-2707-remove-view-in-igb-color-changes
              ann.loraine Ann Loraine made changes -
              Sprint Fall 7 Dec 14 - Dec 23 [ 110 ] Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8 [ 110, 111 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              karthik Karthik Raveendran made changes -
              Status In Progress [ 3 ] To-Do [ 10305 ]
              karthik Karthik Raveendran made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              Hide
              Permalink
              karthik Karthik Raveendran added a comment -

              Three issues were fixed in this ticket:
              Fix Permission check issue: Cyverse file/folder ownership/permissions error messages for different sections needed to be handled accordingly and the logic for that was changed.
              https://bitbucket.org/nfreese/django-cyversedev/commits/fc2494ac4dc07aa30a1d44028490d762c5a02baa

              Fix View in IGB for all Sections: Logic for checking ownership/permissions and handling messages had issues in the front-end once the page was reloaded. The Logic was changed and the code was optimized.
              https://bitbucket.org/nfreese/django-cyversedev/commits/c76f038bffe29d5705df0edc9d08de77936f81e1

              Remove View in IGB color changes: button color changed according to the ownership and permission which could be confusing to the user and was removed
              https://bitbucket.org/nfreese/django-cyversedev/commits/d84d0204e31d23f7c605c61795ece5bf73842ea7

              Show
              karthik Karthik Raveendran added a comment - Three issues were fixed in this ticket: Fix Permission check issue: Cyverse file/folder ownership/permissions error messages for different sections needed to be handled accordingly and the logic for that was changed. https://bitbucket.org/nfreese/django-cyversedev/commits/fc2494ac4dc07aa30a1d44028490d762c5a02baa Fix View in IGB for all Sections: Logic for checking ownership/permissions and handling messages had issues in the front-end once the page was reloaded. The Logic was changed and the code was optimized. https://bitbucket.org/nfreese/django-cyversedev/commits/c76f038bffe29d5705df0edc9d08de77936f81e1 Remove View in IGB color changes: button color changed according to the ownership and permission which could be confusing to the user and was removed https://bitbucket.org/nfreese/django-cyversedev/commits/d84d0204e31d23f7c605c61795ece5bf73842ea7
              karthik Karthik Raveendran made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              karthik Karthik Raveendran made changes -
              Assignee Karthik Raveendran [ karthik ]
              nfreese Nowlan Freese made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              nfreese Nowlan Freese made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              nfreese Nowlan Freese made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              nfreese Nowlan Freese made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              nfreese Nowlan Freese made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              ann.loraine Ann Loraine made changes -
              Sprint Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8 [ 110, 111 ] Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22 [ 110, 111, 112 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              nfreese Nowlan Freese made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              nfreese Nowlan Freese made changes -
              Assignee Nowlan Freese [ nfreese ]
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Public Community files View in IGB is working (primary issue). There are some console.log that have been commented out in cyverse.js. Karthik Raveendran should these be removed?

              Tested Owned/Shared/Community files all worked when View in IGB.

              View in IGB color change when switching a file public/private is still occurring. However, as this was a minor issue not directly related to this ticket, I see no reason not to close the ticket.

              As the primary ticket issue (Community View in IGB error) has been fixed, closing issue.

              Show
              nfreese Nowlan Freese added a comment - Public Community files View in IGB is working (primary issue). There are some console.log that have been commented out in cyverse.js. Karthik Raveendran should these be removed? Tested Owned/Shared/Community files all worked when View in IGB. View in IGB color change when switching a file public/private is still occurring. However, as this was a minor issue not directly related to this ticket, I see no reason not to close the ticket. As the primary ticket issue (Community View in IGB error) has been fixed, closing issue.
              nfreese Nowlan Freese made changes -
              Assignee Nowlan Freese [ nfreese ] Karthik Raveendran [ karthik ]
              nfreese Nowlan Freese made changes -
              Resolution Done [ 10000 ]
              Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

                People

                • Assignee:
                  karthik Karthik Raveendran
                  Reporter:
                  karthik Karthik Raveendran
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: