Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2729

Investigate: Top menu bar style fixes for BioViz sites

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      The "install IGB" button on BioViz sites is not vertically centered - there is more space above the button than below it. This looks a bit weird and unbalanced. Can this be fixed to ensure that there is the same amount of space above and below it?

      Another issue has to do with responsiveness and spacing of menu items.

      No matter the width of the page, there is always a weirdly large empty area between the "install IGB" button and the "Bioviz Connect" link. If you reduce the width of the browser window, the menu items disappear before this empty space gets used up. There seems to be something weird about how responsiveness is working.

      Can this be fixed to look and feel less awkward to the user?

        Attachments

          Activity

          Hide
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

          [~aloraine] We fixed the issue in bioviz repo since AppStore gets the CSS file from there(Commit hash: 62aecff). I can see the changes in devappstore3. If you feel the button spacing looks unbalanced, then please let me know.

          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - [~aloraine] We fixed the issue in bioviz repo since AppStore gets the CSS file from there(Commit hash: 62aecff). I can see the changes in devappstore3. If you feel the button spacing looks unbalanced, then please let me know.
          Hide
          ann.loraine Ann Loraine added a comment -

          Coud you check with Supreeth on this? I think there was a problem with the change and we needed to revert it.
          Sorry for the confusion! Chirag Chandrahas Shetty

          Show
          ann.loraine Ann Loraine added a comment - Coud you check with Supreeth on this? I think there was a problem with the change and we needed to revert it. Sorry for the confusion! Chirag Chandrahas Shetty
          Hide
          ssegu Sai Supreeth Segu (Inactive) added a comment -

          With this change there is an issue in Safari browser. Please review IGBF-2674 for the screenshots and the comments.
          cc: Chirag Chandrahas Shetty

          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - With this change there is an issue in Safari browser. Please review IGBF-2674 for the screenshots and the comments. cc: Chirag Chandrahas Shetty
          Hide
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment -

          Sai Supreeth Segu I checked the comment logs. So there were in total 3 pull requests submitted. The first two pull requests are doing the same thing but were submitted to different repos:
          1) bioviz repo: 760e95c
          2) appstore repo: 96f9a27

          In the above commits the height of the menubar was changed from 53px to auto and this was working in chrome and firefox but in safari height:auto does not work because of which it was covering the whole screen.

          Both the commits were reverted by Dr.[~aloraine] but I had submitted a third pull request to bioviz repo which Dr. Loraine merged into the master branch(commit hash: 62aecff). Since the appstore is getting the menu.css file from bioviz repo we can see the changes in our current testing deployments(devappstore3 and devappstore5).

          Please check the commit history of bioviz repo.

          Show
          chirag24 Chirag Chandrahas Shetty (Inactive) added a comment - Sai Supreeth Segu I checked the comment logs. So there were in total 3 pull requests submitted. The first two pull requests are doing the same thing but were submitted to different repos: 1) bioviz repo: 760e95c 2) appstore repo: 96f9a27 In the above commits the height of the menubar was changed from 53px to auto and this was working in chrome and firefox but in safari height:auto does not work because of which it was covering the whole screen. Both the commits were reverted by Dr. [~aloraine] but I had submitted a third pull request to bioviz repo which Dr. Loraine merged into the master branch(commit hash: 62aecff). Since the appstore is getting the menu.css file from bioviz repo we can see the changes in our current testing deployments(devappstore3 and devappstore5). Please check the commit history of bioviz repo.
          Hide
          ssegu Sai Supreeth Segu (Inactive) added a comment -

          Chirag Chandrahas Shetty I have checked the logs of appstore. There was a new commit(hash: 62aecff) that was merged after reverting the previous changes. The new commit is working fine in Safari browser as well.
          cc: Dr.[~aloraine]

          Show
          ssegu Sai Supreeth Segu (Inactive) added a comment - Chirag Chandrahas Shetty I have checked the logs of appstore. There was a new commit(hash: 62aecff) that was merged after reverting the previous changes. The new commit is working fine in Safari browser as well. cc: Dr. [~aloraine]

            People

            • Assignee:
              Unassigned
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: