PR: https://bitbucket.org/lorainelab/appstore/pull-requests/261/igbf-2729-remove-fix-size-of-top-bar-for

I don't think this should be merged before IGBF-2723. This issue needs to be fixed in the original Repo rather than in Appstore

Sorry, I merged the PR too soon.

Chirag Chandrahas Shetty - could you look at fixing this in the bioviz code base as well?

[~aloraine] Sure, I will do that.

[~aloraine] and Sameer Shanbhag Created a pull request.
link: https://bitbucket.org/lorainelab/bioviz/pull-requests/54/igbf-2729-remove-fix-size-of-top-bar-in

Second PR to bioviz repo is now merged but not yet deployed on a testing site.

Please check the menu appearance on test.bioviz.org.

Look for the comment by Philip Badzuh in IGBF-2674 for the screenshot and issue in Safari.
Regarding the issue with bioviz menu bar, this issue persists in test.bioviz.org as well. So, I think the issue is due to the change made on IGBF-2729. We need to revert this commit for getting everything back to normal. Moving to to-do column
Attn: Chirag Chandrahas Shetty, Philip Badzuh and Dr. Ann Loraine

Reverted 760e95c and pushed to master branch.

Reverted code should now be properly deployed on https://test.bioviz.org and both devappstore3 and devappstore5.

Philip Badzuh and Sai Supreeth Segu - kindly check to see if the error noticed in Safari is now fixed.

Dr. [~aloraine], I just want to make sure whether the reverted code is deployed on https://test.bioviz.org. I can still see the same issue in https://test.bioviz.org, devappstore3 and devappstore5

[~aloraine] I have submitted a new PR with adjusted height. Tested the changes on chrome and Firefox but this should work on safari also.
PR: https://bitbucket.org/lorainelab/bioviz/pull-requests/55

Can you please log in to the devappstore sites to check the code base that is deployed.

Once you log in:

sudo su
cd appstore
git ls

to see the latest commit of the deployed code.

Merged and deployed to test.bioviz.org and both devappstores

Issue is resolved in test.bioviz.org but the issue persists in both devappstores.
Current master for devappstore3 points to commit d39180b
d39180b (HEAD -> master, origin/master, origin/HEAD) Merged in IGBF-2734 (pull request #264)
4e2957d Merged in IGBF-2719 (pull request #263)
d69ba0f IGBF-2734: Fix question mark buttons in error page.
b8544ca IGBF-2719: Fixing broken links
737a9a1 Merged lorainelab/appstore into master
3590659 Merged in IGBF-2684-2 (pull request #262)
8991e09 IGBF-2684: Updating name of CSS file
783772d Merged lorainelab/appstore into master
a78d2e2 Merged in IGBF-2729 (pull request #261)
690ea76 Merged in IGBF-2723 (pull request #260)
d9190ff Merged lorainelab/appstore:master into chirag06/appstore:IGBF-2729
96f9a27 IGBF-2729:Remove fix size of top bar for alignment of Install IGB button

Chester Dias and myself don't have access to turn on instances for devappstore3 and devappstore5. We both have tried and failed to start EC2 instances. Dr. [~aloraine] Please start EC2 instances for both devappstores.
cc: Sameer Shanbhag

I have started devappstore5. I dont have access to devappstore3. Please check.

Attn. Sai Supreeth Segu Chester Dias

Thanks Sameer Shanbhag

Apologies. There was a typo in the "Owner" tag for devappstore3. You should now have access to it.

This issue still persists in both devappstores due to this change. Dr. [~aloraine], Please revert this https://bitbucket.org/lorainelab/appstore/pull-requests/261/igbf-2729-remove-fix-size-of-top-bar-for commit. After reverting this commit everything should work back as normal in Safari browser.

Request for Sai Supreeth Segu: Please specific which commit hash needs to be reverted on appstore code base.

The commit hash: 96f9a27 and the description is : IGBF-2729:Remove fix size of top bar for alignment of Install IGB button.
cc: Dr. [~aloraine]

Reverted and revert-commit push to master.
Deployed to devappstore3 and 5.

Sai Supreeth Segu kindly test new deployment.

Dr. [~aloraine], Issue persists in devappstore5 and resolved in devappstore3.

I have investigated why the issue exists in devappstore5 and noticed that the code in commit hash: 96f9a27 still exists in devappstore5.
In devappstore3, the commit hash: 96f9a27 is reverted

Issued is fixed in devappstore5 as well

There does not appear to be a way to fix this as the previous attempt did not work. Moving to Closed.

[~aloraine] We fixed the issue in bioviz repo since AppStore gets the CSS file from there(Commit hash: 62aecff). I can see the changes in devappstore3. If you feel the button spacing looks unbalanced, then please let me know.

Coud you check with Supreeth on this? I think there was a problem with the change and we needed to revert it.
Sorry for the confusion! Chirag Chandrahas Shetty

With this change there is an issue in Safari browser. Please review IGBF-2674 for the screenshots and the comments.
cc: Chirag Chandrahas Shetty

Sai Supreeth Segu I checked the comment logs. So there were in total 3 pull requests submitted. The first two pull requests are doing the same thing but were submitted to different repos:
1) bioviz repo: 760e95c
2) appstore repo: 96f9a27

In the above commits the height of the menubar was changed from 53px to auto and this was working in chrome and firefox but in safari height:auto does not work because of which it was covering the whole screen.

Both the commits were reverted by Dr.[~aloraine] but I had submitted a third pull request to bioviz repo which Dr. Loraine merged into the master branch(commit hash: 62aecff). Since the appstore is getting the menu.css file from bioviz repo we can see the changes in our current testing deployments(devappstore3 and devappstore5).

Please check the commit history of bioviz repo.

Chirag Chandrahas Shetty I have checked the logs of appstore. There was a new commit(hash: 62aecff) that was merged after reverting the previous changes. The new commit is working fine in Safari browser as well.
cc: Dr.[~aloraine]