I was able to submit the Quickload app on my local environment successfully. But when I open the app instead of "Install the App" button, It's showing "Get IGB" whereas if I open another I can see "Install the App" button. I have added the App link in the IGB app but for some reason I was not able to see the Quickload app in appstore in 9.1.8 version.
cc: Dr. [~aloraine] and Noor Zahara

I have tried using both these links https://bitbucket.org/noorzahara/save_customegenome/downloads/ and https://bitbucket.org/noorzahara/save_customegenome/downloads/create_quickload-0.0.1.jar in App repositories section for installing the app in IGB app. Please let me know if I need to do anything other than this and let me know how to move forward?
cc: Dr. [~aloraine]

Sai Supreeth Segu - Add https://localhost:8000/obr/releases to App Repositories.

Yes, I have added localhost:8000/obr/releases/ as well in repositories
cc: Noor Zahara

Please provide detailed step-by-step description of exactly what you did, in which order, and which with versions and hosts.

Step 1: Submitted Quickload app in my local appstore environment.
Link for the app used: https://bitbucket.org/noorzahara/save_customegenome/downloads/create_quickload-0.0.1.jar
Step 2: Approved the Quickload app successfully and was able to open the app page of submitted Quickload app.
Step 3: Installed the Master branch of IGB repository and ran the IGB app.
Step 4: Added the https://bitbucket.org/noorzahara/save_customegenome/downloads/ in App repositories.
Step 5: Installed the App successfully in IGB 9.1.8.
Step 6: Cleared .igb in my local and reset the preferences in IGB 9.1.6-release. I have tried to install the app in older version.
Step7: I have installed the app in older version as well.

Initially I was unable to install the app and Noor Zahara have helped me to test this.
I was able to install the app in IGB 9.1.6-release as well.
cc: Dr. [~aloraine]

Chester Dias and Irvin Naylor - Can you please look into the problem that Sai Supreeth Segu has noticed?

Please:

• check that the "Quickload App" MANIFEST.MF and pom.xml files correctly indicate that only IGB 9.1.8 or higher can install the App
• check whether the IGB's internal App Manager window shows the Quickload App after adding the Downloads section from the App's bitbucket repository as a new App repository. The 9.1.6 IGB version should not show it. The IGB 9.1.8 IGB version should show it, however.
• check App Store behavior, as well. App Store is supposed to be smart enough to not let the user install incompatible apps.

Note that Noor has made changes to the IGB platform in order to support the functionality of the App. These changes were made to IGB 9.1.8 and are not present in IGB 9.1.6.

The ticket is now in "Needs First Level Review" but I don't see any notes on what was done. Probably this was moved into this column in error? Moving this back to "To-Do".

1. check that the "Quickload App" MANIFEST.MF and pom.xml files correctly indicate that only IGB 9.1.8 or higher can install the Ap

• In the pom.xml file I found that there were dependencies on version 9.1.6 through 9.1.8 but I didn't see anywhere that mentioned that only 9.1.8 could install. The Manifest.mf file of the jar file held a similar result, dependencies meant that any IGB over 9.1.x (even IGB 10.x.x as well from the looks of it) could work with this app.

2. check whether the IGB's internal App Manager window shows the Quickload App after adding the Downloads section from the App's bitbucket repository as a new App repository. The 9.1.6 IGB version should not show it. The IGB 9.1.8 IGB version should show it, however.

• Found that both IGB 9.1.6 and 9.1.8 were able to install the app with no problems and the app manager window showed the quickload app's information correctly for both versions.

3. check App Store behavior, as well. App Store is supposed to be smart enough to not let the user install incompatible apps.

• Tested with devappstore3, I found that the app's jar file was able to pass automated review. I wasn't sure if the review was to cover version differences but I found that if 9.1.6, 9.1.8, and presumably other versions were able to install, it would have gone through.

I've attached a picture of the manifest.mf file as well

Request:

Can you determine if the App is working correctly in 9.1.6 and also 9.1.8?
To check if it is working, review the IGB log tab.
The App should NOT work properly in 9.1.6 because we had to make some changes to IGB itself, and these were only made in 9.1.8 and not 9.1.6.

The app is now released on IGB App Store devappstore3.bioviz.org.

After looking at the manifest, I see a problem.
The pom.xml declares that the App is compatible with IGB version 9.1.6 and higher for some of the IGB artifacts, and declares IGB version 9.1.8 for the IgbServices bundle.
However, when we build IGB, all of the IGB bundles have the same version. We never build and release IGB with a mix of versions.
Also, I notice that the MANIFEST does not specify micro versions (the "8" in 9.1.8).
We may need to increment IGB version to 9.2, e.g., increment the minor version number, in order to trigger proper compatibility checks.

I just now attempted to run the Quickload App within IGB 9.1.6.
I was able to install the App into IGB.
However, when I tried to actually use it, I observed the following error:

Exception in thread "AWT-EventQueue-0" java.lang.NoSuchMethodError: org.lorainelab.igb.services.IgbService.getAnnotStyle(Ljava/lang/String;)Lcom/affymetrix/genometry/style/ITrackStyleExtended;
	at org.lorainelab.igb.menuoption.CreateQuickloadAction.createQuickload(CreateQuickloadAction.java:163)
	at org.lorainelab.igb.menuoption.CreateQuickloadAction.showFileDialog(CreateQuickloadAction.java:87)
	at org.lorainelab.igb.menuoption.CreateQuickloadAction.actionPerformed(CreateQuickloadAction.java:72)
	at org.lorainelab.igb.menuoption.CreateQuickloadAction.lambda$getMenuItems$0(CreateQuickloadAction.java:284)
	at org.lorainelab.igb.menu.api.util.MenuUtils$1.actionPerformed(MenuUtils.java:26)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
	at com.apple.laf.ScreenMenuItem.actionPerformed(ScreenMenuItem.java:125)
	at java.awt.MenuItem.processActionEvent(MenuItem.java:669)
	at java.awt.MenuItem.processEvent(MenuItem.java:628)
	at java.awt.MenuComponent.dispatchEventImpl(MenuComponent.java:357)
	at java.awt.MenuComponent.dispatchEvent(MenuComponent.java:345)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:763)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
	at java.awt.EventQueue$4.run(EventQueue.java:733)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

This occurs because the version of IgbServices that is packaged with IGB 9.1.6 lacks a method (getAnnotStyle) needed by the app for its proper function. To run this App, you must use IGB 9.1.8.

This leaves me with some questions:

• Why did the maven bundle plugin fail to properly indicate the version of IgbServices needed by the App when it built the MANIFEST file that was packaged with the jar?

Are dependencies declared only at the level of the minor version and not the micro version?

Irvin Naylor - please read the above comments.

[~aloraine] - I see now. I was thinking about that as well, it seemed as if the pom.xml and the manifest file weren't on the same page regarding what versions are required. That might have been the reason why the app store allowed it since I noticed it also said that it was compatible with 9.1.x and 10, just like in the manifest.

I'm currently testing in 9.1.8 to see what happens when the app runs (since before I just tested to see if it showed up in the actual download manager.) but I'll poke around and see what else I can find

Looks like we need to modify the pom.xml as with here: https://bnd.bndtools.org/chapters/170-versioning.html

FAQ: Why does bnd use only major and minor version component in import-package headers?

The micro is left out because it generates a lot of unnecessary releases, this is similar to the maven release process. If you connect everything 100%, you cannot move anything unless all its dependencies are moved at the same time. We actually tried in the OSGi build to use micro version changes for default methods in Java 8 but found that it just creates an enormous ripple through effect in the build. Not depending on the micro version is a lubricant that does not kill any bundle out there that depends on you.

This should not be a problem because a micro version is a deployment issue since the semantic versioning should be used for APIs and a micro change is not visible in the API.

That said, this is bnd so obviously you can override it. You can override the default version policy is:

-provider-policy = ${range;[==,=+)}
-consumer-policy = ${range;[==,+)}
Just set ‘===’ instead of ‘==’ for the floor version in your pom.xml in the section and you should be ok.

<configuration>
	<_provider-policy>${range;[===,=+)}</_provider-policy>
	<_consumer-policy>${range;[===,+)}</_consumer-policy>
</configuration>

It looks to me like we can use "configuration" tags above to force the maven bundle plugin to specify micro versions.
I'm not sure it will work, but I'd like to give it a try, so I made a new ticket for it.
Do you want to give it a try?
attn: Irvin Naylor

[~aloraine] I see, that makes sense! And sure, I could give it a shot.

Before you get started, I need to make a LoraineLab fork of Noor's repository. Once I do that, you should "fork" from that fork, since Noor is no longer available for merging pull requests into her code. (She is now working at Amazon )