Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2747

Remove Variables from SubmitApp Codebase

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1.5
    • Sprint:
      Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22, Winter 3 Jan 25 - Feb 5, Winter 4 Feb 8 - Feb 19

      Description

      Currently Submit App has two variables which are causing some error looking warning in the log. These variables does not break anything but just creates a lot of error messages in log which can be demeaning.

      expect_app_name and is_pending_replace needs to be taken care of

        Attachments

          Activity

          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          Pull Request:

          Change Log:

          • Removed Expect App Name Variable

          P.S. This can be used as a reference if we plan on removing these variables later in the project

          C.C. Ann Loraine

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Pull Request: https://bitbucket.org/lorainelab/appstore/pull-requests/265/igbf-2747-remove-expect-app-name-from-the Change Log: Removed Expect App Name Variable P.S. This can be used as a reference if we plan on removing these variables later in the project C.C. Ann Loraine
          Hide
          aloraine Ann Loraine added a comment -

          deployed to devappstore3 and devappstore5

          Show
          aloraine Ann Loraine added a comment - deployed to devappstore3 and devappstore5
          Hide
          chirag24 Chirag Chandrahas Shetty added a comment -

          Still getting error msg in the logs.

          Traceback (most recent call last):
          File "/home/ubuntu/appstore/venv/lib/python3.6/site-packages/django/template/base.py", line 843, in _resolve_lookup
          current = current[int(bit)]
          ValueError: invalid literal for int() with base 10: 'info_msg'

          During handling of the above exception, another exception occurred:

          Traceback (most recent call last):
          File "/home/ubuntu/appstore/venv/lib/python3.6/site-packages/django/template/base.py", line 850, in _resolve_lookup
          (bit, current)) # missing attribute
          django.template.base.VariableDoesNotExist: Failed lookup for key [info_msg] in [

          {'True': True, 'False': False, 'None': None}

          , {'csrf_token': <SimpleLazyObject: <function csrf.<locals>._get_val at 0x7fa948a20d90>>, 'request': <WSGIRequest: POST '/submit_app/confirm/8'>, 'user': <SimpleLazyObject: <User: cshetty>>, 'perms': <django.contrib.auth.context_processors.PermWrapper object at 0x7fa9489deef0>, 'messages': <django.contrib.messages.storage.fallback.FallbackStorage object at 0x7fa9489dee48>, 'DEFAULT_MESSAGE_LEVELS':

          {'DEBUG': 10, 'INFO': 20, 'SUCCESS': 25, 'WARNING': 30, 'ERROR': 40}

          , 'backends': <LazyDict: <function backends.<locals>.<lambda> at 0x7fa949ac3400>>, 'REDIRECT_FIELD_NAME': 'next', 'REDIRECT_FIELD_VALUE': None, 'REDIRECT_QUERYSTRING': ''}, {},

          {'app_name': 'Show Splice Support'}

          ,

          {'block': <Block Node: error_pop. Contents: [<TextNode: '\n '>, <django.template.loader_tags.IncludeNode object at 0x7fa9489e20f0>, <TextNode: '\n '>]>}

          , {},

          {'block': <Block Node: error_pop. Contents: [<TextNode: '\n<div class="col-md-12" i'>, <IfNode>, <TextNode: '\n '>, <IfNode>, <TextNode: '\n</div>\n'>]>}

          ]

          Show
          chirag24 Chirag Chandrahas Shetty added a comment - Still getting error msg in the logs. Traceback (most recent call last): File "/home/ubuntu/appstore/venv/lib/python3.6/site-packages/django/template/base.py", line 843, in _resolve_lookup current = current [int(bit)] ValueError: invalid literal for int() with base 10: 'info_msg' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/ubuntu/appstore/venv/lib/python3.6/site-packages/django/template/base.py", line 850, in _resolve_lookup (bit, current)) # missing attribute django.template.base.VariableDoesNotExist: Failed lookup for key [info_msg] in [ {'True': True, 'False': False, 'None': None} , {'csrf_token': <SimpleLazyObject: <function csrf.<locals>._get_val at 0x7fa948a20d90>>, 'request': <WSGIRequest: POST '/submit_app/confirm/8'>, 'user': <SimpleLazyObject: <User: cshetty>>, 'perms': <django.contrib.auth.context_processors.PermWrapper object at 0x7fa9489deef0>, 'messages': <django.contrib.messages.storage.fallback.FallbackStorage object at 0x7fa9489dee48>, 'DEFAULT_MESSAGE_LEVELS': {'DEBUG': 10, 'INFO': 20, 'SUCCESS': 25, 'WARNING': 30, 'ERROR': 40} , 'backends': <LazyDict: <function backends.<locals>.<lambda> at 0x7fa949ac3400>>, 'REDIRECT_FIELD_NAME': 'next', 'REDIRECT_FIELD_VALUE': None, 'REDIRECT_QUERYSTRING': ''}, {}, {'app_name': 'Show Splice Support'} , {'block': <Block Node: error_pop. Contents: [<TextNode: '\n '>, <django.template.loader_tags.IncludeNode object at 0x7fa9489e20f0>, <TextNode: '\n '>]>} , {}, {'block': <Block Node: error_pop. Contents: [<TextNode: '\n<div class="col-md-12" i'>, <IfNode>, <TextNode: '\n '>, <IfNode>, <TextNode: '\n</div>\n'>]>} ]
          Hide
          aloraine Ann Loraine added a comment -

          Chirag Chandrahas Shetty - the above errors do not mention the missing variables. Does this confirm that Sameer's PR has corrected the specific problem with those variables?

          Please also inspect the code change itself.

          Show
          aloraine Ann Loraine added a comment - Chirag Chandrahas Shetty - the above errors do not mention the missing variables. Does this confirm that Sameer's PR has corrected the specific problem with those variables? Please also inspect the code change itself.
          Hide
          chirag24 Chirag Chandrahas Shetty added a comment -

          Ann Loraine Only one variable is removed from the code base ie: Expect App Name Variable. The code looks fine. I looked into the log files(debug.log and ) and couldn't find errors due to the two variables.

          Show
          chirag24 Chirag Chandrahas Shetty added a comment - Ann Loraine Only one variable is removed from the code base ie: Expect App Name Variable. The code looks fine. I looked into the log files(debug.log and ) and couldn't find errors due to the two variables.

            People

            • Assignee:
              sameer Sameer Shanbhag (Inactive)
              Reporter:
              sameer Sameer Shanbhag (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: