Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-277

Improve labeling for FindJunctions Track Operation settings

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      1
    • Sprint:
      Winter 2018 Sprint 3, Spring 2019 Sprint 1

      Description

      First noticed with in version 8.2.0:

      User story:

      The Find Junctions feature lets a user created so-called "junction features" in a new track using a BAM (alignments) track as input.
      To use the feature, a user:

      • loads a BAM track
      • right-clicks the BAM track's track label
      • selects Tracks Operations
      • selects Find Junctions or Find Junctions (Tophat)

      (These are just two different ways to calculate a junction feature).

      When the user selects a Find Junctions operation, a new window appears with settings for the operation. One of the setting is poorly labeled and likely does not make sense to a new user. This needs to be fixed. For "Find Junctions" the setting is called "flank" and for "Find Junctions (Tophat)" the setting is labeled "threshold". They have the same effect and the description should be the same.

      What they mean: This setting determines the minimum number of bases that need to align across a junction on either side in order for a split read to be used to create a junction feature. The fact that the track that is made has blocks that are the threshold size helps make this apparent, but it would be really good to have a tool tip, or optional info button or something to help the user figure out what the threshold option does.

      Task:

      • Investigate whether or not we can change this labeling, and how to do it. To be more informative, the label should read:
      • Add a comment making note of files and modules that would need to be edited.
      • Make the change as required, if feasible.

      "Enter minimum number of bases required to align on each side of the intron/junction:"

      Note: Consult with Dr. Freese if you have questions about how to proceed.

      Caution: All Track Operations are using the same UI code. Watch out!

        Attachments

          Activity

          Hide
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

          Following files and modules are modified to change the label in "findJunctions"
          File : FindJunctionOperator.java
          String Name : FLANK

          Following files and modules are modified to change the label in "findJunctionsTopHat"
          File : TopHatFindJunctionOperator.java
          String Name : THRESHOLD

          Show
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Following files and modules are modified to change the label in "findJunctions" File : FindJunctionOperator.java String Name : FLANK Following files and modules are modified to change the label in "findJunctionsTopHat" File : TopHatFindJunctionOperator.java String Name : THRESHOLD
          Hide
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

          Branch : https://bitbucket.org/svallapu/charan_igb/branch/IGBF-277
          commit : 97f9454

          Note: This branch is not having updated code of my issue IGBF-517

          Show
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Branch : https://bitbucket.org/svallapu/charan_igb/branch/IGBF-277 commit : 97f9454 Note: This branch is not having updated code of my issue IGBF-517
          Hide
          nfreese Nowlan Freese added a comment -

          1st level review:

          Functioning correctly, Find Junctions and Find Junctions (TopHat) both display to the user "Enter minimum number of bases required to align on each side of the intron/junction:"

          Show
          nfreese Nowlan Freese added a comment - 1st level review: Functioning correctly, Find Junctions and Find Junctions (TopHat) both display to the user "Enter minimum number of bases required to align on each side of the intron/junction:"
          Hide
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

          Pull request is created #660

          Show
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Pull request is created #660
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged to master on team repository.

          Show
          ann.loraine Ann Loraine added a comment - Merged to master on team repository.
          Hide
          nfreese Nowlan Freese added a comment -

          Testing Mac: Working correctly

          Show
          nfreese Nowlan Freese added a comment - Testing Mac: Working correctly
          Hide
          karthik Karthik Raveendran added a comment -

          Testing Windows: Works correctly

          Show
          karthik Karthik Raveendran added a comment - Testing Windows: Works correctly
          Hide
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

          Testing Windows: Works correctly

          Show
          svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Testing Windows: Works correctly

            People

            • Assignee:
              svallapu Sai Charan Reddy Vallapureddy (Inactive)
              Reporter:
              mason Mason Meyer (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: