Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2910

Investigate: ENCODE RNA track hub does not appear after added to IGB

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Sep10, Fall 3 2021 Sep 13 - Sep 24, Fall 4 2021 Sep 27 - Oct 8

      Description

      The track hub named "ENCODE RNA" declares that it has data for human genome version hg38 (aka H_sapiens_Dec_2013), and the Track Hub Facade creates an IGB Quickload URL for it, but when the Quickload URL is added to IGB, the data sources does not show a folder for it.

      The converted URL:

      To see the list of available genome versions on this hub, see:

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-2831 [ 19524 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Attachment araTha1.png [ 16779 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 1 2021 Aug 16 - Aug 27 [ 127 ] Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Aug 10 [ 127, 128 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Story Points 1 0.5
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Story Points 0.5 1
            Hide
            ann.loraine Ann Loraine added a comment -

            Some problem occurs with other track hubs, including GTEx Analysis Hub.

            Show
            ann.loraine Ann Loraine added a comment - Some problem occurs with other track hubs, including GTEx Analysis Hub.
            ann.loraine Ann Loraine made changes -
            Sprint Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Sep10 [ 127, 128 ] Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Sep10, Fall 3 2021Sep 13 - Sep 24 [ 127, 128, 129 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            pbadzuh Philip Badzuh (Inactive) made changes -
            Link This issue relates to IGBF-2944 [ IGBF-2944 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Link This issue relates to IGBF-2911 [ IGBF-2911 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Link This issue relates to IGBF-2911 [ IGBF-2911 ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            Please see the PR that fixes this issue here. I have tested both ENCODE RNA and GTEx Analysis trackhubs. All others that I have tested seem to be working as well, however, my testing has not been extensive, so more could be beneficial.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - Please see the PR that fixes this issue here . I have tested both ENCODE RNA and GTEx Analysis trackhubs. All others that I have tested seem to be working as well, however, my testing has not been extensive, so more could be beneficial.
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            To clarify, the changes at IGBF-2944 are required for the ones made for this ticket to work properly.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - To clarify, the changes at IGBF-2944 are required for the ones made for this ticket to work properly.
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Comment on branch: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2944#diff

            Please look into more effective use of URL object methods, such as the "getProtocol" method.

            Read: https://www.baeldung.com/java-url

            It's a bit weird how the code in "QuickloadUtils.java" creates a URL, which has a "getProtocol" method, but then uses the String strAnnotsURL and its "startsWith" method to determine the protocol. This is a bit ugly and should be fixed. Now is a good time to fix this, I think!

            Also, we need to increment the IGB version number before making new changes to the IGB code base itself (see IGBF-2936 "Update main branch to 9.1.10").

            Show
            ann.loraine Ann Loraine added a comment - - edited Comment on branch: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2944#diff Please look into more effective use of URL object methods, such as the "getProtocol" method. Read: https://www.baeldung.com/java-url It's a bit weird how the code in "QuickloadUtils.java" creates a URL, which has a "getProtocol" method, but then uses the String strAnnotsURL and its "startsWith" method to determine the protocol. This is a bit ugly and should be fixed. Now is a good time to fix this, I think! Also, we need to increment the IGB version number before making new changes to the IGB code base itself (see IGBF-2936 "Update main branch to 9.1.10").
            ann.loraine Ann Loraine made changes -
            Comment [ Can this be fixed without a new IGB release? ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            I agree. I have updated my branch with the requested change. Please see it here.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - I agree. I have updated my branch with the requested change. Please see it here .
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            A couple of questions about this proposed line of code in SymLoader.java in IGB:

            +        extension = extension.split("\\?")[0]; // strip off potential query params
            
            • What happens if the file name contains a "?" character?
            • More importantly, I'm trying to understand why the URL for a file would contain query parameters downstream of the file extension.

            My understanding (and this could be wrong, of course!) is that the annots endpoint's "file" tags contain "name" parameters that terminate the file extension. Are some of the URLs provided by trackhub endpoints violating this assumption?

            Show
            ann.loraine Ann Loraine added a comment - - edited A couple of questions about this proposed line of code in SymLoader.java in IGB: + extension = extension.split( "\\?" )[0]; // strip off potential query params What happens if the file name contains a "?" character? More importantly, I'm trying to understand why the URL for a file would contain query parameters downstream of the file extension. My understanding (and this could be wrong, of course!) is that the annots endpoint's "file" tags contain "name" parameters that terminate the file extension. Are some of the URLs provided by trackhub endpoints violating this assumption?
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            We can discuss above issue on Wednesday and then summarize the discussion in a new comment.
            Thank you Philip Badzuh!

            Show
            ann.loraine Ann Loraine added a comment - We can discuss above issue on Wednesday and then summarize the discussion in a new comment. Thank you Philip Badzuh !
            Hide
            ann.loraine Ann Loraine added a comment -

            The ENCODE RNA data source includes data files with names such as:

            https://www.encodeproject.org/files/ENCFF949MYP/@@download/ENCFF949MYP.bigBed?proxy=true
            

            This interferes with IGB's ability to determine the file type.

            Show
            ann.loraine Ann Loraine added a comment - The ENCODE RNA data source includes data files with names such as: https: //www.encodeproject.org/files/ENCFF949MYP/@@download/ENCFF949MYP.bigBed?proxy= true This interferes with IGB's ability to determine the file type.
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            I have updated IGB-related changes at IGBF-2944 and can submit a PR for the facade changes associated with this ticket.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - I have updated IGB-related changes at IGBF-2944 and can submit a PR for the facade changes associated with this ticket.
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Please submit PR for the track hub facade codebase, for branch: https://bitbucket.org/pbadzuh/hub-api_pbdev/branch/IGBF-2910#diff

            Show
            ann.loraine Ann Loraine added a comment - Please submit PR for the track hub facade codebase, for branch: https://bitbucket.org/pbadzuh/hub-api_pbdev/branch/IGBF-2910#diff
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            Please see PR here.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - Please see PR here .
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged. Moving back to "To-Do" pending update of IGB code base to use 9.1.10 version string instead of 9.1.8.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged. Moving back to "To-Do" pending update of IGB code base to use 9.1.10 version string instead of 9.1.8.
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            IGB code base is updated to 9.1.10.
            Philip Badzuh - please rebase and submit PR.

            Show
            ann.loraine Ann Loraine added a comment - IGB code base is updated to 9.1.10. Philip Badzuh - please rebase and submit PR.
            ann.loraine Ann Loraine made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Philip Badzuh [ pbadzuh ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            PR for IGBF-2944 submitted.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - PR for IGBF-2944 submitted.
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            ann.loraine Ann Loraine added a comment -

            PRs are all merged and the new track hub facade back end code is deployed to the "back end" site used by BioViz.org. You can test the track hub functionality by visiting the main bioviz.org Web site and clicking the link in the middle part of the end of the page. From there, you can convert sites and try them out in the new IGB version.

            Show
            ann.loraine Ann Loraine added a comment - PRs are all merged and the new track hub facade back end code is deployed to the "back end" site used by BioViz.org. You can test the track hub functionality by visiting the main bioviz.org Web site and clicking the link in the middle part of the end of the page. From there, you can convert sites and try them out in the new IGB version.
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Sep10, Fall 3 2021 Sep 13 - Sep 24 [ 127, 128, 129 ] Fall 1 2021 Aug 16 - Aug 27, Fall 2 2021 Aug 30 - Sep10, Fall 3 2021 Sep 13 - Sep 24, Fall 4 2021 Sep 27 - Oct 8 [ 127, 128, 129, 130 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            nfreese Nowlan Freese made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Hide
            nfreese Nowlan Freese added a comment -

            Philip Badzuh - the server for https://api.wenglab.org/screen_v13/hubs/rna22/hub.txt seems to be down. Is there another example I can use for testing?

            Show
            nfreese Nowlan Freese added a comment - Philip Badzuh - the server for https://api.wenglab.org/screen_v13/hubs/rna22/hub.txt seems to be down. Is there another example I can use for testing?
            nfreese Nowlan Freese made changes -
            Status Post-merge Testing In Progress [ 10003 ] Merged Needs Testing [ 10002 ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            Seems to be up now.

            In case it goes down again, to test the first commit any converted trackhub URL that has an unsecured/http protocol can be used e.g. this one.

            The issue was that the annots.xml validation was not very robust - the presence of 'https' or 'http' was checked for in the data source URL, however, since multiple protocols are present in converted trackhub quickloads, this led to issues. Now the first and actual protocol of the data source is being checked.

            Regarding the second commit, I am not sure if there are any other data files in any trackhub's annots.xml that have query parameters. You may have to catch the ENCODE RNA server being up.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - Seems to be up now. In case it goes down again, to test the first commit any converted trackhub URL that has an unsecured/http protocol can be used e.g. this one . The issue was that the annots.xml validation was not very robust - the presence of 'https' or 'http' was checked for in the data source URL, however, since multiple protocols are present in converted trackhub quickloads, this led to issues. Now the first and actual protocol of the data source is being checked. Regarding the second commit , I am not sure if there are any other data files in any trackhub's annots.xml that have query parameters. You may have to catch the ENCODE RNA server being up.
            nfreese Nowlan Freese made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Hide
            nfreese Nowlan Freese added a comment - - edited

            I was able to test using the URL: https://translate.bioviz.org/rest_api/?hubUrl=https://api.wenglab.org/screen_v13/hubs/rna22/hub.txt&fileName=/

            Note that there is an issue where the protocol is not added to the translated track hub webpage (for example the url is missing https://). This prevents IGB from correctly adding the Quickload site. There appears to be some code to handle this on bioviz.org/trackhubs, but it appears to only work for localhost.

            I was able to see the quickload folder for hg38 and mm10 as well as load data for both. I was unable to see the quickload folder for hg19. When I tried to reload the quickload the translate.bioviz.org server appeared to go down.

            I am going to close this issue as the primary issues have been solved.

            Show
            nfreese Nowlan Freese added a comment - - edited I was able to test using the URL: https://translate.bioviz.org/rest_api/?hubUrl=https://api.wenglab.org/screen_v13/hubs/rna22/hub.txt&fileName=/ Note that there is an issue where the protocol is not added to the translated track hub webpage (for example the url is missing https:// ). This prevents IGB from correctly adding the Quickload site. There appears to be some code to handle this on bioviz.org/trackhubs, but it appears to only work for localhost. I was able to see the quickload folder for hg38 and mm10 as well as load data for both. I was unable to see the quickload folder for hg19. When I tried to reload the quickload the translate.bioviz.org server appeared to go down. I am going to close this issue as the primary issues have been solved.
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ] Philip Badzuh [ pbadzuh ]
            nfreese Nowlan Freese made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                pbadzuh Philip Badzuh (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: