Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2981

Prevent BioViz Connect from saving values from the interface into metadata fields for genome version and species

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      See discussion of user interface component labels getting saved as genome version (assembly) and species metadata values. See related issue.

        Attachments

        1. Species.png
          Species.png
          182 kB
        2. Genome Version.png
          Genome Version.png
          192 kB
        3. Species 2.png
          Species 2.png
          140 kB
        4. Genome Version 2.png
          Genome Version 2.png
          179 kB
        5. Homo Sapiens.png
          Homo Sapiens.png
          119 kB
        6. Genome Version 3.png
          Genome Version 3.png
          144 kB
        7. Genome Version 4.png
          Genome Version 4.png
          236 kB

          Issue Links

            Activity

            Hide
            karthik Karthik Raveendran added a comment -

            When saving metadata, if the species and version is not selected by the user, it used to be saved as "Species..." and "Version..." before IGBF-2973. After IGBF-2973, its saved as "Species" and "Genome Version". This needs to be changed to "NA" for both and if the values are "NA", when metadata is retrieved and displayed, the dropdowns should show default values of "Species" and "Genome Version"

            Show
            karthik Karthik Raveendran added a comment - When saving metadata, if the species and version is not selected by the user, it used to be saved as "Species..." and "Version..." before IGBF-2973 . After IGBF-2973 , its saved as "Species" and "Genome Version". This needs to be changed to "NA" for both and if the values are "NA", when metadata is retrieved and displayed, the dropdowns should show default values of "Species" and "Genome Version"
            Hide
            karthik Karthik Raveendran added a comment - - edited

            Pushed changes to repo. Commit in IGBF-2981

            Changes made to:
            saveMetadata: to check if the Species and Genome Version is selected and if not, save as "NA"
            metadataUI: to display default values when both or one of the values are "NA"

            Show
            karthik Karthik Raveendran added a comment - - edited Pushed changes to repo. Commit in IGBF-2981 Changes made to: saveMetadata: to check if the Species and Genome Version is selected and if not, save as "NA" metadataUI: to display default values when both or one of the values are "NA"
            Hide
            karthik Karthik Raveendran added a comment -

            Testing Protocol:
            Saving Metadata to files:
            a) If the file has not previously saved species or version data, save it as it is and reopen metadata module to see if it has "Species" and "Genome Version"
            b) if it has some values, select "Species" option in species dropdown and save it. Reopen metadata module to see if it has "Species" and "Genome Version"
            c) Select a species option eg. Homo sapiens and save metadata without selecting Version. Reopen metadata module to see if it has, let's say, "Homo Sapiens" and "Genome Version"
            c) Finally select appropriate species and version and save that. Reopen metadata module to see if it has the values you selected.

            Show
            karthik Karthik Raveendran added a comment - Testing Protocol: Saving Metadata to files: a) If the file has not previously saved species or version data, save it as it is and reopen metadata module to see if it has "Species" and "Genome Version" b) if it has some values, select "Species" option in species dropdown and save it. Reopen metadata module to see if it has "Species" and "Genome Version" c) Select a species option eg. Homo sapiens and save metadata without selecting Version. Reopen metadata module to see if it has, let's say, "Homo Sapiens" and "Genome Version" c) Finally select appropriate species and version and save that. Reopen metadata module to see if it has the values you selected.
            Hide
            karthik Karthik Raveendran added a comment -

            Note: There is a check for "Species" and "Version" strings in metdata at MetaDataUI and SaveDataUI as well. That's because previously values "Species..", "Version...", "Species" and "Genome Version" was accidently saved as metadata for some files.

            Show
            karthik Karthik Raveendran added a comment - Note: There is a check for "Species" and "Version" strings in metdata at MetaDataUI and SaveDataUI as well. That's because previously values "Species..", "Version...", "Species" and "Genome Version" was accidently saved as metadata for some files.
            Show
            nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/bioviz-connect/pull-requests/264/igbf-2981-change-metadata-save?link_source=email
            Hide
            omarne Omkar Marne (Inactive) added a comment - - edited

            Test results.

            • After saving the file as it is, "Species" and "Genome Version" was present in the metadata. Please see 'Species' and 'Genome 'Version' screenshot.
            • After selecting "Species" option in species dropdown menu and saving it. "Species" and "Genome Version" was present in the metadata. Please see 'Species 2' and 'Genome Version 2' screenshot.
            • After selecting "Homo Sapiens" option and without selecting the version, "Homo Sapiens" and "Genome Version" was present in the metadata. Please see "Homo Sapiens" and "Genome Version 3" screenshot.
            • After selecting "Homo Sapiens" and its version, selected values were present in the metadata. Please see "Homo Sapiens" and "Genome Version 4" screenshot.

            Closing the ticket.

            Show
            omarne Omkar Marne (Inactive) added a comment - - edited Test results. After saving the file as it is, "Species" and "Genome Version" was present in the metadata. Please see 'Species' and 'Genome 'Version' screenshot. After selecting "Species" option in species dropdown menu and saving it. "Species" and "Genome Version" was present in the metadata. Please see 'Species 2' and 'Genome Version 2' screenshot. After selecting "Homo Sapiens" option and without selecting the version, "Homo Sapiens" and "Genome Version" was present in the metadata. Please see "Homo Sapiens" and "Genome Version 3" screenshot. After selecting "Homo Sapiens" and its version, selected values were present in the metadata. Please see "Homo Sapiens" and "Genome Version 4" screenshot. Closing the ticket.

              People

              • Assignee:
                karthik Karthik Raveendran
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: