Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2983

Fix bookmark file name appearance in IGB

    Details

    • Story Points:
      2
    • Sprint:
      Fall 5 2021 Oct 11 - Oct 22, Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 24

      Description

      Situation: When a file from BioViz Connect is loaded in IGB without a species or genome version value, IGB uses logic in the loadUnknownData method of BookmarkUnibrowControlServlet.java to load the data. However, loadUnknownData fails to use the provided sym name.

      Task: Fix IGB so that the provided sym name is used when necessary.

        Attachments

        1. screenshot-1.png
          screenshot-1.png
          130 kB
        2. screenshot-2.png
          screenshot-2.png
          203 kB
        3. screenshot-3.png
          screenshot-3.png
          205 kB

          Issue Links

            Activity

            Hide
            ann.loraine Ann Loraine added a comment -

            Merged and ready for testing using master branch installer(s) from bitbucket repository Downloads folder.

            Show
            ann.loraine Ann Loraine added a comment - Merged and ready for testing using master branch installer(s) from bitbucket repository Downloads folder.
            Hide
            omarne Omkar Marne (Inactive) added a comment - - edited

            Test results on master branch :

            • After clicking the given link the genome got automatically selected and the track name and name under available data was diseaseDa2d.bed. Please see screenshot 2.
            • After removing the file and clicking the link again, the genome did not change, but the track name and name under available data was diseaseDa2d.bed. Please see screenshot 3.
            Show
            omarne Omkar Marne (Inactive) added a comment - - edited Test results on master branch : After clicking the given link the genome got automatically selected and the track name and name under available data was diseaseDa2d.bed. Please see screenshot 2. After removing the file and clicking the link again, the genome did not change, but the track name and name under available data was diseaseDa2d.bed. Please see screenshot 3.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            A couple of questions with the above comments. Please address:

            • Screenshot 2 does not include the title bar. Please always include the title bar as it shows the IGB version and genome. (Genome is also shown in the Current Genome tab)
            • The Available Data section is different in the two screenshots. I thought the point of this change was to remove the URL components so that you don't see so many folders, by ensuring that the "sym name" fields is respected regardless of whether a genome version is indicated?
            • I was confused as to what "sym name" is being passed in the test bookmarks. Is it the same as the file name?
            Show
            ann.loraine Ann Loraine added a comment - - edited A couple of questions with the above comments. Please address: Screenshot 2 does not include the title bar. Please always include the title bar as it shows the IGB version and genome. (Genome is also shown in the Current Genome tab) The Available Data section is different in the two screenshots. I thought the point of this change was to remove the URL components so that you don't see so many folders, by ensuring that the "sym name" fields is respected regardless of whether a genome version is indicated? I was confused as to what "sym name" is being passed in the test bookmarks. Is it the same as the file name?
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Here are two new links to try (copy and paste them into web browser). The sym names have been changed so that they are different than the file names.

            http://127.0.0.1:7085/IGBControl?
            version=A_lyrata_Apr_2011&
            cyverse_data=true&
            sym_col_0=0x00FF00&
            sym_bg_0=0xFF0000&
            sym_name_0=exampleSymName1.bed&
            query_url=https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed&
            feature_url_0=https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed&
            sym_method_0=https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed&
            loadresidues=false&
            server_url=cyverse

            http://127.0.0.1:7085/IGBControl?version=?&
            cyverse_data=true&
            sym_col_0=0x00FF00&
            sym_bg_0=0xFF0000&
            sym_name_0=exampleSymName2.bed&
            query_url=https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed&
            feature_url_0=https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed&
            sym_method_0=https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed&
            loadresidues=false&
            server_url=cyverse

            Show
            nfreese Nowlan Freese added a comment - - edited Here are two new links to try (copy and paste them into web browser). The sym names have been changed so that they are different than the file names. http://127.0.0.1:7085/IGBControl? version=A_lyrata_Apr_2011& cyverse_data=true& sym_col_0=0x00FF00& sym_bg_0=0xFF0000& sym_name_0=exampleSymName1.bed& query_url= https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed& feature_url_0= https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed& sym_method_0= https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed& loadresidues=false& server_url=cyverse http://127.0.0.1:7085/IGBControl?version=?& cyverse_data=true& sym_col_0=0x00FF00& sym_bg_0=0xFF0000& sym_name_0=exampleSymName2.bed& query_url= https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed& feature_url_0= https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed& sym_method_0= https://data.cyverse.org/dav-anon/iplant/home/kraveend91/diseaseDa2d.bed& loadresidues=false& server_url=cyverse
            Hide
            omarne Omkar Marne (Inactive) added a comment -

            Final Test results on the latest master branch.

            • After clicking the given link the genome got automatically selected and the track name and name under available data was diseaseDa2d.bed. Please check the sym name in the screenshot 2. The symname is exampleSymName1.bed.
            • After removing the file and clicking the link again, the genome did not change, the file name is same which is diseaseDa2d.bed. The symname is exampleSymName2.bed The full URL is not visible in the available data. Please see screenshot 3.

            Dr. Freese and I also tested on galaxy and bioviz connect, the results are good.

            Closing the ticket.

            Show
            omarne Omkar Marne (Inactive) added a comment - Final Test results on the latest master branch. After clicking the given link the genome got automatically selected and the track name and name under available data was diseaseDa2d.bed. Please check the sym name in the screenshot 2. The symname is exampleSymName1.bed. After removing the file and clicking the link again, the genome did not change, the file name is same which is diseaseDa2d.bed. The symname is exampleSymName2.bed The full URL is not visible in the available data. Please see screenshot 3. Dr. Freese and I also tested on galaxy and bioviz connect, the results are good. Closing the ticket.

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: