Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2999

Fix eFP-Seq browser JS to work with Safari

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1.5
    • Sprint:
      Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 24

      Description

      Situation: The eFP-Seq browser directs users to https://bioviz.org/bar.html. The bar.html page javascript (bar.js) then contacts IGB on localhost. Unfortunately, Safari will not allow an https page to contact localhost. This causes Safari users to not be able to properly use the eFP-Seq browser to view data in IGB.

      Task: Fix bar.js so that if a user is on the Safari web browser and is using https, they are redirected to http.

        Attachments

        1. chrome.png
          chrome.png
          88 kB
        2. Data.png
          Data.png
          99 kB
        3. edge.png
          edge.png
          81 kB
        4. error.txt
          9 kB
        5. firefox.png
          firefox.png
          77 kB

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1765 [ 17855 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-2987 [ IGBF-2987 ]
            ann.loraine Ann Loraine made changes -
            Description Test and fix (if required) the eFP-Seq browser connection. Test and fix (if required) the eFP-Seq browser connection. See related ticket for what to test, and why.
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Summary Fix efpseq browser javascript Investigate: Fix efpseq browser javascript
            nfreese Nowlan Freese made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            nfreese Nowlan Freese made changes -
            Summary Investigate: Fix efpseq browser javascript Investigate: Fix eFP-Seq browser javascript
            Hide
            nfreese Nowlan Freese added a comment - - edited

            The eFP-Seq browser is unable to connect with IGB while using the Safari web browser. When an eFP-Seq user clicks the Alignments in IGB hyperlink, they are directed to https://bioviz.org/bar.html. Safari does not allow https sites to communicate with http://localhost.

            There are two issues that need to be addressed to allow users to use the eFP-Seq browser on the Safari web browser. For the first issue, we can use similar logic employed for galaxy.html (IGBF-2987) where the bar.js file checks if the user is using Safari and if they are on http or https. If they are on https and using safari, we will redirect the users to http://bioviz.org/bar.html.

            For the second issue, we will need to make changes to the BioViz playbook to alter the Apache configuration. Currently, Apache is configured to redirect all http://bioviz.org traffic to https except if the request URI is galaxy.html (IGBF-2505). We would need to extend this logic to bar.html.

            Show
            nfreese Nowlan Freese added a comment - - edited The eFP-Seq browser is unable to connect with IGB while using the Safari web browser. When an eFP-Seq user clicks the Alignments in IGB hyperlink, they are directed to https://bioviz.org/bar.html . Safari does not allow https sites to communicate with http://localhost . There are two issues that need to be addressed to allow users to use the eFP-Seq browser on the Safari web browser. For the first issue, we can use similar logic employed for galaxy.html ( IGBF-2987 ) where the bar.js file checks if the user is using Safari and if they are on http or https. If they are on https and using safari, we will redirect the users to http://bioviz.org/bar.html . For the second issue, we will need to make changes to the BioViz playbook to alter the Apache configuration. Currently, Apache is configured to redirect all http://bioviz.org traffic to https except if the request URI is galaxy.html ( IGBF-2505 ). We would need to extend this logic to bar.html.
            nfreese Nowlan Freese made changes -
            Link This issue relates to IGBF-2505 [ IGBF-2505 ]
            Hide
            nfreese Nowlan Freese added a comment - - edited

            There is an issue occurring in bar.js that is causing the data to not load in IGB when on Safari on http. In the addCoordinatesForGeneId method, the xhr.status is not returning a 200 for some reason. Need to investigate further to understand why.

            Update: The issue was the /cgi-bin/geneIdLookup.py was being redirected to https and this was being blocked by Safari. Updated the httpd.conf to not redirect /cgi-bin/geneIdLookup.py to https.

            Show
            nfreese Nowlan Freese added a comment - - edited There is an issue occurring in bar.js that is causing the data to not load in IGB when on Safari on http. In the addCoordinatesForGeneId method, the xhr.status is not returning a 200 for some reason. Need to investigate further to understand why. Update: The issue was the /cgi-bin/geneIdLookup.py was being redirected to https and this was being blocked by Safari. Updated the httpd.conf to not redirect /cgi-bin/geneIdLookup.py to https.
            nfreese Nowlan Freese made changes -
            Status In Progress [ 3 ] To-Do [ 10305 ]
            nfreese Nowlan Freese made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Commits:
            BioViz: https://bitbucket.org/nfreese/bioviz/commits/11fb44a36ecfd8e0792b73bb934dc9a4d90921e1
            BioViz-playbooks: https://bitbucket.org/nfreese/bioviz-playbooks/commits/9ed7f05ac0689682871c7b1b12c920b980c71b5e?at=IGBF-2999

            Changes are manually implemented on bioviztest.bioviz.org.

            To test:
            Turn on IGB.
            Open the Safari web browser.
            Copy and paste this URL into Safari.
            The Arabidopsis genome should load in IGB and data should appear.
            Remove the data file from IGB.

            Repeat the test on Chrome, Firefox, and Edge. The bar.html page should remain on https and the data should load without issue.

            Show
            nfreese Nowlan Freese added a comment - - edited Commits: BioViz: https://bitbucket.org/nfreese/bioviz/commits/11fb44a36ecfd8e0792b73bb934dc9a4d90921e1 BioViz-playbooks: https://bitbucket.org/nfreese/bioviz-playbooks/commits/9ed7f05ac0689682871c7b1b12c920b980c71b5e?at=IGBF-2999 Changes are manually implemented on bioviztest.bioviz.org. To test: Turn on IGB. Open the Safari web browser. Copy and paste this URL into Safari. The Arabidopsis genome should load in IGB and data should appear. Remove the data file from IGB. Repeat the test on Chrome, Firefox, and Edge. The bar.html page should remain on https and the data should load without issue.
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            nfreese Nowlan Freese made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            nfreese Nowlan Freese made changes -
            Summary Investigate: Fix eFP-Seq browser javascript Fix eFP-Seq browser JS to work with Safari
            nfreese Nowlan Freese made changes -
            Description Test and fix (if required) the eFP-Seq browser connection. See related ticket for what to test, and why. Situation: The eFP-Seq browser directs users to https://bioviz.org/bar.html. The bar.html page javascript (bar.js) then contacts IGB on localhost. Unfortunately, Safari will not allow an https page to contact localhost. This causes Safari users to not be able to properly use the eFP-Seq browser to view data in IGB.

            Task: Fix bar.js so that if a user is on the Safari web browser and is using https, they are redirected to http.
            nfreese Nowlan Freese made changes -
            Story Points 1 1.5
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Changes look great. Thanks for improving the apache configuration. Please submit PR.

            Show
            ann.loraine Ann Loraine added a comment - Changes look great. Thanks for improving the apache configuration. Please submit PR.
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Nowlan Freese [ nfreese ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 6 2021 Oct 25 - Nov 5 [ 132 ] Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 19 [ 132, 133 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Show
            nfreese Nowlan Freese added a comment - BioViz pull request: https://bitbucket.org/lorainelab/bioviz/pull-requests/71/igbf-2999-redirect-safari-web-browser-to BioViz-playbooks pull request: https://bitbucket.org/lorainelab/bioviz-playbooks/pull-requests/10/igbf-2999-do-not-redirect-barhtml-and
            nfreese Nowlan Freese made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            Hide
            ann.loraine Ann Loraine added a comment -

            PR's are both merged. New code is deployed to bioviz.org main site. Please test.

            Show
            ann.loraine Ann Loraine added a comment - PR's are both merged. New code is deployed to bioviz.org main site. Please test.
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked lower
            omarne Omkar Marne (Inactive) made changes -
            Assignee Omkar Marne [ omarne ]
            omarne Omkar Marne (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Show
            nfreese Nowlan Freese added a comment - New link for testing: https://bioviz.org/bar.html?version=A_thaliana_Jun_2009&gene_id=AT2G24270&feature_url_0=https://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam&genome=A_thaliana_Jun_2009&annotation_set=Araport11&query_url=https://s3.amazonaws.com/iplant-cdn/iplant/home/araport/rnaseq_bam/aerial/ERR274310/accepted_hits.bam&server_url=bar
            omarne Omkar Marne (Inactive) made changes -
            Attachment Data Loading.png [ 16952 ]
            Hide
            omarne Omkar Marne (Inactive) added a comment -

            Above link is getting error 500 from the server. Please check snapshot ' data loading'.

            Show
            omarne Omkar Marne (Inactive) added a comment - Above link is getting error 500 from the server. Please check snapshot ' data loading'.
            omarne Omkar Marne (Inactive) made changes -
            Assignee Omkar Marne [ omarne ] Nowlan Freese [ nfreese ]
            omarne Omkar Marne (Inactive) made changes -
            Status Post-merge Testing In Progress [ 10003 ] To-Do [ 10305 ]
            nfreese Nowlan Freese made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            nfreese Nowlan Freese made changes -
            Attachment error.txt [ 16957 ]
            Hide
            nfreese Nowlan Freese added a comment -

            I have attached the error (error.txt) I am seeing in the logs (/var/log/httpd) for the BioViz EC2 when I try to hit either https or http bioviz.org/cgi-bin/geneIdLookup.py?gene_id=AT2G24270

            [~aloraine] - I'm not sure what is causing this issue.

            Show
            nfreese Nowlan Freese added a comment - I have attached the error (error.txt) I am seeing in the logs (/var/log/httpd) for the BioViz EC2 when I try to hit either https or http bioviz.org/cgi-bin/geneIdLookup.py?gene_id=AT2G24270 [~aloraine] - I'm not sure what is causing this issue.
            nfreese Nowlan Freese made changes -
            Status In Progress [ 3 ] To-Do [ 10305 ]
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ] Ann Loraine [ aloraine ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment firefox.png [ 16979 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment chrome.png [ 16980 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment edge.png [ 16981 ]
            Hide
            omarne Omkar Marne (Inactive) added a comment - - edited

            Tested the URL on edge, chrome, firefox and safari latest versions. The link is working and the data is loaded in IGB. Please check the snapshot edge, firefox, chrome and data.

            Show
            omarne Omkar Marne (Inactive) added a comment - - edited Tested the URL on edge, chrome, firefox and safari latest versions. The link is working and the data is loaded in IGB. Please check the snapshot edge, firefox, chrome and data.
            omarne Omkar Marne (Inactive) made changes -
            Assignee Ann Loraine [ aloraine ] Omkar Marne [ omarne ]
            omarne Omkar Marne (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            omarne Omkar Marne (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            omarne Omkar Marne (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Needs 1st Level Review [ 10005 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            omarne Omkar Marne (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment screenshot-1.png [ 16982 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment screenshot-1.png [ 16982 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment Data.png [ 16983 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment Data Loading.png [ 16952 ]
            Hide
            nfreese Nowlan Freese added a comment -

            Testing using this link.

            Working on Safari Version 15.0 (16612.1.29.41.4, 16612)
            Working on Chrome Version 94.0.4606.81 (Official Build) (x86_64)
            Working on Firefox 94.0.2 (64-bit)
            Working on Edge Version 95.0.1020.53 (Official build) (x86_64)

            Show
            nfreese Nowlan Freese added a comment - Testing using this link . Working on Safari Version 15.0 (16612.1.29.41.4, 16612) Working on Chrome Version 94.0.4606.81 (Official Build) (x86_64) Working on Firefox 94.0.2 (64-bit) Working on Edge Version 95.0.1020.53 (Official build) (x86_64)
            Hide
            nfreese Nowlan Freese added a comment -

            Omkar and I have both tested this issue on the various browsers and are no longer seeing the 500 error. My best guess is that redeploying bioviz.org fixed the issue.

            Closing ticket.

            Show
            nfreese Nowlan Freese added a comment - Omkar and I have both tested this issue on the various browsers and are no longer seeing the 500 error. My best guess is that redeploying bioviz.org fixed the issue. Closing ticket.
            nfreese Nowlan Freese made changes -
            Assignee Omkar Marne [ omarne ] Nowlan Freese [ nfreese ]
            nfreese Nowlan Freese made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: