Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 8 2021 Nov 29 - Dec 10, Fall 9 2021 Dec 13 - Dec 24, Spring 1 2022 Jan 3 - Jan 14
Description
1) Find a way to indicate to the user that they need to wait for sometime before the file is renamed and then refresh the page
2) In the rename dialog-box, change title from "Rename..." to "Rename"
3) Fix the cryptic alert message ( "Sorry!...or contact admin") when Manage Link is opened and the old filename is still not replaced.
4) Fix loading spinner of Manage Link to turn off after the alert box has been dismissed
Attachments
Activity
There were two issues in the rename functionality. As mentioned in the earlier comment the the special characters in URI needed to be encoded. But after fixing that, I realized that the error handling in rename function was not effective if there is a value error. This poses a big problem because the user will be blocked from using the folder if the error is not handled well. So in the commit below the error has been handled as well.
[ Commit | https://bitbucket.org/nfreese/bioviz-connect/pull-requests/269/igbf-3023]
Karthik Raveendran Rename of the subfolders was successful and after the click, the "Rename Scheduled!" appeared next to the button but the yellow badge did not appear next to the folder name that says, "Renaming Scheduled. Please wait and refresh the page."
Please let me know if that's expected.
Dr. [~aloraine] Could you please run the playbooks to merge the Karthik's changes into bvctest7.
Test results after performing the testing protocol.
I created a parent folder and subfolders inside the parent folder and uploaded .txt files.
After right-clicking, I performed the below actions and their results were as per the testing protocol.
- The rename had a warning about the time taken to rename.
- Save changes button icon should change to loading icon on click.
- After the click, the "Rename Scheduled!" appeared next to the button.
- The window closed after a few seconds.
- Once the window closes, the corresponding table greyed out.
- A yellow badge had appeared next to the folder name. that says, "Renaming Scheduled. Please wait and refresh the page."
- Double-clicking the folder got disabled when badge appeared
- Right-clicking the folder/file got disabled when badge appeared
- Clicking on the badge refreshed the page.
- When the renaming process was happening I navigated away from the directory and came back and checked that the badge was still there.
I was able to perform on subfolders too and they behave as expected.
Closing the ticket.
Changes made so far:
1) Rename title has been changed
2) In the rename pop-up modal window, the delay warning can be seen during both file or folder renaming process (not just folder renaming)
3) A 5sec delay is added before the modal window is closed and bvc page is refreshed. This works for file renames but folder renames need more time as indicated by the warning
4) When the rename requested and the response is 200 OK, in the modal window next to the "Save Changes" button a message appears that says "Rename Scheduled! " with a 'tick' icon. This is consistent with delete function.
5) The cryptic message in the alert message existed in many alert messages throughout the application. All the messages are modified.
Commit