Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3183

Fix BioViz Connect file with no attached metadata leads to error

    Details

      Description

      Situation: While preparing for the CyVerse Webinar I came across an error in IGB (see comment below). Will need to attempt to reproduce, but it seems to be due to a file in BioViz Connect being viewed in IGB, but with no attached metadata.

      Task: Investigate the issue.

        Attachments

          Issue Links

            Activity

            Hide
            nfreese Nowlan Freese added a comment -

            11:38:38.778 ERROR c.a.i.b.BookmarkUnibrowControlServlet - Error while loading bookmark.
            java.lang.NumberFormatException: Zero length string
            at java.lang.Integer.decode(Integer.java:1162) ~[na:1.8.0_332]
            at java.awt.Color.decode(Color.java:729) ~[na:1.8.0_332]
            at com.affymetrix.igb.bookmarks.BookmarkController.forceStyleChange(BookmarkController.java:544) ~[na:na]
            at com.affymetrix.igb.bookmarks.BookmarkUnibrowControlServlet$1.runInBackground(BookmarkUnibrowControlServlet.java:232) ~[na:na]
            at com.affymetrix.genometry.thread.CThreadWorker.doInBackground(CThreadWorker.java:73) [genometry-9.1.8.jar:na]
            at javax.swing.SwingWorker$1.call(SwingWorker.java:295) [na:1.8.0_332]
            at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_332]
            at javax.swing.SwingWorker.run(SwingWorker.java:334) [na:1.8.0_332]
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_332]
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_332]
            at java.lang.Thread.run(Thread.java:750) [na:1.8.0_332]

            Show
            nfreese Nowlan Freese added a comment - 11:38:38.778 ERROR c.a.i.b.BookmarkUnibrowControlServlet - Error while loading bookmark. java.lang.NumberFormatException: Zero length string at java.lang.Integer.decode(Integer.java:1162) ~ [na:1.8.0_332] at java.awt.Color.decode(Color.java:729) ~ [na:1.8.0_332] at com.affymetrix.igb.bookmarks.BookmarkController.forceStyleChange(BookmarkController.java:544) ~ [na:na] at com.affymetrix.igb.bookmarks.BookmarkUnibrowControlServlet$1.runInBackground(BookmarkUnibrowControlServlet.java:232) ~ [na:na] at com.affymetrix.genometry.thread.CThreadWorker.doInBackground(CThreadWorker.java:73) [genometry-9.1.8.jar:na] at javax.swing.SwingWorker$1.call(SwingWorker.java:295) [na:1.8.0_332] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_332] at javax.swing.SwingWorker.run(SwingWorker.java:334) [na:1.8.0_332] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_332] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_332] at java.lang.Thread.run(Thread.java:750) [na:1.8.0_332]
            Hide
            nfreese Nowlan Freese added a comment - - edited

            To reproduce the issue:

            1. Start IGB.
            2. Sign in to the nowlanf account on BioViz Connect.
            3. Navigate to /iplant/home/nowlanf/CyVerse_Webinar_doNotAlter/reads
            4. Click View in IGB for october5test.bedgraph (file should be public and have no associated metadata).

            The issue is that when a file in BioViz Connect has no metadata (the AVUs are completely blank) IGB throws an error when it tries to decode the color for the empty color value. If the user interacts with the metadata right panel and clicks Save then the default color values should be saved and the issue would not appear in IGB.

            There are two ways to go about tackling this issue:

            1. We add logic to BioViz Connect so that if there is no AVU for foreground or background color then a default is sent to IGB.
            2. We add logic to IGB to catch empty values for foreground/background color.

            Here are my changes to IGB for approach number 2: https://bitbucket.org/nfreese/nowlanfork-igb/commits/12e724f37481732e5a1b23c0e436ba1e1c83321e

            It may be worth implementing both changes.

            Show
            nfreese Nowlan Freese added a comment - - edited To reproduce the issue: Start IGB. Sign in to the nowlanf account on BioViz Connect. Navigate to /iplant/home/nowlanf/CyVerse_Webinar_doNotAlter/reads Click View in IGB for october5test.bedgraph (file should be public and have no associated metadata). The issue is that when a file in BioViz Connect has no metadata (the AVUs are completely blank) IGB throws an error when it tries to decode the color for the empty color value. If the user interacts with the metadata right panel and clicks Save then the default color values should be saved and the issue would not appear in IGB. There are two ways to go about tackling this issue: We add logic to BioViz Connect so that if there is no AVU for foreground or background color then a default is sent to IGB. We add logic to IGB to catch empty values for foreground/background color. Here are my changes to IGB for approach number 2: https://bitbucket.org/nfreese/nowlanfork-igb/commits/12e724f37481732e5a1b23c0e436ba1e1c83321e It may be worth implementing both changes.
            Show
            nfreese Nowlan Freese added a comment - Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/912/igbf-3183-handle-bg-and-sym-color-when
            Hide
            ann.loraine Ann Loraine added a comment -

            Master branch installers are built and deployed to bioviz.org under the "early access" section. Ready for testing.

            Note: Apple master branch installer has been notarized. This means that you should be able to install IGB on a Mac without having to modify your computer's security settings.

            Show
            ann.loraine Ann Loraine added a comment - Master branch installers are built and deployed to bioviz.org under the "early access" section. Ready for testing. Note: Apple master branch installer has been notarized. This means that you should be able to install IGB on a Mac without having to modify your computer's security settings.
            Hide
            nfreese Nowlan Freese added a comment -

            I have created IGBF-3194 to address the issue with blank values being sent by BioViz Connect.

            Show
            nfreese Nowlan Freese added a comment - I have created IGBF-3194 to address the issue with blank values being sent by BioViz Connect.
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on Mac 12.6 with IGB master 9.1.10 as of October 11, 2022

            Clicking View in IGB on a file october5test.bedgraph with no saved metadata no longer generates an error in IGB and the file loads correctly.
            Clicking View in IGB on a file 2022-9-26_bigwig_893_unscaled_test1.bigwig with metadata loads correctly in IGB.

            Closing ticket.

            Show
            nfreese Nowlan Freese added a comment - Tested on Mac 12.6 with IGB master 9.1.10 as of October 11, 2022 Clicking View in IGB on a file october5test.bedgraph with no saved metadata no longer generates an error in IGB and the file loads correctly. Clicking View in IGB on a file 2022-9-26_bigwig_893_unscaled_test1.bigwig with metadata loads correctly in IGB. Closing ticket.

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: