Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3294

Edit Markdowns and Functions.R to reference counts input file

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      The count file being used is in the results folder of muday-144-analysis:
      ../muday-144-analysis/results/muday-144-SL5_counts-salmon.txt

      The R markdowns and Functions.R script in the DESeq_analysis folder need to be changed to the following so the file is read.csv into R from the correct file location:
      "../results/muday-144-SL5_counts-salmon.txt"

        Attachments

          Activity

          Hide
          Mdavis4290 Molly Davis added a comment -

          Edited markdowns and Functions.R files to reference correct counts input file. The .Rproj file was also edited to the correct location in the repo.

          Branch: https://bitbucket.org/mdavis4290/molly-flavonoid-rnaseq/branch/IGBF-3294

          Show
          Mdavis4290 Molly Davis added a comment - Edited markdowns and Functions.R files to reference correct counts input file. The .Rproj file was also edited to the correct location in the repo. Branch: https://bitbucket.org/mdavis4290/molly-flavonoid-rnaseq/branch/IGBF-3294
          Hide
          ann.loraine Ann Loraine added a comment -

          Code changes are fine. Functional review to happen in another ticket.
          Moving to "Ready for Pull Request" for [~molly] to submit a PR to main branch in team repository when ready.

          Show
          ann.loraine Ann Loraine added a comment - Code changes are fine. Functional review to happen in another ticket. Moving to "Ready for Pull Request" for [~molly] to submit a PR to main branch in team repository when ready.
          Show
          Mdavis4290 Molly Davis added a comment - I made a new fork to clean up merges: https://bitbucket.org/mdavis4290/molly-flavonoid-rnaseq/src/main/ Branch: https://bitbucket.org/mdavis4290/molly-flavonoid-rnaseq/branch/IGBF-3294
          Hide
          ann.loraine Ann Loraine added a comment -

          Submit PR when ready.
          Please rebase the branch on team repository's main branch.

          attn: [~molly]

          Thank you for all your work!

          Show
          ann.loraine Ann Loraine added a comment - Submit PR when ready. Please rebase the branch on team repository's main branch. attn: [~molly] Thank you for all your work!
          Hide
          Mdavis4290 Molly Davis added a comment - - edited
          Show
          Mdavis4290 Molly Davis added a comment - - edited Rebase IGBF-3294 to top of main: https://bitbucket.org/mdavis4290/molly-flavonoid-rnaseq/commits/ git checkout IGBF-3294 git rebase main git push --force origin IGBF-3294 Branch: https://bitbucket.org/mdavis4290/molly-flavonoid-rnaseq/branch/IGBF-3294 Pull Request: https://bitbucket.org/hotpollen/flavonoid-rnaseq/pull-requests/10 [~aloraine]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged. Changes are great. Moving to Done.

          Show
          ann.loraine Ann Loraine added a comment - Merged. Changes are great. Moving to Done.

            People

            • Assignee:
              Mdavis4290 Molly Davis
              Reporter:
              Mdavis4290 Molly Davis
            • Votes:
              0 Vote for this issue
              Watchers:
              Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: