Details

      Description

      Situation: While updating dependencies as part of IGBF-3335 I was unable to update the dependency org.apache.felix.dependencymanager as the following three dependencies specified a lower version:

      • org.lorainelab.igb.remote.services.discovery.provider.configured
      • org.lorainelab.igb.remote.services.distribution.provider.http
      • org.lorainelab.igb.remote.services.topology.manager

      After speaking with Dr. Loraine, the above dependencies (hosted on https://maven.bioviz.org/repo2/org/lorainelab/igb/) may not be needed in the IGB codebase, however we are unsure.

      Task: Determine if the discovery.provider.configured, distribution.provider.http, and topology.manager are being used in the IGB code base. If they are not being used by IGB, please remove them as dependencies.

        Attachments

          Issue Links

            Activity

            Hide
            nfreese Nowlan Freese added a comment - - edited

            Removed:

            • org.lorainelab.igb.remote.services.discovery.provider.configured
            • org.lorainelab.igb.remote.services.topology.manager
            • org.lorainelab.igb.remote.services.distribution.provider.http

            I built IGB using mvn clean install, no errors observed.
            I ran IGB with no errors observed.
            I installed and used an app from the IGB App Manager (Geometric Mean Graph Operator) without issue.
            All bundles active in the felix web console (http://localhost:7080/system/console/bundles)

            Show
            nfreese Nowlan Freese added a comment - - edited Removed: org.lorainelab.igb.remote.services.discovery.provider.configured org.lorainelab.igb.remote.services.topology.manager org.lorainelab.igb.remote.services.distribution.provider.http I built IGB using mvn clean install, no errors observed. I ran IGB with no errors observed. I installed and used an app from the IGB App Manager (Geometric Mean Graph Operator) without issue. All bundles active in the felix web console ( http://localhost:7080/system/console/bundles )
            Hide
            nfreese Nowlan Freese added a comment - - edited

            It seems like remote services were part of an attempt to remotely log user errors - see IGBF-1072. It is unclear if this was working in a production manner, i.e., were we ever collecting these logs, or was this only ever demonstrated?

            https://bitbucket.org/lorainelab/integrated-genome-browser/commits/bb107dbbd29e45081f062e821c7e8ecbe32c9b36
            https://bitbucket.org/lorainelab/integrated-genome-browser/commits/9cd9ab1173368f42711c53978ad4464caea65253
            https://bitbucket.org/lorainelab/integrated-genome-browser/commits/d1bda3625bcf0eb057a7e788edef3572d6a81e5a

            Show
            nfreese Nowlan Freese added a comment - - edited It seems like remote services were part of an attempt to remotely log user errors - see IGBF-1072 . It is unclear if this was working in a production manner, i.e., were we ever collecting these logs, or was this only ever demonstrated? https://bitbucket.org/lorainelab/integrated-genome-browser/commits/bb107dbbd29e45081f062e821c7e8ecbe32c9b36 https://bitbucket.org/lorainelab/integrated-genome-browser/commits/9cd9ab1173368f42711c53978ad4464caea65253 https://bitbucket.org/lorainelab/integrated-genome-browser/commits/d1bda3625bcf0eb057a7e788edef3572d6a81e5a
            Hide
            nfreese Nowlan Freese added a comment -

            Looking at this commit, it appears there were a lot of dependencies added for this remote logging. Can many/all of these be removed if we are not using the remote logging?

            Show
            nfreese Nowlan Freese added a comment - Looking at this commit , it appears there were a lot of dependencies added for this remote logging. Can many/all of these be removed if we are not using the remote logging?
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Removed:

            • org.apache.felix.gogo.runtime
            • org.apache.felix.gogo.shell
            • org.apache.felix.gogo.command

            All bundles active, no errors in IGB.

            Show
            nfreese Nowlan Freese added a comment - - edited Removed: org.apache.felix.gogo.runtime org.apache.felix.gogo.shell org.apache.felix.gogo.command All bundles active, no errors in IGB.
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Branch: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-3382

            I've removed a number of dependencies related to the remote error logging discussed in IGBF-1072 and in this commit. IGB appears to be running normally, though additional testing is needed. It may be possible to remove additional dependencies.

            Show
            nfreese Nowlan Freese added a comment - - edited Branch: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-3382 I've removed a number of dependencies related to the remote error logging discussed in IGBF-1072 and in this commit . IGB appears to be running normally, though additional testing is needed. It may be possible to remove additional dependencies.
            Hide
            nfreese Nowlan Freese added a comment -

            It looks like part of the error reporting was commented out in IGBF-2056 in this commit.

            Show
            nfreese Nowlan Freese added a comment - It looks like part of the error reporting was commented out in IGBF-2056 in this commit .
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Branch: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-3382

            I have commented out the org.lorainelab.igb.error.reporter.manager module in the project pom. The org.lorainelab.igb.error.reporter.manager code is still within IGB, but should not build as the module has been commented out. Dependencies have been removed from the project/main/shared poms, as well as version variables.

            I have squashed commits and rebased onto main-JDK8. Everything in IGB seems to be working.

            To test,

            1. Fetch my branch IGBF-3382 (my bitbucket account is out of pipeline minutes).
            2. Build IGB (mvn clean install)
            3. Start IGB, look for any errors in the log.
            4. Launch the App Manager (Plug-ins tab) in IGB, check that you can install an app
            5. Open a genome and load some data, i.e. check that IGB appears to be functioning correctly in a general sense
            6. In a web browser, go to http://localhost:7080/system/console/bundles and check to see that all bundles are active and that no bundles are listed as installed or fragments.
            Show
            nfreese Nowlan Freese added a comment - - edited Branch: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-3382 I have commented out the org.lorainelab.igb.error.reporter.manager module in the project pom. The org.lorainelab.igb.error.reporter.manager code is still within IGB, but should not build as the module has been commented out. Dependencies have been removed from the project/main/shared poms, as well as version variables. I have squashed commits and rebased onto main-JDK8. Everything in IGB seems to be working. To test, Fetch my branch IGBF-3382 (my bitbucket account is out of pipeline minutes). Build IGB (mvn clean install) Start IGB, look for any errors in the log. Launch the App Manager (Plug-ins tab) in IGB, check that you can install an app Open a genome and load some data, i.e. check that IGB appears to be functioning correctly in a general sense In a web browser, go to http://localhost:7080/system/console/bundles and check to see that all bundles are active and that no bundles are listed as installed or fragments.
            Hide
            kgopu Kaushik Gopu added a comment -

            Fetched IGBF-3382 and tested basic functionalities, all bundles are in resolved state and logs are clean. it is good to go.

            Show
            kgopu Kaushik Gopu added a comment - Fetched IGBF-3382 and tested basic functionalities, all bundles are in resolved state and logs are clean. it is good to go.
            Show
            nfreese Nowlan Freese added a comment - Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/935
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Merged. Main branch installers are built and deployed to bioviz.org and the team repository downloads section.

            Show
            ann.loraine Ann Loraine added a comment - - edited Merged. Main branch installers are built and deployed to bioviz.org and the team repository downloads section.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Testing:

            • Installed the main-JDK8 branch, downloaded from the "early access" section of the Web site.
            • IGB launched as expected.
            • Loaded latest human genome by clicking the Mona Lisa image on the home screen
            • Open the felix Web console and entered user name admin password admin to view the installed bundles
            • Observed that all bundles have "Status" of "active"
            • Observed there were no errors in the Consle

            Moving to Done.

            Show
            ann.loraine Ann Loraine added a comment - - edited Testing: Installed the main-JDK8 branch, downloaded from the "early access" section of the Web site. IGB launched as expected. Loaded latest human genome by clicking the Mona Lisa image on the home screen Open the felix Web console and entered user name admin password admin to view the installed bundles Observed that all bundles have "Status" of "active" Observed there were no errors in the Consle Moving to Done.

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: