Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3383

Edit PCA plot markdown and commit knitted file

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Dr. Loraine comments:

      • Figure out a nicer way to present the result from sanity checking. Currently, the message letting the reader know that the test passed does not fit on the page, making it harder to follow what is going on. See: p. 3, Muday-DESeq-PCA-Plots.pdf
      • First two words of the section of text appearing after the plot are confusing. It says: "The following plot.." suggesting the plot will be after this text. But the plot is actually appearing before the text, not after it. However, there is only one plot, so it's obvious what the text is talking about.
      • To me, this statement describing part "A" sounds nonsensical: "We also see that over a longer duration of time that there is even more significant variance between the samples." I see filled shapes spread about evenly across the two "slash"-shaped clusters. There is no such trend. Also, I don't think there is something such as "significant variance" in the statistical sense. Maybe you mean to say: "a lot" ?
      • Regarding "B": I agree with the statement made about temperature. I recommend wording it a little differently to refer back to the image itself a bit more. How about: "PC1 cleanly separates points into two visually obvious groups, one containing only earlier-stage sample points and the second containing only-later-stage points."
      • Regarding "C": I agree, there's no trend here. There are two, maybe three clusters, plus a singleton. Not obvious trends are there with respect to any of the variables examined. The current statement: "C) The OE3 genotype was an analysis of just OE3 samples and had no clear indication of clustering or separation of points except for maybe a little at 75 minutes." is correct. But I think you should change the word "just" to "only," or, better yet, say "This plot and the code used to produce it included OE3 genotype samples only." Also, we can easily check this is true by looking at the included code.
      • Regarding "D": There's an obvious visual separation between the treatment (heat stress) samples and the control (no-heat stress sample) in the PC2 dimension. There is also a clear grouping based on early-versus-later sample points in the PC1 dimension. Editorial comment: feel "D" is the most exciting image.
      • This statement again needs to be connected to the plot itself: "The ARE genotype has the largest variation out of all PCA plots and was analyzed with just ARE samples." Why do you say this about variance? How can the reader make the same conclusion about variance for themselves. What do they need to look at in the image? Explain this better and talk about what it means in the Discussion. Recall that the true "result" here is your observation about what the plot looks like.

      Comments on the Discussion:

      • First sentence is just filler. Remove it.
      • Second sentence has a lot of filler words. Reword it to remove unnecessary words. Change: "The goal was to answer these questions for the experiment to be successful:" to "Question (or questions) this Markdown aims to answer:"
      • There are a lot of things an author can do with a Discussion, but the ultimate goal should be the same in each case: Explain the Results.
      • There are a lot of choices about how to organize a Discussion section. Here are some:
      • Re-list the questions from the Introduction.
      • Edit by including one or two paragraphs following each question stating the answer to the question, and evidence. Interleave answers so that each re-stated question is followed by its answer and evidence for the answer.
      • Then list the questions, one-by-one, and say what the answer is, using the Results.
      • If the question is: "Was the experiment successful" and you have arrived at an answer to this question, you have to explain it more.
        I feel it is too vague, anyway.

      Suggestion: Read the comments and then spend an afternoon or a couple of hours to make some improvements. If you like it better, submit a new PR. If you don't, we can close this.

      As far as I am concerned, I feel I can look at the plots and come to my own conclusions about them. I don't need a Markdown to explain it to me, because I can read code and understand it, generally. Someone else might not, however. I would recommend investing at least another half-day in making improvements, but not much more, unless Molly Davis thinks more or less is needed.

        Attachments

          Issue Links

            Activity

            Show
            Mdavis4290 Molly Davis added a comment - Pull request : https://bitbucket.org/hotpollen/flavonoid-rnaseq/pull-requests/22
            Hide
            ann.loraine Ann Loraine added a comment -

            Changes are merged.

            Suggestions on how to test:

            • Using your own system, build Muday-DESeq-PCA.Rmd to create a new file Muday-DESeq-PCA.pdf. Install dependencies as needed. Likely the most obnoxious one will be the PDF generator. Ask MD for help if required.
            • Compare content in your newly built Muday-DESeq-PCA.pdf to content of Muday-DESeq-PCA.pdf from commit f49ae22. They should be close.

            attn: [~molly] Please add additional testing notes as you see fit.

            Show
            ann.loraine Ann Loraine added a comment - Changes are merged. Suggestions on how to test: Using your own system, build Muday-DESeq-PCA.Rmd to create a new file Muday-DESeq-PCA.pdf. Install dependencies as needed. Likely the most obnoxious one will be the PDF generator. Ask MD for help if required. Compare content in your newly built Muday-DESeq-PCA.pdf to content of Muday-DESeq-PCA.pdf from commit f49ae22. They should be close. attn: [~molly] Please add additional testing notes as you see fit.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            change requests:

            • Please delete this sentence: "The following PCA plots are combined onto one figure for easier visualization and contain colors that are colorblind safe."
            • Please investigate: What code is making "Muday-144-Combined-PCA-Plots.pdf" ? Was this from an earlier version of this script, a version that is no longer current? Is it no longer necessary? If yes, just go ahead and remove it. If we do need to keep it around, let's make a new ticket to track the additional work required to investigate further
            • The title shown in the Markdown is not very user-friendly because it uses our internal jargon "PCA Plot Muday lab 72_F3H_PollenTube Data" I recommend a title that summarize the major finding of the report. For example, maybe this?
              "Principal components analysis separates RNA-Seq samples by experimental variables"
            • Knit the Markdown and add the PDF to the repository in the next iteration please. I think it is ready now
            Show
            ann.loraine Ann Loraine added a comment - - edited change requests: Please delete this sentence: "The following PCA plots are combined onto one figure for easier visualization and contain colors that are colorblind safe." Please investigate: What code is making "Muday-144-Combined-PCA-Plots.pdf" ? Was this from an earlier version of this script, a version that is no longer current? Is it no longer necessary? If yes, just go ahead and remove it. If we do need to keep it around, let's make a new ticket to track the additional work required to investigate further The title shown in the Markdown is not very user-friendly because it uses our internal jargon "PCA Plot Muday lab 72_F3H_PollenTube Data" I recommend a title that summarize the major finding of the report. For example, maybe this? "Principal components analysis separates RNA-Seq samples by experimental variables" Knit the Markdown and add the PDF to the repository in the next iteration please. I think it is ready now
            Hide
            Mdavis4290 Molly Davis added a comment - - edited

            Branch: https://bitbucket.org/mdavis4290/molly3-flavonoid-rnaseq/branch/IGBF-3383d

            Note: The code is now showing in the markdown of how "Muday-144-Combined-PCA-Plots.pdf" is made. The pdf file contains just the plots so the collaborators have a clear image of the pca plots that can be used in papers.

            Show
            Mdavis4290 Molly Davis added a comment - - edited Branch : https://bitbucket.org/mdavis4290/molly3-flavonoid-rnaseq/branch/IGBF-3383d Note: The code is now showing in the markdown of how "Muday-144-Combined-PCA-Plots.pdf" is made. The pdf file contains just the plots so the collaborators have a clear image of the pca plots that can be used in papers.
            Show
            Mdavis4290 Molly Davis added a comment - Pull Request : https://bitbucket.org/hotpollen/flavonoid-rnaseq/pull-requests/23

              People

              • Assignee:
                Mdavis4290 Molly Davis
                Reporter:
                Mdavis4290 Molly Davis
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: