Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 6, Fall 7
Description
If a user running an unrecognized browser accesses IGB installer download pages, the "download" button does not appear.
On the Downloads page (for the released version of IGB), a slightly cryptic link appears "Other ways to download IGB" in more or less the spot the button would be.
On the "Early Access page" (for main-JDK8 branch latest installer build), a link appears that reads "Click here for the released and tested version of IGB."
It would be better if some other behavior could be developed that would be less confusing to users.
For testing, see IGBF-3385 comment for how to use Chrome Developer Tools to change your user-agent and observe the above behavior.
Attachments
Issue Links
- relates to
-
IGBF-3388 Add text bioviz.org about early access not being notarized
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Labels | Beginner |
| Rank | Ranked higher |
Currently, we determine the user agent and then remove the d-none class (which hides the button) for that button. If the user agent doesn't match mac/windows/linux then all of the buttons remain hidden. We could add a fourth button/class so that if the user agent isn't mac/windows/linux we display some kind of message that we do not support their current operating system, or we only support mac/windows/linux.
| Assignee | Paige Kulzer [ pkulzer ] |
| Sprint | Fall 6 [ 229 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I've added a warning message to both the Downloads and Early Downloads pages that triggers when the user agent is unrecognized. See attached for an example of how that looks.
Branch: https://bitbucket.org/pkulzer-lorainelab/bioviz/branch/IGBF-3397
| Attachment | warning-unrecognized-useragent.png [ 18954 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Sprint | Fall 6 [ 229 ] | Fall 6, Fall 7 [ 229, 230 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Nowlan Freese noticed an issue during testing where the new warning message popped up when the Windows installer was being displayed. I've fixed this issue, and I've also made the warning message itself more clear with a link to the other downloads page.
An additional issue is what the expected behavior should be if the user agent is unknown or not supported on the early access downloads page. Showing nothing or a warning may be confusing to a user as no options would be present. I'm also imagining a scenario where a user on mac/windows/linux is using a browser that hides there user agent. They would see no option to download an early access installer. I think we should by default show all three installer options for the early access page. The assumption is that if a user chooses the early access IGB installer they are advanced enough to know what operating system they should choose.
I've updated the commit to forgo a warning on the early access installer page in favor of showing all three installer options by default.
Ready for review!
Code looks good and the download and early access pages are working as expected.
Ready for PR
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
PR is merged. New code is deployed to bioviz.org. Ready for testing.
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Tested on Chrome.
Downloads page shows the correct installer for the user agent. If user agent is unknown or not supported then it shows a notification that installers for Mac, Windows, and Linux are available and it includes a link to the otherDownloads page.
Early Access page shows the three installer buttons for Mac, Windows, Linux.
All buttons appeared to be working and downloaded installers.
Closing ticket.
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Attn: Nowlan Freese
Adding this to the backlog with label "Beginner" for new joiners to work on.