Details

      Description

      Now that all declarative services in IGB has been migrated to osgi.annotations as of IGBF-3414, the next step to migrate the project J11 requires maven-bundleplugin to be updated.

        Attachments

          Issue Links

            Activity

            Show
            nfreese Nowlan Freese added a comment - Branch: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-3431
            Hide
            nfreese Nowlan Freese added a comment - - edited

            I have rebased 3431 onto main-JDK8 for testing. I can find no issues when running my branch through the jar file, all bundles are listed as active in the felix web console. However, when I run the branch through the debugger in Netbeans, the org.osgi.service.component.annotations bundle is listed as installed. Version 1.3 of org.osgi.service.component.annotations must be set to provided (possibly also compile) as it cannot be set to runtime. This may be what is causing the bundle to be listed as installed in debug mode, but I am not sure. However, I have been using debug mode extensively, and have come across no issues. Apps install and run normally, and all other IGB functionality appears to be working.

            I suggest that we merge IGBF-3431 with main-JDK8-r6. It may be possible to resolve/fix the issue with version 1.3 of org.osgi.service.component.annotations in the future, but at this time everything in IGB appears to be working, and this will allow us to proceed with the Java 11 work.

            Show
            nfreese Nowlan Freese added a comment - - edited I have rebased 3431 onto main-JDK8 for testing. I can find no issues when running my branch through the jar file, all bundles are listed as active in the felix web console. However, when I run the branch through the debugger in Netbeans, the org.osgi.service.component.annotations bundle is listed as installed. Version 1.3 of org.osgi.service.component.annotations must be set to provided (possibly also compile) as it cannot be set to runtime. This may be what is causing the bundle to be listed as installed in debug mode, but I am not sure. However, I have been using debug mode extensively, and have come across no issues. Apps install and run normally, and all other IGB functionality appears to be working. I suggest that we merge IGBF-3431 with main-JDK8-r6. It may be possible to resolve/fix the issue with version 1.3 of org.osgi.service.component.annotations in the future, but at this time everything in IGB appears to be working, and this will allow us to proceed with the Java 11 work.
            Hide
            karthik Karthik Raveendran added a comment -

            After including these changes in main-JDK8-r6, I tested it with no errors.

            Show
            karthik Karthik Raveendran added a comment - After including these changes in main-JDK8-r6, I tested it with no errors.
            Show
            nfreese Nowlan Freese added a comment - [~aloraine] - Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/949
            Hide
            nfreese Nowlan Freese added a comment -

            Tested using main-JDK8.dmg installer on Mac. IGB installed and ran correctly.

            Closing ticket.

            Show
            nfreese Nowlan Freese added a comment - Tested using main-JDK8.dmg installer on Mac. IGB installed and ran correctly. Closing ticket.

              People

              • Assignee:
                karthik Karthik Raveendran
                Reporter:
                karthik Karthik Raveendran
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: