Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
Description
- Update Protannot to use new OSGi r6 annotations.
- Update Maven Bundle plugin to 5.1.9.
- Make a separate commit for each change above.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | Update | Update protannot for new r6 annotations. |
| Assignee | Ann Loraine [ aloraine ] | Kaushik Gopu [ kgopu ] |
| Epic Link |
|
| Story Points | 1 | |
| Sprint | Fall 1 - Sep 5 [ 82 ] |
| Description |
* Update Protannot to use new OSGi r6 annotations.
* Update Maven Bundle plugin to 5.1.9. |
| Description |
* Update Protannot to use new OSGi r6 annotations.
* Update Maven Bundle plugin to 5.1.9. |
* Update Protannot to use new OSGi r6 annotations.
* Update Maven Bundle plugin to 5.1.9. * Make a separate commit for each change above. |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Hide
Kaushik Gopu
added a comment - - edited
Permalink
- Updated protannot for new r6 annotations. pull this branch for testing.
- The following changes includes: protannot now uses OSGI r6 declarative services and upgraded maven-bundle-plugin to 5.1.9
- Ran protannot for a genome, no issues were encountered during and after the scan.
- Moving to first level review
Show
Kaushik Gopu
added a comment - - edited
Updated protannot for new r6 annotations. pull this branch for testing.
The following changes includes: protannot now uses OSGI r6 declarative services and upgraded maven-bundle-plugin to 5.1.9
Ran protannot for a genome, no issues were encountered during and after the scan.
Moving to first level review
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
This ticket is on hold while IGBF-3431 testing continues.
| Sprint | Fall 1 - Sep 5 [ 82 ] |
| Sprint | Fall 6 [ 182 ] |
| Assignee | Kaushik Gopu [ kgopu ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Tested on Mac
Testing on main-JDK8 9.1.12
- Downloaded Kaushik's IGBF-3433 branch.
- I changed the version to 9.1.5 as the current master branch version of ProtAnnot is at 9.1.4.
- I was able to build Kaushik's branch, install it in IGB 9.1.12 (main-JDK8), and successfully run ProtAnnot.
Testing on IGB release 9.1.10
- ProtAnnot from Kaushik's branch was not able to work on IGB release 9.1.10 as there was a resolver error.
Conclusion:
The current version of ProtAnnot (9.1.4) works on both main-JDK8 (IGB 9.1.12) and IGB release 9.1.10. Further investigation into the error observed on IGB 9.1.10 when installing the new version of ProtAnnot may be warranted as it could help us identify potential OSGI issues. However, at this time I don't see a reason to upgrade protannot to the new R6 annotations.
This may be looking at in the future, but for the moment I am moving this ticket to the backlog.
| Assignee | Nowlan Freese [ nfreese ] | Kaushik Gopu [ kgopu ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Sprint | Fall 6 [ 182 ] |
This ticket has been superseded by IGBF-3518.
Closing ticket.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |