Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 8, Spring 1, Spring 2, Spring 3, Spring 4, Spring 5, Spring 6
Description
Task: Update SNP Converter for JDK21.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1908 [ 17998 ] |
| Status | To-Do [ 10305 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Accepted new branch to the team repository.
Built the new jar.
New version is available for testing in the new main-JDK21 version of IGB.
Add the following directory to IGB as a bundle repository and attempt to install in the usual way.
https://bitbucket.org/lorainelab/snp-file-converter/downloads/
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Sprint | Fall 8 [ 184 ] | Fall 8, Spring 1 [ 184, 185 ] |
| Rank | Ranked higher |
| Sprint | Fall 8, Spring 1 [ 184, 185 ] | Fall 8, Spring 1, Spring 2 [ 184, 185, 186 ] |
| Rank | Ranked higher |
| Sprint | Fall 8, Spring 1, Spring 2 [ 184, 185, 186 ] | Fall 8, Spring 1, Spring 2, Spring 3 [ 184, 185, 186, 187 ] |
| Rank | Ranked higher |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested on Mac with installed main-JDK21-with-javafx-no-theme branch of IGB.
Was able to add and start the SNP Converter in IGB using the App Manager.
Note that the branch with the changes currently in bitbucket is IGB_10_Alignment (not master). The bitbucket-pipeline is also pointing at hillrunner2008/igb-maven-install4j:I4J10-jre-21.0.1 whereas we are now using lorainelab/igb-maven-install4j:I4J10-jre-21.0.1-21.0.0 to build IGB, though that may change depending on IGBF-3588.
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Sprint | Fall 8, Spring 1, Spring 2, Spring 3 [ 184, 185, 186, 187 ] | Fall 8, Spring 1, Spring 2, Spring 3, Spring 4 [ 184, 185, 186, 187, 188 ] |
| Rank | Ranked higher |
| Sprint | Fall 8, Spring 1, Spring 2, Spring 3, Spring 4 [ 184, 185, 186, 187, 188 ] | Fall 8, Spring 1, Spring 2, Spring 3, Spring 4, Spring 5 [ 184, 185, 186, 187, 188, 189 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
PR is merged. Ready for next steps.
attn: Nowlan Freese
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Tested on Mac, Windows, and Linux from https://bitbucket.org/lorainelab/quickload-saver/downloads/
Final step: release to IGB App Store.
| Sprint | Fall 8, Spring 1, Spring 2, Spring 3, Spring 4, Spring 5 [ 184, 185, 186, 187, 188, 189 ] | Fall 8, Spring 1, Spring 2, Spring 3, Spring 4, Spring 5, Spring 6 [ 184, 185, 186, 187, 188, 189, 190 ] |
| Rank | Ranked higher |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
To do: remove upper bound on IGB version.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Commit: https://bitbucket.org/nfreese/snp-file-converter/commits/7afab5bc13b7fc074e6c9d5b4575c3e6d1eed723
PR: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/13
Removed upper bound of IGB requirement and tested on IGB version "11".
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Ann Loraine [ aloraine ] |
PR is merged.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
SNP Converter 10.0.0 has been released to the app store: https://apps.bioviz.org/apps/23andMe-snp-converter/#
Tested on Mac on IGB 10.0.0 as well as a development version of IGB with the IGB version set to 11. I was able to install and run SNP Converter from the app store or app manager.
Closing ticket.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Pull request: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/11
Note that the pull request is not aimed at the master branch, we will need to merge it to master.