Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Task: Update SNP Converter for JDK21.

        Attachments

          Issue Links

            Activity

            Hide
            nfreese Nowlan Freese added a comment -

            Pull request: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/11

            Note that the pull request is not aimed at the master branch, we will need to merge it to master.

            Show
            nfreese Nowlan Freese added a comment - Pull request: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/11 Note that the pull request is not aimed at the master branch, we will need to merge it to master.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Accepted new branch to the team repository.
            Built the new jar.
            New version is available for testing in the new main-JDK21 version of IGB.
            Add the following directory to IGB as a bundle repository and attempt to install in the usual way.
            https://bitbucket.org/lorainelab/snp-file-converter/downloads/

            Show
            ann.loraine Ann Loraine added a comment - - edited Accepted new branch to the team repository. Built the new jar. New version is available for testing in the new main-JDK21 version of IGB. Add the following directory to IGB as a bundle repository and attempt to install in the usual way. https://bitbucket.org/lorainelab/snp-file-converter/downloads/
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on Mac with installed main-JDK21-with-javafx-no-theme branch of IGB.

            Was able to add and start the SNP Converter in IGB using the App Manager.

            Note that the branch with the changes currently in bitbucket is IGB_10_Alignment (not master). The bitbucket-pipeline is also pointing at hillrunner2008/igb-maven-install4j:I4J10-jre-21.0.1 whereas we are now using lorainelab/igb-maven-install4j:I4J10-jre-21.0.1-21.0.0 to build IGB, though that may change depending on IGBF-3588.

            Show
            nfreese Nowlan Freese added a comment - Tested on Mac with installed main-JDK21-with-javafx-no-theme branch of IGB. Was able to add and start the SNP Converter in IGB using the App Manager. Note that the branch with the changes currently in bitbucket is IGB_10_Alignment (not master). The bitbucket-pipeline is also pointing at hillrunner2008/igb-maven-install4j:I4J10-jre-21.0.1 whereas we are now using lorainelab/igb-maven-install4j:I4J10-jre-21.0.1-21.0.0 to build IGB, though that may change depending on IGBF-3588 .
            Show
            nfreese Nowlan Freese added a comment - Pull request: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/12
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged. Ready for next steps.

            attn: Nowlan Freese

            Show
            ann.loraine Ann Loraine added a comment - PR is merged. Ready for next steps. attn: Nowlan Freese
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on Mac, Windows, and Linux from https://bitbucket.org/lorainelab/quickload-saver/downloads/

            Final step: release to IGB App Store.

            Show
            nfreese Nowlan Freese added a comment - Tested on Mac, Windows, and Linux from https://bitbucket.org/lorainelab/quickload-saver/downloads/ Final step: release to IGB App Store.
            Hide
            nfreese Nowlan Freese added a comment -

            To do: remove upper bound on IGB version.

            Show
            nfreese Nowlan Freese added a comment - To do: remove upper bound on IGB version.
            Show
            nfreese Nowlan Freese added a comment - Commit: https://bitbucket.org/nfreese/snp-file-converter/commits/7afab5bc13b7fc074e6c9d5b4575c3e6d1eed723 PR: https://bitbucket.org/lorainelab/snp-file-converter/pull-requests/13 Removed upper bound of IGB requirement and tested on IGB version "11".
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged.
            Hide
            nfreese Nowlan Freese added a comment -

            SNP Converter 10.0.0 has been released to the app store: https://apps.bioviz.org/apps/23andMe-snp-converter/#

            Tested on Mac on IGB 10.0.0 as well as a development version of IGB with the IGB version set to 11. I was able to install and run SNP Converter from the app store or app manager.

            Closing ticket.

            Show
            nfreese Nowlan Freese added a comment - SNP Converter 10.0.0 has been released to the app store: https://apps.bioviz.org/apps/23andMe-snp-converter/# Tested on Mac on IGB 10.0.0 as well as a development version of IGB with the IGB version set to 11. I was able to install and run SNP Converter from the app store or app manager. Closing ticket.

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: