Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3530

Change the negative log value y-axis max

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Change the negative log value y-axis to have a max of 20 after being transformed and make the higher numbers also 20 so that they are at the ceiling of the plot. James Pease recommends this so the plot looks more like a volcano.

      Files:

      • FindControlVsStressDEGenes-SL4-DESeq2.Rmd
      • StatFunctions.R

      Note: These changes need to be implemented with all of the other FindControlVsStress & MakeCustomVolcanoPlots markdowns.

        Attachments

          Issue Links

            Activity

            Hide
            Mdavis4290 Molly Davis added a comment -

            Branch: https://bitbucket.org/mdavis4290/molly5-flavonoid-rnaseq/branch/IGBF-3530

            Files to review:

            • MakeCustomVolcanoPlots.Rmd
            • MakeCustomVolcanoPlots.pdf
            • CustomVolcanoPlots-SL4-DeSeq2.pdf

            Review:

            • Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis
            • Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling
            • Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish

            Reviewer: Robert Reid

            Show
            Mdavis4290 Molly Davis added a comment - Branch : https://bitbucket.org/mdavis4290/molly5-flavonoid-rnaseq/branch/IGBF-3530 Files to review : MakeCustomVolcanoPlots.Rmd MakeCustomVolcanoPlots.pdf CustomVolcanoPlots-SL4-DeSeq2.pdf Review : Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish Reviewer: Robert Reid
            Hide
            robofjoy Robert Reid added a comment -

            Tested out the rmd file in my own environment and it looks to be working correctly.

            The y-axes are all correct at "20", aka 1e-20.

            Screen shot of what I got. Matches the PDF file.

            I think this is ready to go!

            Show
            robofjoy Robert Reid added a comment - Tested out the rmd file in my own environment and it looks to be working correctly. The y-axes are all correct at "20", aka 1e-20. Screen shot of what I got. Matches the PDF file. I think this is ready to go!
            Show
            Mdavis4290 Molly Davis added a comment - - edited PR : https://bitbucket.org/hotpollen/flavonoid-rnaseq/pull-requests/39 Ann Loraine
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged. Ready for testing.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged. Ready for testing.
            Hide
            Mdavis4290 Molly Davis added a comment - - edited

            Testing:

            Files to test in flavonoid repo:
            MakeCustomVolcanoPlots.Rmd
            MakeCustomVolcanoPlots.pdf
            CustomVolcanoPlots-SL4-DeSeq2.pdf

            • Run and knit MakeCustomVolcanoPlots.Rmd markdown to ensure it works properly
            • Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis
            • Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling
            • Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish

            Notes: Ran into no issues running the markdown and the knitted pdf looks fine. Only the y-axis is changed and the ceiling max is set to 20. The plots pdf looks good and more improvements for point spacing and coloration have been made into individual tickets. IGBF-3562 & IGBF-3558

            Next step: Inform Muday lab of changes and next steps

            Moving ticket to done!

            Show
            Mdavis4290 Molly Davis added a comment - - edited Testing : Files to test in flavonoid repo : MakeCustomVolcanoPlots.Rmd MakeCustomVolcanoPlots.pdf CustomVolcanoPlots-SL4-DeSeq2.pdf Run and knit MakeCustomVolcanoPlots.Rmd markdown to ensure it works properly Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish Notes : Ran into no issues running the markdown and the knitted pdf looks fine. Only the y-axis is changed and the ceiling max is set to 20. The plots pdf looks good and more improvements for point spacing and coloration have been made into individual tickets. IGBF-3562 & IGBF-3558 Next step : Inform Muday lab of changes and next steps Moving ticket to done!

              People

              • Assignee:
                Mdavis4290 Molly Davis
                Reporter:
                Mdavis4290 Molly Davis
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: