Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3530

Change the negative log value y-axis max

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Change the negative log value y-axis to have a max of 20 after being transformed and make the higher numbers also 20 so that they are at the ceiling of the plot. James Pease recommends this so the plot looks more like a volcano.

      Files:

      • FindControlVsStressDEGenes-SL4-DESeq2.Rmd
      • StatFunctions.R

      Note: These changes need to be implemented with all of the other FindControlVsStress & MakeCustomVolcanoPlots markdowns.

        Attachments

          Issue Links

            Activity

            Mdavis4290 Molly Davis created issue -
            Mdavis4290 Molly Davis made changes -
            Field Original Value New Value
            Epic Link IGBF-3446 [ 22548 ]
            Mdavis4290 Molly Davis made changes -
            Link This issue relates to IGBF-3520 [ IGBF-3520 ]
            Mdavis4290 Molly Davis made changes -
            Description Change the negative log value y-axis to have a max of 20 after being transformed and make the higher numbers also 20 so that are at the ceiling of the plot. James Pease recommends this so the plot looks more like a volcano.

            Files:
            * FindControlVsStressDEGenes-SL4-DESeq2.Rmd
            * StatFunctions.R

            Note: These changes need to be implemented with all of the other FindControlVsStress & MakeCustomVolcanoPlots markdowns.
            Change the negative log value y-axis to have a max of 20 after being transformed and make the higher numbers also 20 so that they are at the ceiling of the plot. James Pease recommends this so the plot looks more like a volcano.

            Files:
            * FindControlVsStressDEGenes-SL4-DESeq2.Rmd
            * StatFunctions.R

            Note: These changes need to be implemented with all of the other FindControlVsStress & MakeCustomVolcanoPlots markdowns.
            ann.loraine Ann Loraine made changes -
            Sprint Fall 8 [ 184 ] Fall 8, Spring 1 [ 184, 185 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            An idea:

            Since our lab scientists rely a lot on volcano style plots to understand their data, we ought to invest in making these plots easier for them to create and modify, using output from differential expression analyses. We could make the scientists an R Shiny app for this, then deploy it on our own infrastructure or using a trustworthy hosting service like https://shiny.posit.co/r/deploy.html.

            I found a github repo with what looks like a good starting point for an interactive volcano plot R Shiny app - https://github.com/FredHutch/interactiveVolcano

            Please note: I have not tried to run this app. It might not be possible due to bit rot, as the last commit was three years ago.

            Regarding the "squash the upper points" variation on a volcano plot:

            • Are there examples of such plots that have been published ?
            • Is this variation part of the volcano plot "specification" ?
            • Who invented volcano plots, and why ?
            Show
            ann.loraine Ann Loraine added a comment - - edited An idea: Since our lab scientists rely a lot on volcano style plots to understand their data, we ought to invest in making these plots easier for them to create and modify, using output from differential expression analyses. We could make the scientists an R Shiny app for this, then deploy it on our own infrastructure or using a trustworthy hosting service like https://shiny.posit.co/r/deploy.html . I found a github repo with what looks like a good starting point for an interactive volcano plot R Shiny app - https://github.com/FredHutch/interactiveVolcano Please note: I have not tried to run this app. It might not be possible due to bit rot, as the last commit was three years ago. Regarding the "squash the upper points" variation on a volcano plot: Are there examples of such plots that have been published ? Is this variation part of the volcano plot "specification" ? Who invented volcano plots, and why ?
            robofjoy Robert Reid made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            robofjoy Robert Reid added a comment -

            This is a great idea.
            I will explore the interactive Rshiny soonish!

            Rob

            Show
            robofjoy Robert Reid added a comment - This is a great idea. I will explore the interactive Rshiny soonish! Rob
            Hide
            ann.loraine Ann Loraine added a comment -

            Ann to tag the repository to indicate which version is associated with the submitted article. Rob will proceed with Molly to add the new "ceiling" changes to the "make volcano plots" Markdowns.

            Show
            ann.loraine Ann Loraine added a comment - Ann to tag the repository to indicate which version is associated with the submitted article. Rob will proceed with Molly to add the new "ceiling" changes to the "make volcano plots" Markdowns.
            ann.loraine Ann Loraine made changes -
            Assignee Robert Reid [ robertreid ] Ann Loraine [ aloraine ]
            Hide
            robofjoy Robert Reid added a comment -

            TODO as part of this ticket. To implement a small change to the volcano plot so that when plotting, the y-axis for p-value has a ceiling of 1e-20.
            Values above this number will still be plotted as 1e-20 and not just dissappear. If we simply set the y-axis max to 1e-20, we'd lose key information!!

            The one line code snippet that will change the ceiling of the Y-axis in the volcano plot method in "StatFunctions.R".
            d=results_table
            d$pvalue= ifelse(-log10(d$pvalue) < 20,d$pvalue,1e-20)

            Using the if-else function, this will check if the -log10 of the pvalue is less than 20. If it is, it remains the same. If it is GREATER than 20, the p-value gets converted to 1e-20 in the table.

            Show
            robofjoy Robert Reid added a comment - TODO as part of this ticket. To implement a small change to the volcano plot so that when plotting, the y-axis for p-value has a ceiling of 1e-20. Values above this number will still be plotted as 1e-20 and not just dissappear. If we simply set the y-axis max to 1e-20, we'd lose key information!! The one line code snippet that will change the ceiling of the Y-axis in the volcano plot method in "StatFunctions.R". d=results_table d$pvalue= ifelse(-log10(d$pvalue) < 20,d$pvalue,1e-20) Using the if-else function, this will check if the -log10 of the pvalue is less than 20. If it is, it remains the same. If it is GREATER than 20, the p-value gets converted to 1e-20 in the table.
            Hide
            robofjoy Robert Reid added a comment -

            Upon Molly's return, her and I will meet and implement this change into her code, test it and repo it !!

            Show
            robofjoy Robert Reid added a comment - Upon Molly's return, her and I will meet and implement this change into her code, test it and repo it !!
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Ann added new tag: TPC2023-PIRA-01149R1
            This is the manuscript identifier the journal (Plant Cell) assigned.
            The commit first made after the article was submitted adds the "manuscript received" email from the journal addressed to me. I think this is an automated email that gets sent out when an article gets accepted for review. So this seemed like a good way to mark the state of the repository as it existed then.

            Moving out of current sprint to await RR & MD next availability.

            Robert Reid
            Molly Davis

            Show
            ann.loraine Ann Loraine added a comment - - edited Ann added new tag: TPC2023-PIRA-01149R1 This is the manuscript identifier the journal (Plant Cell) assigned. The commit first made after the article was submitted adds the "manuscript received" email from the journal addressed to me. I think this is an automated email that gets sent out when an article gets accepted for review. So this seemed like a good way to mark the state of the repository as it existed then. Moving out of current sprint to await RR & MD next availability. Robert Reid Molly Davis
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-3540 [ IGBF-3540 ]
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 8, Spring 1 [ 184, 185 ] Fall 8 [ 184 ]
            Mdavis4290 Molly Davis made changes -
            Sprint Fall 8 [ 184 ] Fall 8, Spring 1 [ 184, 185 ]
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Mdavis4290 Molly Davis made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            Mdavis4290 Molly Davis added a comment -

            Branch: https://bitbucket.org/mdavis4290/molly5-flavonoid-rnaseq/branch/IGBF-3530

            Files to review:

            • MakeCustomVolcanoPlots.Rmd
            • MakeCustomVolcanoPlots.pdf
            • CustomVolcanoPlots-SL4-DeSeq2.pdf

            Review:

            • Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis
            • Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling
            • Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish

            Reviewer: Robert Reid

            Show
            Mdavis4290 Molly Davis added a comment - Branch : https://bitbucket.org/mdavis4290/molly5-flavonoid-rnaseq/branch/IGBF-3530 Files to review : MakeCustomVolcanoPlots.Rmd MakeCustomVolcanoPlots.pdf CustomVolcanoPlots-SL4-DeSeq2.pdf Review : Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish Reviewer: Robert Reid
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ] Robert Reid [ robertreid ]
            Mdavis4290 Molly Davis made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 8, Spring 1 [ 184, 185 ] Fall 8, Spring 1, Spring 2 [ 184, 185, 186 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            robofjoy Robert Reid made changes -
            Hide
            robofjoy Robert Reid added a comment -

            Tested out the rmd file in my own environment and it looks to be working correctly.

            The y-axes are all correct at "20", aka 1e-20.

            Screen shot of what I got. Matches the PDF file.

            I think this is ready to go!

            Show
            robofjoy Robert Reid added a comment - Tested out the rmd file in my own environment and it looks to be working correctly. The y-axes are all correct at "20", aka 1e-20. Screen shot of what I got. Matches the PDF file. I think this is ready to go!
            robofjoy Robert Reid made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            robofjoy Robert Reid made changes -
            Assignee Robert Reid [ robertreid ] Molly Davis [ molly ]
            Mdavis4290 Molly Davis made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            Show
            Mdavis4290 Molly Davis added a comment - - edited PR : https://bitbucket.org/hotpollen/flavonoid-rnaseq/pull-requests/39 Ann Loraine
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Mdavis4290 Molly Davis made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            Mdavis4290 Molly Davis made changes -
            Assignee Ann Loraine [ aloraine ]
            Mdavis4290 Molly Davis made changes -
            Link This issue relates to IGBF-3558 [ IGBF-3558 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged. Ready for testing.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged. Ready for testing.
            Mdavis4290 Molly Davis made changes -
            Assignee Molly Davis [ molly ]
            Hide
            Mdavis4290 Molly Davis added a comment - - edited

            Testing:

            Files to test in flavonoid repo:
            MakeCustomVolcanoPlots.Rmd
            MakeCustomVolcanoPlots.pdf
            CustomVolcanoPlots-SL4-DeSeq2.pdf

            • Run and knit MakeCustomVolcanoPlots.Rmd markdown to ensure it works properly
            • Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis
            • Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling
            • Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish

            Notes: Ran into no issues running the markdown and the knitted pdf looks fine. Only the y-axis is changed and the ceiling max is set to 20. The plots pdf looks good and more improvements for point spacing and coloration have been made into individual tickets. IGBF-3562 & IGBF-3558

            Next step: Inform Muday lab of changes and next steps

            Moving ticket to done!

            Show
            Mdavis4290 Molly Davis added a comment - - edited Testing : Files to test in flavonoid repo : MakeCustomVolcanoPlots.Rmd MakeCustomVolcanoPlots.pdf CustomVolcanoPlots-SL4-DeSeq2.pdf Run and knit MakeCustomVolcanoPlots.Rmd markdown to ensure it works properly Please check the changes to MakeCustomVolcanoPlots.Rmd and make sure it is just changing the y-axis Review the knitted MakeCustomVolcanoPlots.pdf and make sure each volcano plot has the 20 max ceiling and points higher than 20 are at the ceiling Review CustomVolcanoPlots-SL4-DeSeq2.pdf to ensure that the volcano plots are ready to show to muday lab and in the future publish Notes : Ran into no issues running the markdown and the knitted pdf looks fine. Only the y-axis is changed and the ceiling max is set to 20. The plots pdf looks good and more improvements for point spacing and coloration have been made into individual tickets. IGBF-3562 & IGBF-3558 Next step : Inform Muday lab of changes and next steps Moving ticket to done!
            Mdavis4290 Molly Davis made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            Mdavis4290 Molly Davis made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            Mdavis4290 Molly Davis made changes -
            Link This issue relates to IGBF-3570 [ IGBF-3570 ]

              People

              • Assignee:
                Mdavis4290 Molly Davis
                Reporter:
                Mdavis4290 Molly Davis
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: