[IGBF-3602] Investigate Flatlaf compatibility in IGB 10 for Windows - JIRA UNCC

Details

Type: Task
Status: To-Do (View Workflow)
Priority: Major
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Labels:
None

Story Points:
2
Epic Link:
Improve IGB for users
Sprint:
Spring 3, Spring 4, Spring 9

Description

Flatlaf seems to work with Mac and Linux but in Windows it throws an javax namespace error. This error is the reason why David created three different branches for IGB JDK21:
a) main-JDK21-with-javafx-no-theme
b) main-JDK21-with-javafx-lighttheme
c) main-JDK21-nojavafx-with-light-theme

Changing the javax namespace to jakarta in Flatlat library should work in this issue.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

flatlaf-JAKARTA-3.3.jar
851 kB
14/Feb/24 10:25 AM
flatlaf-jide-oss-JAKARTA-3.3.jar
41 kB
14/Feb/24 10:25 AM
transform_flatlaf.sh
0.7 kB
14/Feb/24 10:25 AM

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Karthik Raveendran added a comment - 14/Feb/24 10:30 AM

After changing the javafx namespace in flallaf libraries (see attached jar files and script), the project is building but the following error appears while running:

java.lang.NoClassDefFoundError: com/formdev/flatlaf/FlatDarkLaf
	at com.affymetrix.main.OSGiHandler.setLaf(OSGiHandler.java:91)
	at com.affymetrix.main.OSGiHandler.startOSGi(OSGiHandler.java:69)
	at com.affymetrix.main.Main.main(Main.java:30)
Caused by: java.lang.ClassNotFoundException: com.formdev.flatlaf.FlatDarkLaf
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 3 common frames omitted

The only place the flatlaf changes should be implemented seems to be OSGIHandler.java. However, the set laf method is very sensitive in both OSGIHandler as well as IGB.java. May need some time to play around with it.

Show

Karthik Raveendran added a comment - 14/Feb/24 10:30 AM After changing the javafx namespace in flallaf libraries (see attached jar files and script), the project is building but the following error appears while running: java.lang.NoClassDefFoundError: com/formdev/flatlaf/FlatDarkLaf at com.affymetrix.main.OSGiHandler.setLaf(OSGiHandler.java:91) at com.affymetrix.main.OSGiHandler.startOSGi(OSGiHandler.java:69) at com.affymetrix.main.Main.main(Main.java:30) Caused by: java.lang.ClassNotFoundException: com.formdev.flatlaf.FlatDarkLaf at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) at java.base/java.lang. ClassLoader .loadClass( ClassLoader .java:526) ... 3 common frames omitted The only place the flatlaf changes should be implemented seems to be OSGIHandler.java. However, the set laf method is very sensitive in both OSGIHandler as well as IGB.java. May need some time to play around with it.

Hide

Permalink

Karthik Raveendran added a comment - 27/Feb/24 10:43 AM - edited

Currently, testing dcnorris versions of flatlaf to check the errors there because one theory for the error was that the felix version is causing the error.
a) The previous theory is that the race condition was not met but moving around the installation and implementation of Flatlaf as the UIManager lookandfeel class did not work.
b) I also wonder if the jidesoft plaf is preventing flatlaf from getting implemented. I need to look into why and how we should use flatlaf-jide-oss.jar which is meant to prevent that.
c) Another theory, the name space change from javax to jakarta in flatlaf may not have been done well.

Show

Karthik Raveendran added a comment - 27/Feb/24 10:43 AM - edited Currently, testing dcnorris versions of flatlaf to check the errors there because one theory for the error was that the felix version is causing the error. a) The previous theory is that the race condition was not met but moving around the installation and implementation of Flatlaf as the UIManager lookandfeel class did not work. b) I also wonder if the jidesoft plaf is preventing flatlaf from getting implemented. I need to look into why and how we should use flatlaf-jide-oss.jar which is meant to prevent that. c) Another theory, the name space change from javax to jakarta in flatlaf may not have been done well.

Hide

Permalink

Ann Loraine added a comment - 07/Mar/24 11:47 AM

I think we can go ahead and close this. Based on what has been done thus far, it really seems like trying to use the library in IGB is error-prone and fragile. In that case, I think we should not use it, as the overhead of getting it to work is very high.

Can we go ahead and conclude that we will not use this library in IGB due to its fragility?

I would like to close this ticket, if you guys agree!

attn: Karthik Raveendran and Nowlan Freese

Show

Ann Loraine added a comment - 07/Mar/24 11:47 AM I think we can go ahead and close this. Based on what has been done thus far, it really seems like trying to use the library in IGB is error-prone and fragile. In that case, I think we should not use it, as the overhead of getting it to work is very high. Can we go ahead and conclude that we will not use this library in IGB due to its fragility? I would like to close this ticket, if you guys agree! attn: Karthik Raveendran and Nowlan Freese

Investigate Flatlaf compatibility in IGB 10 for Windows

Details

Description

Attachments

Attachments

Activity

People

Dates