Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3629

Change the Log to be uneditable by users in IGB

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Minor
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:

          Description

          Since at least IGB 9.1.4, users have been able to edit the Log in IGB and then are unable to reverse the changes they made.

          Example: I encountered an error while running a script in IGB 9.1.4 today, so I went to copy the error with Command+C but mistyped Shift+C. This changed the error I had highlighted in the Log to "C". I was then unable to reverse this edit with Command+Z, so I had to restart IGB and re-run my script just to reproduce that error again. This behavior was the same in IGB 10.0.0.

          Task: Make the IGB Log uneditable by users.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Comment for Paige Kulzer:

              • Previously I misunderstood this ticket. I thought it was talking about a local file, not the Log tab. Sorry about that! Yes, I agree that the text shown in the Log tab should not be editable.
              Show
              ann.loraine Ann Loraine added a comment - Comment for Paige Kulzer : Previously I misunderstood this ticket. I thought it was talking about a local file, not the Log tab. Sorry about that! Yes, I agree that the text shown in the Log tab should not be editable.
              Hide
              Permalink
              uchinta Udaya Chinta added a comment - - edited

              Started investigation on the issue. Going through the code flow to understand the changes related to the logs.

              Show
              uchinta Udaya Chinta added a comment - - edited Started investigation on the issue. Going through the code flow to understand the changes related to the logs.
              Hide
              Permalink
              uchinta Udaya Chinta added a comment -

              Below is the commit to make igb log uneditable.
              Commit : https://bitbucket.org/lorainelab_udaya/integrated-genome-browser/branch/IGBF-3629

              Show
              uchinta Udaya Chinta added a comment - Below is the commit to make igb log uneditable. Commit : https://bitbucket.org/lorainelab_udaya/integrated-genome-browser/branch/IGBF-3629
              Hide
              Permalink
              pkulzer Paige Kulzer added a comment -

              Code change is straightforward and makes sense - recommending pull request!

              Show
              pkulzer Paige Kulzer added a comment - Code change is straightforward and makes sense - recommending pull request!
              Hide
              Permalink
              uchinta Udaya Chinta added a comment -

              Thanks Paige Kulzer for reviewing the ticket .
              Pr submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1055

              Show
              uchinta Udaya Chinta added a comment - Thanks Paige Kulzer for reviewing the ticket . Pr submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1055
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              FYI: The commit message has the wrong Jira issue number. I merged it before I noticed

              Next time:

              • When reviewing, please check that the commit message contains the correct Jira issue number.
              • This matters because the team repository adds links back to our Jira site, making it easy to track how things have changed and why.
              Show
              ann.loraine Ann Loraine added a comment - FYI: The commit message has the wrong Jira issue number. I merged it before I noticed Next time: When reviewing, please check that the commit message contains the correct Jira issue number. This matters because the team repository adds links back to our Jira site, making it easy to track how things have changed and why.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              PR is merged and new installers are deployed to early access section of the web site.

              Show
              ann.loraine Ann Loraine added a comment - PR is merged and new installers are deployed to early access section of the web site.
              Hide
              Permalink
              sjagarap saideepthi jagarapu added a comment - - edited

              Tested main branch of igb repository locally, now the logs are not editable.
              The issue is resolved and now works as expected.
              Thus, moving this ticket to done

              Show
              sjagarap saideepthi jagarapu added a comment - - edited Tested main branch of igb repository locally, now the logs are not editable. The issue is resolved and now works as expected. Thus, moving this ticket to done

                People

                • Assignee:
                  uchinta Udaya Chinta
                  Reporter:
                  pkulzer Paige Kulzer
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: