Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3640

Add expand color by and Filter by to include the props

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      5
    • Sprint:
      Spring 5, Spring 6, Spring 7, Spring 8, Spring 9, Spring 10

      Description

      Situation: Many of the files provided by the UCSC REST API (see IGBF-3129) include additional coumns (see comments in IGBF-3598). These additional columns are added as "props" and can contain many different types of information.

      In IGB, if you right-click on a track there are options to "Color by..." or "Filter...". Some of the current options include values for Length, RGB, Score, Property. However, the values stored in the "props" are not included.

      Task: Investigate the possibility of enabling a user to use the "Color by..." or "Filter..." on the "props" values.

        Attachments

          Issue Links

            Activity

            Hide
            nfreese Nowlan Freese added a comment -

            Built and tested Sravani's branch locally on my Mac.

            Following the testing above, the additional properties show up for the appropriate files from UCSC REST. I am able to filter and color the data appropriately. If multiple tracks are selected, only the shared/common properties appear.

            Did code review with Sravani.

            Ready for pull request.

            Show
            nfreese Nowlan Freese added a comment - Built and tested Sravani's branch locally on my Mac. Following the testing above, the additional properties show up for the appropriate files from UCSC REST. I am able to filter and color the data appropriately. If multiple tracks are selected, only the shared/common properties appear. Did code review with Sravani. Ready for pull request.
            Hide
            jsirigin Jaya Sravani Sirigineedi added a comment - - edited

            Created a single Pull request for both tickets, https://jira.bioviz.org/browse/IGBF-3660 and https://jira.bioviz.org/browse/IGBF-3640. Nowlan Freese already reviewed it, Kaushik Gopu Please review it and let me know if find any issues. Added the test case fix for windows as well in the commit and added a try catch block as per Kaushik Gopu suggestion. Here is the updated PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1008

            Show
            jsirigin Jaya Sravani Sirigineedi added a comment - - edited Created a single Pull request for both tickets, https://jira.bioviz.org/browse/IGBF-3660 and https://jira.bioviz.org/browse/IGBF-3640 . Nowlan Freese already reviewed it, Kaushik Gopu Please review it and let me know if find any issues. Added the test case fix for windows as well in the commit and added a try catch block as per Kaushik Gopu suggestion. Here is the updated PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1008
            Hide
            kgopu Kaushik Gopu added a comment -

            IGB was built without skipping test cases; all test cases passed on Windows, and no issues occurred during the build process.
            Jaya Sravani Sirigineedi incorporated suggested changes in the code.

            Show
            kgopu Kaushik Gopu added a comment - IGB was built without skipping test cases; all test cases passed on Windows, and no issues occurred during the build process. Jaya Sravani Sirigineedi incorporated suggested changes in the code.
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged and new code is deployed to "early access" section of the Bioviz.org Web site.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged and new code is deployed to "early access" section of the Bioviz.org Web site.
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Testing main branch installer on Mac.

            I am able to use the Color by... and Filter... options by right-clicking on the track name and selecting Property > property and then selecting from the expanded list of options present in files from UCSC REST. The color and filter options appear to work correctly. If I select multiple files at the same time then only the properties that are shared are available as options.

            Closing ticket.

            Note: Both Kaushik and Sravani did a significant amount of work on this ticket. As Kaushik did the initial work I am assigning the completed ticket to him.

            Show
            nfreese Nowlan Freese added a comment - - edited Testing main branch installer on Mac. I am able to use the Color by... and Filter... options by right-clicking on the track name and selecting Property > property and then selecting from the expanded list of options present in files from UCSC REST. The color and filter options appear to work correctly. If I select multiple files at the same time then only the properties that are shared are available as options. Closing ticket. Note: Both Kaushik and Sravani did a significant amount of work on this ticket. As Kaushik did the initial work I am assigning the completed ticket to him.

              People

              • Assignee:
                kgopu Kaushik Gopu
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: