Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3704

Change the info icon to Universal external link icon

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.1.0
    • Labels:
      None

      Description

      Change the info icon shown at the end of the track name under Available data panel which has a URL link attached to it to the Universal external link icon to make it more understandable to the user that it is a link rather than additional info.

        Attachments

          Activity

          Hide
          jsirigin Jaya Sravani Sirigineedi added a comment -

          Investigated the code and found the part of the code that is responsible for showing the info icon at the end of the track name under the Available data panel. Changed it to some other icon and it's working as expected, to change it to a Universal external icon, I need the icon Nowlan Freese Is it okay if I download the icon from Chrome or do we have any website or something where we get the icons without copyright issues.

          Show
          jsirigin Jaya Sravani Sirigineedi added a comment - Investigated the code and found the part of the code that is responsible for showing the info icon at the end of the track name under the Available data panel. Changed it to some other icon and it's working as expected, to change it to a Universal external icon, I need the icon Nowlan Freese Is it okay if I download the icon from Chrome or do we have any website or something where we get the icons without copyright issues.
          Hide
          nfreese Nowlan Freese added a comment - - edited

          Jaya Sravani Sirigineedi - I don't think there is a specific website we get them from. I made an icon in powerpoint and attached it. Let me know if that works.

          Show
          nfreese Nowlan Freese added a comment - - edited Jaya Sravani Sirigineedi - I don't think there is a specific website we get them from. I made an icon in powerpoint and attached it. Let me know if that works.
          Hide
          jsirigin Jaya Sravani Sirigineedi added a comment -

          Changed the icon to the provided icon it works and getting loaded, it looks like below:

          Nowlan Freese Please review and let me know if it looks good.

          Show
          jsirigin Jaya Sravani Sirigineedi added a comment - Changed the icon to the provided icon it works and getting loaded, it looks like below: Nowlan Freese Please review and let me know if it looks good.
          Hide
          nfreese Nowlan Freese added a comment - - edited

          Jaya Sravani Sirigineedi - I updated the image slightly so that it would look a little better at the lower resolution in IGB (see externalIcon.png). Please use this new image.

          Please note that we only want to replace the "info" icons that appear in the Available Data box in the Data Access tab. The "info" icon is used in many other places in IGB and we do not want to replace those at this moment.

          Show
          nfreese Nowlan Freese added a comment - - edited Jaya Sravani Sirigineedi - I updated the image slightly so that it would look a little better at the lower resolution in IGB (see externalIcon.png). Please use this new image. Please note that we only want to replace the "info" icons that appear in the Available Data box in the Data Access tab. The "info" icon is used in many other places in IGB and we do not want to replace those at this moment.
          Hide
          jsirigin Jaya Sravani Sirigineedi added a comment -

          Changed the icon to the updated icon it works and is getting loaded, it looks like below:

          Updated code is available at the branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3704
          Ann Loraine Please review and let me know if it looks good.

          Show
          jsirigin Jaya Sravani Sirigineedi added a comment - Changed the icon to the updated icon it works and is getting loaded, it looks like below: Updated code is available at the branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3704 Ann Loraine Please review and let me know if it looks good.
          Hide
          ann.loraine Ann Loraine added a comment -

          Thank you! It looks good. Please submit PR when ready.

          Show
          ann.loraine Ann Loraine added a comment - Thank you! It looks good. Please submit PR when ready.
          Hide
          jsirigin Jaya Sravani Sirigineedi added a comment -

          Here is the raised Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1010. Please review and let me know if there are any issues.

          Show
          jsirigin Jaya Sravani Sirigineedi added a comment - Here is the raised Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1010 . Please review and let me know if there are any issues.
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          PR is merged and new installers are built and deployed to the bioviz.org "early access" section.

          Show
          ann.loraine Ann Loraine added a comment - - edited PR is merged and new installers are built and deployed to the bioviz.org "early access" section.
          Hide
          nfreese Nowlan Freese added a comment -

          Testing main branch installer on Mac. External link icon appears correctly in the Available Data window. Clicking on the icon opens a web page.

          Closing ticket.

          Show
          nfreese Nowlan Freese added a comment - Testing main branch installer on Mac. External link icon appears correctly in the Available Data window. Clicking on the icon opens a web page. Closing ticket.

            People

            • Assignee:
              jsirigin Jaya Sravani Sirigineedi
              Reporter:
              jsirigin Jaya Sravani Sirigineedi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: