Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.1.0
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Spring 9, Spring 10
Description
Change the info icon shown at the end of the track name under Available data panel which has a URL link attached to it to the Universal external link icon to make it more understandable to the user that it is a link rather than additional info.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Description | Change the info icon shown at the end of the track name which has a URL link attached to it to the Universal external link icon to make it more understandable to the user that it is a link rather than additional info. | Change the info icon shown at the end of the track name under Available data panel which has a URL link attached to it to the Universal external link icon to make it more understandable to the user that it is a link rather than additional info. |
Jaya Sravani Sirigineedi - I don't think there is a specific website we get them from. I made an icon in powerpoint and attached it. Let me know if that works.
| Attachment | externalIcon.jpg [ 18341 ] | |
| Attachment | externalIcon.png [ 18342 ] | |
| Attachment | externalIcon.pptx [ 18343 ] | |
| Attachment | externalIcon.svg [ 18344 ] |
| Attachment | Screenshot 2024-04-24 at 1.30.12 PM.png [ 18345 ] |
Changed the icon to the provided icon it works and getting loaded, it looks like below:
Nowlan Freese Please review and let me know if it looks good.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Attachment | externalIcon.svg [ 18344 ] |
| Attachment | externalIcon.pptx [ 18343 ] |
| Attachment | externalIcon.png [ 18342 ] |
| Attachment | externalIcon.jpg [ 18341 ] |
| Attachment | externalIcon_large.png [ 18349 ] | |
| Attachment | externalIcon.png [ 18350 ] | |
| Attachment | externalIcon.svg [ 18351 ] | |
| Attachment | externalIcon.pptx [ 18352 ] |
Jaya Sravani Sirigineedi - I updated the image slightly so that it would look a little better at the lower resolution in IGB (see externalIcon.png). Please use this new image.
Please note that we only want to replace the "info" icons that appear in the Available Data box in the Data Access tab. The "info" icon is used in many other places in IGB and we do not want to replace those at this moment.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] | Nowlan Freese [ nfreese ] |
| Attachment | externalIcon_large.png [ 18349 ] |
| Attachment | externalIcon.png [ 18350 ] |
| Attachment | externalIcon.pptx [ 18352 ] |
| Attachment | externalIcon.svg [ 18351 ] |
| Attachment | info.png [ 18354 ] | |
| Attachment | externalIcon.pptx [ 18355 ] |
| Attachment | info.png [ 18354 ] |
| Attachment | externalIcon.png [ 18356 ] |
| Assignee | Nowlan Freese [ nfreese ] | Jaya Sravani Sirigineedi [ jsirigin ] |
| Sprint | Spring 8 [ 192 ] | Spring 9 [ 193 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Attachment | Screenshot 2024-05-08 at 3.32.00 PM.png [ 18372 ] |
Changed the icon to the updated icon it works and is getting loaded, it looks like below:
Updated code is available at the branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3704
Ann Loraine Please review and let me know if it looks good.
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Sprint | Spring 9 [ 193 ] | Spring 9, Spring 10 [ 193, 194 ] |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
Thank you! It looks good. Please submit PR when ready.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Ann Loraine [ aloraine ] | Jaya Sravani Sirigineedi [ jsirigin ] |
Here is the raised Pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1010. Please review and let me know if there are any issues.
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
PR is merged and new installers are built and deployed to the bioviz.org "early access" section.
| Assignee | Ann Loraine [ aloraine ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Testing main branch installer on Mac. External link icon appears correctly in the Available Data window. Clicking on the icon opens a web page.
Closing ticket.
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Fix Version/s | 10.1.0 [ 11000 ] |
Investigated the code and found the part of the code that is responsible for showing the info icon at the end of the track name under the Available data panel. Changed it to some other icon and it's working as expected, to change it to a Universal external icon, I need the icon Nowlan Freese Is it okay if I download the icon from Chrome or do we have any website or something where we get the icons without copyright issues.