Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Spring 10, Summer 1
Description
Situation: There is a bug where if a user applies a filter to, for example, the positive strand, then the user selects Color by... on the negative strand, and then presses cancel (does not use Color by...), the filter from the positive strand is then applied to the negative strand. This bug was introduced in IGB 9.1.6 in IGBF-2509 (see this PR).
Task: Fix it so that Color by... does not pick up the filter info, but also does not cause a null pointer exception (the null pointer was the reason for the attempted fix in IGBF-2509).
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] | Nowlan Freese [ nfreese ] |
| Sprint | Spring 10 [ 194 ] | Spring 10, Summer 1 [ 194, 195 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Tested using Sravani's branch on Mac.
Selecting Color by... and then clicking Cancel no longer applies a filter applied to the other strand's track to the track selected.
Please replace the * imports and then squash relevant commits together (3698 + 3747, leave 3752 as its own commit) and then submit a pull request.
| Assignee | Nowlan Freese [ nfreese ] | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Resolved the imports and squashed the two commits as well. Raised the pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1017. Please review and let me know if there are any issues
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
PR is merged and "early access" installers deployed to bioviz.org.
Ready for integration testing.
| Assignee | Ann Loraine [ aloraine ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested using early-access installer on Mac.
Interacting with Color by... no longer applies filters applied to a separate strand, and does not cause a null pointer exception.
Closing ticket.
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Investigated and fixed the issue, and also fixed the https://jira.bioviz.org/browse/IGBF-1247 this is happening because whenever the user combines and uncombines the tracks every time it refreshes the sequence map and redraws all the tiers, in that workflow filter is being called directly without going through the FilterAction class, so the condition added in the FilterAction in the issues https://jira.bioviz.org/browse/IGBF-3698 didn't resolve it. Updated code is available at the branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-3747. Tested both this ticket and https://jira.bioviz.org/browse/IGBF-1247 working as expected. Please review and let me know if there are any issues.