Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Summer 6, Summer 7
Description
The SNP File Converter icon that is currently being used in the IGB App Manager should be added to the Tools menu in IGB. The icon can be found on Bitbucket: https://bitbucket.org/lorainelab/snp-file-converter/src/master/src/main/resources/images/23andMe-snp-converter-logo.png
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Link | This issue relates to IGBF-3851 [ IGBF-3851 ] |
| Sprint | Summer 6 [ 200 ] | Summer 6, Summer 7 [ 200, 201 ] |
| Rank | Ranked higher |
| Assignee | Dylan Marrotte [ dmarrott ] |
| Assignee | Paige Kulzer [ pkulzer ] |
I don't think we need to add a right-click option for the converter option, so please look at IGBF-3551 for the details of how to add the icon to the Tools menu.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
The app's icon has been added to the tools menu. As for Ann's comment, maybe we can create a separate "investigate" ticket regarding the app's name since this ticket's scope only includes the addition of that icon.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Tested Paige's branch on Mac.
App's icon now appears in the tools menu.
Request for Paige Kulzer - before you create a pull request, please pull the latest changes to master and rebase your IGBF-3850 branch on top (your 3850 branch is missing your changes, including version change, from IGBF-3852).
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
PR is merged and new jar file for the new version (23andMe-snp-converter-10.0.1.jar) is deployed to the Downloads section and ready for testing.
| Assignee | Ann Loraine [ aloraine ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested using bitbucket download page for SNP converter.
App's icon now appears in the tools menu.
Closing ticket.
| Assignee | Paige Kulzer [ pkulzer ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Doing this will likely require editing the SNP Converter code itself, not IGB.
We did this for ProtAnnot at some point, so we can look through the commits in the ProtAnnot repository for ideas on how to make this happen for the SNP Converter App.
Question: Why is it called "SNP Converter" ?
It sounds like it transforms SNPs into something else. I don't think this is what it does, though. It converts a file format into some other file format - is that right? If yes, I think we should try to think of a name that is more specific about what the App does.
How about: "23-and-Me file type converter"
Possible cool use case:
This could be a really cool demonstration of IGB capabilities!