Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.2.0
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 2, Fall 3, Fall 4, Fall 5, Fall 6, Fall 7, Winter 1
Description
In the Filter... feature, users can to add multiple filters for the tracks and these filters appear in a list in the Add\Remove\Edit filters window. When adding Samtools tags options, however, multiple filter options does not seem to work as expected.
When adding a cell barcode(CR) filter, the track only shows reads associated with that CR. Then that filter was removed and another CR filter with a different barcode was added. The same thing happened: reads associated with the CR is displayed. That behavior is expected. However, when both the filters is present in the list, although the expected behavior is for the track to show reads from both the CR values, the observation is that all reads disappear.
Attachments
Issue Links
Activity
PR is merged and new installers are built and deployed to bioviz.org web site early access section.
Ready for testing.
PR is merged.
Regarding testing:
- This changes aspects of filtering logic. For testing, should we check that other filters still work? For example, filtering based on whether annotations (e.g., sequence read alignments) contain gaps, or not.
Tested all the previously mentioned test scenarios. All the scenario's are working good. Hence moving it to ready for pull request.
When multiple filters are added in the list, the logic only displays reads that meet all the filter conditions (AND operation). With Samtools tags, we need an OR operator which displays reads that meet atleast one of the conditions.
Tested with main branch installer on Mac using Karthik's instructions above. I also walked through the various scenarios Udaya outlined and, per Dr. Loraine's suggestion, tested the functionality of several other filter options (e.g., Reads with gaps, Reads with no gaps, Score). Everything seems to be working correctly, no errors in the logs.
Closing ticket.