Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 2018 Sprint 5, Winter 2018 Sprint 1, Winter 2018 Sprint 3, Spring 2019 Sprint 1, Spring 2019 Sprint 2, Summer 2019 Sprint 7, Summer 2019 Sprint 8, Summer 2019 Sprint 9, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Spring 9 : 25 May to 8 Jun, Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 6: 17 Aug - 28 Aug, Summer 7: 31 Aug - 11 Sep, Fall 3: Oct 12 - Oct 23, Winter 5 Feb 22 - Mar 5, Winter 6 Mar 8 - Mar 19, Spring 4 2021 May 3 - May 14, Spring 5 2021 May 17 - May 28, Summer 2 2023 May 29, Fall 4 2023 Oct 16, Spring 2, Spring 5, Fall 1, Fall 5, Fall 6, Fall 7, Winter 1
Description
The main goal of this ticket/issue is for you to practice the IGB workflow using Jira.
You'll make a small change to the code base, test it, and then move your ticket forward in the board.
To start, download and run IGB. Then, Select Help > About Integrated Genome Browser.
Note there is a list of contributors. For this task, add your name to the list.
Note:
- Assign this issue to yourself, and move it into the current spring to the "In Progress" lane.
- Read and review the comments and previous work done by others. Review the comments and history for the linked issues, as well.
- Work on editing the proper section of code and adding your name to the credits. Use the IGB fork-and-branch workflow.
- Once you've completed the code changes, run a successful pipeline, and commented a link to your branch, moved this ticket to the "Needs first level review" column, and unassign yourself.
Reminders and tips:
- Make sure your installer has built (as seen in your downloads section). Whoever does the functional review will download and run your installer.
- Make sure you add a link to your fork and branch as a comment to the issue. Whoever does code review will need the link to find your fork and view your code.
- Use correct voice and format for commit messages.
Reviewers:
- Check that the installer has built.
- Check that all commit messages contain the ticket number.
- Check that commit messages are imperative voice, present tense.
- Check that the ticket contains a link to the fork.
- Check that only one line of code is changed (no whitespace edits).
Attachments
Issue Links
- clones
-
-
- Closed
-
Activity
The commit message contains the ticket number and uses imperative voice, and only one line of code has been changed to add Pranav's name to the credits. Ready for PR!
Thanks Paige.
PR created.
Oh no!
Because I merged an edit by saideepthi jagarapu affecting the same line in the same file, your edit now has a conflict. Unfortunately this means you must re-apply your edit to the new tip of the main branch and update your PR accordingly.
Also, for future reference, please provide a link to your PRs in future tickets, as a convenience for reviewers.
Noted. Dr. Loranine. Will follow the same for future tickets.
Resolved the conflict and added my name.
Successfully triggered the pipeline and downloaded the .dmg file to verify my changes.
Attaching screenshot below for your reference -
Downloads - https://bitbucket.org/pranavbhatia1999/integrated-genome-browser/downloads/
Thank you for updating your branch!
I see that because you updated your branch, your existing PR as shown in the Bitbucket interface is no longer shown as having a conflict.
The link to the PR is: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1058
I am proceeding to merge the PR, and moving this ticket forward on the board accordingly.
PR is merged and new main branch installers are built and deployed to bioviz.org early access section.
Ready for testing.
Tested on Mac by downloading the Early Release installer, I'm now seeing Saideepthi's name in the credits but I'm not seeing Pranav's name like I would expect. I'm also not seeing his name in the credits when I download the installer from Bitbucket.
I cloned his branch and tested his changes locally and was able to see his name in the credits that way, so I'm wondering if something went wrong after the merge conflict? Ann Loraine or Nowlan Freese, any ideas on how to fix this issue?
I installed IGB (IGB-macos-universal-main.dmg) from loraine lab IGB downloads (https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/) and BioViz.org early access and was able to see Pranav's name in the credits. I can also see that the commit is part of the main branch and his name appears in the AboutIGB.html file.
I think this ticket is safe to close.
Added my name is the contributors list.
Successfully triggered the pipeline and downloaded the .dmg file to verify my changes.
Attaching screenshot below for your reference -
*Commit - * https://bitbucket.org/pranavbhatia1999/integrated-genome-browser/commits/fe8ee42f35b1ea69b95b9ac69e0745aa9a0880ad
*Downloads - * https://bitbucket.org/pranavbhatia1999/integrated-genome-browser/downloads/