Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Winter 1, Spring 1, Spring 2
Description
When going through the documentation (https://wiki.bioviz.org/confluence/display/igbdevelopers/Hello+World+IGB+App) to create a new plugin IGB App, came across this sample IGB app https://bitbucket.org/lorainelab/hello-world-igb-app/src/master/ which isn't working as expected now, same case with ncbi-primer, https://bitbucket.org/lorainelab/ncbi-primer/src/master/ both when added as repositories in Manage repositories tab isn't getting added as a new App in the App Manager.
Steps to reproduce:
- Clone a copy of the Hello World App source code from Bitbucket - https://bitbucket.org/lorainelab/hello-world-igb-app
- Build the app using mvn clean install command, it generates a target folder.
- Start IGB
- Select Tools > Open App Manager
- Click Manage Repositories... button (opens Plug-in Repositories tab in Preferences window)
- Click Add... button (opens Plugin Repository dialog)
- Enter a name for your repository (can be anything)
- Click Choose local folder button
- Select the "target" folder in your igb-app-hello-world project folder.
- Once you add "target" as a new local App repository, you should see the Hello World App added as a new App in the IGB App Manager window but this isn't working as expected.
Attachments
Issue Links
Activity
checked main branch to reproduce the issue, observed that we are not able to add both the apps, then tested both the branches by changing igb project versions to 11.0.0, 10.0.0, 10.1.0, 10.2.0, now im able to see both the apps in the IGB App Manager as it should and the app is working as expected. Moving this to ready to PR state
Raised pull requests for both the apps:
https://bitbucket.org/lorainelab/hello-world-igb-app/pull-requests/1
https://bitbucket.org/lorainelab/ncbi-primer/pull-requests/6
New jar files are built and available for downloading from the two repositories: hello world app and ncbi primer app.
Note for testers! Please check this:
One thing I noticed is that the app micro versions have incremented in these new versions of the apps. I'm not sure, but it is possible that a non-10+ version of IGB might allow the new versions to be installed. Whoever tests this should launch the pre-JDK 21 version of IGB and check that the new versions of the apps are not available to install. If they can actually be installed, then go ahead and install them and see what happens.
Tested on main branch with Mac
IGB 9.1.10
Hello World: does not appear in App manager
NCBI Primer App: does not appear in App manager
IGB 10.1.0
Hello World: appears in app manager, runs
NCBI Primer App: appears in app manager, runs
IGB 11.0.0
Hello World: appears in app manager, runs
NCBI Primer App: appears in app manager, runs
This seems like the expected behavior. Closing ticket.
Investigated the issue, the reason is the igb version when importing the igb dependencies in the project, found related past issues: https://jira.bioviz.org/browse/IGBF-3595 and https://jira.bioviz.org/browse/IGBF-1906. When made changes according to these, it works as expected. Here is the updated code: https://bitbucket.org/jaya-sravani/hello-world-igb-app/branch/IGBF-4039.
To Test: Follow the same steps in the ticket description but clone this branch and see whether it's working.