Few IGB Apps are not showing in App Manager when added

Investigated the issue, the reason is the igb version when importing the igb dependencies in the project, found related past issues: https://jira.bioviz.org/browse/IGBF-3595 and https://jira.bioviz.org/browse/IGBF-1906. When made changes according to these, it works as expected. Here is the updated code: https://bitbucket.org/jaya-sravani/hello-world-igb-app/branch/IGBF-4039.

To Test: Follow the same steps in the ticket description but clone this branch and see whether it's working.

Following the steps outlined in the Description of this ticket, I observed the issue of the Hello World app not appearing in the IGB App Manager after it had been added. I then tested Sravani's changes by cloning her branch and following those same steps. Now, the Hello World app is appearing in the IGB App Manager as it should and the app is working as expected.

Tasks for Jaya Sravani Sirigineedi:

• Update your commit message to include the "IGBF-4039" string.
• Link the tickets mentioned in your comment above to this ticket as related issues.
• Implement the same code changes for the ncbi-primer app, then move this ticket back to Needs First Level Review once you're done.

Updated the commit message to include the Jira ticket number and linked the related issues to this ticket as well. Implemented the same changes to the ncbi-primer code as well: https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-4039

Testing Sravani's branch for ncbi-primer on Mac on IGB 10.1.0.

The ncbi-primer app is not showing in the IGB 10.1.0 app manager due to the inclusion of <Import-Package> within the project pom. You can remove the <Import-Package> from the <instructions> of the pom.xml as it will by default import whatever packages it needs. I think by specifying version=10.0.0 for the import-packages the app will only work/show up in IGB 10.0.0.

Update - What I said above is not correct, see IGBF-3518 for a detailed explanation of our strategy on versioning of IGB apps.

Briefly:

By declaring an import-package in the maven-bundle-plugin for the IGB dependencies with just a single version(i.e. 10.0.0), it sets the manifest's import-package version for those IGB dependencies to anything 10.0.0 or greater. Compare this to the normal convention of not passing anything in to the import-package as part of maven-bundle-plugin, which leads to the manifest giving an upper bound of version="[10.0,11)". It would be more "correct" to have the upper bound, as the assumption is that by changing to a new major version we are indicating that there are new changes that would break backwards compatibility. However, it would mean that anytime we changed the major version of IGB, we would need to re-release all apps, whether or not they were compatible.

I found what's the issue, it was a small change that wasn't pushed to my remote somehow, fixed that and it was working in the 10 version. I checked and fixed both the apps for the 11 version and now both of them are working for both the 10 and 11 versions of IGB. Here are the branches:
https://bitbucket.org/jaya-sravani/hello-world-igb-app/branch/IGBF-4039
https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-4039

Note when testing: Change the IGB version i.e., change the version in all the poms in igb project to 11.0.0 (you can do this simply by using the Replace in Files option in IntelliJ) and try to add the apps for that version too.

checked main branch to reproduce the issue, observed that we are not able to add both the apps, then tested both the branches by changing igb project versions to 11.0.0, 10.0.0, 10.1.0, 10.2.0, now im able to see both the apps in the IGB App Manager as it should and the app is working as expected. Moving this to ready to PR state

Raised pull requests for both the apps:
https://bitbucket.org/lorainelab/hello-world-igb-app/pull-requests/1
https://bitbucket.org/lorainelab/ncbi-primer/pull-requests/6

Hello world PR merged.
NCBI Primer app PR merged.

New jar files are built and available for downloading from the two repositories: hello world app and ncbi primer app.

Note for testers! Please check this:

One thing I noticed is that the app micro versions have incremented in these new versions of the apps. I'm not sure, but it is possible that a non-10+ version of IGB might allow the new versions to be installed. Whoever tests this should launch the pre-JDK 21 version of IGB and check that the new versions of the apps are not available to install. If they can actually be installed, then go ahead and install them and see what happens.

Tested on main branch with Mac

IGB 9.1.10
Hello World: does not appear in App manager
NCBI Primer App: does not appear in App manager

IGB 10.1.0
Hello World: appears in app manager, runs
NCBI Primer App: appears in app manager, runs

IGB 11.0.0
Hello World: appears in app manager, runs
NCBI Primer App: appears in app manager, runs

This seems like the expected behavior. Closing ticket.